From: Paul Menage <menage@google.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ken Chen <kenchen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch] export percpu cpuacct cgroup stats
Date: Thu, 4 Dec 2008 15:02:31 -0800 [thread overview]
Message-ID: <6599ad830812041502m15f54f0ckd8baa0a1792fc31e@mail.gmail.com> (raw)
In-Reply-To: <49376BE3.1040909@cn.fujitsu.com>
On Wed, Dec 3, 2008 at 9:34 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> +
>> static struct cftype files[] = {
>> {
>> .name = "usage",
>> .read_u64 = cpuusage_read,
>> .write_u64 = cpuusage_write,
>> },
>> + {
>> + .name = "percpu",
>
> IMO percpu_usage is a better name.
>
Maybe usage_percpu ?
That fits in with the style used in e.g. memory.limit_in_bytes where
the first word is the important quantity, and the subsequent words
indicate some aspect of the quantity.
Paul
next prev parent reply other threads:[~2008-12-04 23:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 4:48 Ken Chen
2008-12-04 5:34 ` Li Zefan
2008-12-04 9:24 ` Ingo Molnar
2008-12-04 23:02 ` Paul Menage [this message]
2008-12-05 7:44 ` Ken Chen
2008-12-05 7:54 ` Li Zefan
2008-12-05 8:30 ` Ken Chen
2008-12-05 8:35 ` Li Zefan
2008-12-05 13:52 ` Ingo Molnar
2008-12-05 18:16 ` Ken Chen
2008-12-07 7:27 ` Andrew Morton
2008-12-08 14:33 ` Ingo Molnar
2008-12-05 18:10 ` Ken Chen
2008-12-08 1:25 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830812041502m15f54f0ckd8baa0a1792fc31e@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®