From: Paul Menage <menage@google.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] Allow cpusets to be configured/built on non-SMP systems
Date: Mon, 2 Mar 2009 22:41:42 -0800 [thread overview]
Message-ID: <6599ad830903022241o222ed5acjd4d91625ea79f629@mail.gmail.com> (raw)
In-Reply-To: <6599ad830903022201s4d2296c7u225e84a77f9f7167@mail.gmail.com>
On Mon, Mar 2, 2009 at 10:01 PM, Paul Menage <menage@google.com> wrote:
> On Mon, Mar 2, 2009 at 7:17 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>>> +static int generate_sched_domains(struct cpumask **domains,
>>> + struct sched_domain_attr **attributes)
>>> +{
>>
>> Except here should "return 0;", otherwise emit a compile warining.
>>
>
> Good catch - the weird thing is that (in my UML build) it doesn't
> actually generate that warning. Mysterious.
Hmm, my guess is that since UML doesn't have hotplug either, the only
reference to generate_sched_domains doesn't actually invoke it, so gcc
doesn't even bother compiling it.
Paul
next prev parent reply other threads:[~2009-03-03 6:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 1:36 Paul Menage
2009-03-03 2:01 ` Li Zefan
2009-03-03 3:17 ` Li Zefan
2009-03-03 6:01 ` Paul Menage
2009-03-03 6:41 ` Paul Menage [this message]
2009-03-03 8:26 ` Paul Menage
2009-03-03 8:42 ` Li Zefan
2009-03-03 8:54 ` Li Zefan
2009-03-03 8:07 ` Ingo Molnar
2009-03-03 23:52 Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830903022241o222ed5acjd4d91625ea79f629@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®