mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menage <menage@google.com>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: locking design for task_subsys_state()?
Date: Mon, 25 Jan 2010 18:08:51 -0800	[thread overview]
Message-ID: <6599ad831001251808k143c03fal14fe6bf5f19e0e5e@mail.gmail.com> (raw)
In-Reply-To: <20100124232512.GA12383@linux.vnet.ibm.com>

On Sun, Jan 24, 2010 at 3:25 PM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
>
> Is there some flag in the task structure that I should check in order to
> suppress this splat, and, more important, to document the locking
> design?  Here is what I currently have in my local tree:

Nothing cgroup-specific as far as I know - I guess it's just assumed
that since nothing else can be accessing the task_struct at that point
as it's not linked into any lists (is that correct?) then there's no
locking needed. If there's no generic task flag that indicates that
the task has never been exposed to any other thread via a list, etc,
it could be added? I imagine that some other subsystems are likely to
have similar problems. Alternatively, adding an RCU read-lock pair
around the relevant code is probably possible too, even if not
technically necessary.

Paul

      reply	other threads:[~2010-01-26  2:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-24 23:25 Paul E. McKenney
2010-01-26  2:08 ` Paul Menage [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad831001251808k143c03fal14fe6bf5f19e0e5e@mail.gmail.com \
    --to=menage@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®