From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FA8FC4727E for ; Fri, 25 Sep 2020 22:37:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E08A21775 for ; Fri, 25 Sep 2020 22:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601073470; bh=TYuTe9g0mwa2Y2IZS451izNtSZ/ugBwYsG+gLW1eHno=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=qI118eB/7pzWdWGu75CopuCUatbnHiYP+Hwg2w5XbQ15fqOfIO3gOpaQ4RfXyR7Ra 4JCSdcUZ4xA3ASg4UyVRWScvLUOA2drpNQ3xw0JuFA82384OyISiQUAzuAKJlpEn/C 23U7Fhr+7Ovi209VtIx9rlijkCSnnQQW/T5O0jbU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729047AbgIYWhs (ORCPT ); Fri, 25 Sep 2020 18:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbgIYWhs (ORCPT ); Fri, 25 Sep 2020 18:37:48 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA41DC0613CE for ; Fri, 25 Sep 2020 15:37:47 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id a3so4430133oib.4 for ; Fri, 25 Sep 2020 15:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1GUnPWZQb3wmsz17jd8cPsFjDlwSIdeaeunn4YKd8bc=; b=cUGmiVVab0u8mYTiDe3U8u1ya2bN2aQHwiRyr0oN+SEQeoBac0yel+rVAJpG23d6Cw SkWYyhXR+Q0RhmtVczpwc52Ra7P92GEyVfLujifP74L85bN+J8e9V+D07zbcd4hggTWn sTf5Y3Nm3Lj+rn13yl8gTMvITuy5xWYxaBBBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1GUnPWZQb3wmsz17jd8cPsFjDlwSIdeaeunn4YKd8bc=; b=O77pLodq1lg+vulpudxLP/QOEvKbwr5wIgyOl7o1o/p004daV96biZyaeE99/j3Z5y dxzE18mSzd7IReeGFH5Et6bppdaclvWP4m9dwMJcBmbWkxQOyIeVVnuDs4pkXTzjPln1 Gi4+C200bdrN4vj9bVdpSI/7IsZYiGN1GU55lqsPZ1LxFldI/FogRt49aqLZ36wkPOh3 OxWK+HB0cB1pGZIy9ln8XC3OLiuIP4QPp0nhXdfduapJUkKVhmPETnMc3T2lwVEr7cZ+ MP9S1Q7yv5y511WrG09dmgR5USkYwAbAREafQTquuv3IGOcRJHlSt0COFryqBlz6y5k4 yN9Q== X-Gm-Message-State: AOAM531UYIYi3rqpW77hVw9FL/6Of0zCqtC2RxI9OAOS2c3xJuxQ0SU5 SlsNNUMZnXhpYGys+fNly1Ldkw== X-Google-Smtp-Source: ABdhPJzlc9XcIwkgj1jA3voZXHCy+z/zzMdn6CUvY2QhJa2e+80Yy/KlTGUEECczFqtoREwqoRqFAA== X-Received: by 2002:aca:d693:: with SMTP id n141mr496407oig.26.1601073467264; Fri, 25 Sep 2020 15:37:47 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id i7sm983027oto.62.2020.09.25.15.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 15:37:46 -0700 (PDT) Subject: Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable To: Kees Cook , Shuah Khan Cc: Hangbin Liu , "open list:KERNEL SELFTEST FRAMEWORK" , Jonathan Corbet , Naresh Kamboju , linux-doc@vger.kernel.org, open list , Tim.Bird@sony.com, lkft-triage@lists.linaro.org, Anders Roxell , Justin Cook , Linux-Next Mailing List , Shuah Khan References: <20200914021758.420874-1-liuhangbin@gmail.com/> <20200914022227.437143-1-liuhangbin@gmail.com> <202009251414.15274C0@keescook> From: Shuah Khan Message-ID: <659b23c9-abf5-0387-c4c6-5d0a48e3afdc@linuxfoundation.org> Date: Fri, 25 Sep 2020 16:37:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <202009251414.15274C0@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/25/20 3:16 PM, Kees Cook wrote: > On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote: >> On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote: >>> >>> Currently, after generating run_kselftest.sh, there is no way to choose >>> which test we could run. All the tests are listed together and we have >>> to run all every time. This patch enhanced the run_kselftest.sh to make >>> the tests individually selectable. e.g. >>> >>> $ ./run_kselftest.sh -t "bpf size timers" >> >> My test run break on linux next >> >> ./run_kselftest.sh: line 1331: syntax error near unexpected token `)' >> ./run_kselftest.sh: line 1331: `-e -s | --summary ) >> logfile=$BASE_DIR/output.log; cat /dev/null > $logfile; shift ;;' > > Yes, please revert this patch. The resulting script is completely > trashed: > > BASE_DIR=$(realpath $(dirname $0)) > . ./kselftest/runner.sh > TESTS="seccomp" > > run_seccomp() > { > -e [ -w /dev/kmsg ] && echo "kselftest: Running tests in seccomp" >> /dev/kmsg > -e cd seccomp > -en run_many > \ > -ne "seccomp_bpf" > \ > -ne "seccomp_benchmark" > > -e cd $ROOT > } > > > Will do. thanks, -- Shuah