mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Loehle <christian.loehle@arm.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Valentin Schneider <vschneid@redhat.com>,
	Petre-Ionut Tudor <petre-ionut.tudor@arm.com>
Subject: Re: [PATCH] sched/debug: Print slice length for fair tasks
Date: Wed, 29 Jan 2025 18:04:48 +0000	[thread overview]
Message-ID: <659b272b-b27e-44a8-b8dd-a6821c1daeba@arm.com> (raw)
In-Reply-To: <453349b1-1637-42f5-a7b2-2385392b5956@arm.com>

On 1/29/25 17:59, Christian Loehle wrote:
> With commit 857b158dc5e8 ("sched/eevdf: Use sched_attr::sched_runtime
> to set request/slice suggestion") we have the userspace per-task tunable
> slice length so print it in /proc/$PID/sched.
> 
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
> ---
>  kernel/sched/debug.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index fd7e85220715..ef047add7f9e 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -1262,6 +1262,8 @@ void proc_sched_show_task(struct task_struct *p, struct pid_namespace *ns,
>  	if (task_has_dl_policy(p)) {
>  		P(dl.runtime);
>  		P(dl.deadline);
> +	} else if (fair_policy(p->policy)) {
> +		P(se.slice);
>  	}
>  #ifdef CONFIG_SCHED_CLASS_EXT
>  	__PS("ext.enabled", task_on_scx(p));

So Peter added a debug slice length print for all tasks on
the rq in commit ("147f3efaa241 sched/fair: Implement an EEVDF-like
scheduling policy") already, but that alone is a bit awkward to play
with when modifying slice length for specific tasks which aren't
always enqueued.

  reply	other threads:[~2025-01-29 18:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 17:59 Christian Loehle
2025-01-29 18:04 ` Christian Loehle [this message]
2025-01-31 10:00 ` [tip: sched/urgent] sched/debug: Provide " tip-bot2 for Christian Loehle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=659b272b-b27e-44a8-b8dd-a6821c1daeba@arm.com \
    --to=christian.loehle@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=petre-ionut.tudor@arm.com \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®