From: Roger Quadros <rogerq@ti.com>
To: Yue Haibing <yuehaibing@huawei.com>, <kishon@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <hulkci@huawei.com>
Subject: Re: [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static
Date: Thu, 6 Jun 2019 11:14:45 +0300 [thread overview]
Message-ID: <659d9904-fa9a-a03b-b609-0ac053520c9a@ti.com> (raw)
In-Reply-To: <20190418133633.3908-1-yuehaibing@huawei.com>
On 18/04/2019 16:36, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/phy/ti/phy-am654-serdes.c:250:12: warning:
> symbol 'serdes_am654_xlate' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/phy/ti/phy-am654-serdes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/ti/phy-am654-serdes.c b/drivers/phy/ti/phy-am654-serdes.c
> index d376920..f8edd08 100644
> --- a/drivers/phy/ti/phy-am654-serdes.c
> +++ b/drivers/phy/ti/phy-am654-serdes.c
> @@ -247,8 +247,8 @@ static void serdes_am654_release(struct phy *x)
> mux_control_deselect(phy->control);
> }
>
> -struct phy *serdes_am654_xlate(struct device *dev, struct of_phandle_args
> - *args)
> +static struct phy *serdes_am654_xlate(struct device *dev,
> + struct of_phandle_args *args)
> {
> struct serdes_am654 *am654_phy;
> struct phy *phy;
>
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2019-06-06 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 13:36 Yue Haibing
2019-05-30 15:13 ` Yuehaibing
2019-06-06 8:14 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=659d9904-fa9a-a03b-b609-0ac053520c9a@ti.com \
--to=rogerq@ti.com \
--cc=hulkci@huawei.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®