mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhi Wang <zhi.a.wang@intel.com>
To: Peng Hao <penghao122@sina.com.cn>,
	zhenyuw@linux.intel.com, jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com, airlied@linux.ie
Cc: intel-gvt-dev@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Peng Hao <peng.hao2@zte.com.cn>
Subject: Re: [PATCH] drm/gvt : fix error message typo
Date: Fri, 5 Oct 2018 04:13:15 -0400	[thread overview]
Message-ID: <659e1b3d-8b17-e380-4196-340596ec9740@intel.com> (raw)
In-Reply-To: <1538669074-26012-1-git-send-email-penghao122@sina.com.cn>

Hi:

Thanks for the patches. :) Several places needs to be improved:

1. The prefix of the patch should be: "drm/i915/gvt:".
2. You can just cc the maintainers of gvt since the gvt is a sub-module 
of i915.
3. Better refine the tittle of the patch and also the commit message. An 
informative title and commit message would be more friendly to people 
who reading this later, even it's only a small typo. :)

Again. Thanks for the patch. :) I will fix that for you and commit it, 
so you don't need to send it again.

Thanks,
Zhi.

On 10/04/18 12:04, Peng Hao wrote:
> 
> From: Peng Hao <peng.hao2@zte.com.cn>
> 
> gvt_err message typo.
> 
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>   drivers/gpu/drm/i915/gvt/gvt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c
> index 46c8b72..31d6809 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.c
> +++ b/drivers/gpu/drm/i915/gvt/gvt.c
> @@ -438,7 +438,7 @@ int intel_gvt_init_device(struct drm_i915_private *dev_priv)
>   
>   	ret = intel_gvt_debugfs_init(gvt);
>   	if (ret)
> -		gvt_err("debugfs registeration failed, go on.\n");
> +		gvt_err("debugfs registration failed, go on.\n");
>   
>   	gvt_dbg_core("gvt device initialization is done\n");
>   	dev_priv->gvt = gvt;
> 

      reply	other threads:[~2018-10-05  8:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 16:04 Peng Hao
2018-10-05  8:13 ` Zhi Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=659e1b3d-8b17-e380-4196-340596ec9740@intel.com \
    --to=zhi.a.wang@intel.com \
    --cc=airlied@linux.ie \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.hao2@zte.com.cn \
    --cc=penghao122@sina.com.cn \
    --cc=zhenyuw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome