From: Gagan Sidhu <broly@mac.com>
To: Richard Weinberger <richard@nod.at>
Cc: ZhaoLong Wang <wangzhaolong1@huawei.com>,
chengzhihao1 <chengzhihao1@huawei.com>,
dpervushin <dpervushin@embeddedalley.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
yangerkun <yangerkun@huawei.com>, yi zhang <yi.zhang@huawei.com>
Subject: Re: [PATCH v2] ubi: gluebi: Fix NULL pointer dereference caused by ftl notifier
Date: Mon, 17 Jun 2024 10:05:13 -0600 [thread overview]
Message-ID: <65E62DA3-EF16-44BD-8E51-E751BD2C496F@mac.com> (raw)
In-Reply-To: <1641029267.251608.1718640023954.JavaMail.zimbra@nod.at>
i don’t think my articulation is correct if you interpreted it as that.
as i understand it, gluebi simply makes it handy when you have a filesystem packed within a ubi file, and it will take that file and mount itas a block device.
so i would say it’s not MTD->UBI->GLUEBI->MTD->MTDBLOCK
it’d say it’s more MTD->GLUEBI->MTDBLOCK
that is, the squashfs (actual filesystem) is simply wrapped in a ubi file for gluebi, which will then make it a block device.
i’m not using an actual UBIFS anywhere, aside from sitting underneath the squashfs to handle the mapping from the squash to the nand (to handle bad blocks).
e.g. i have a rootfs in a squashfs file
-i wrap that squashfs file into a squashfs.ubi
-i use gluebi to detect this squashfs.ubi file as a block device and mount it
that’s about it.
Thanks,
Gagan
> On Jun 17, 2024, at 10:00 AM, Richard Weinberger <richard@nod.at> wrote:
>
> ----- Ursprüngliche Mail -----
>> Von: "Gagan Sidhu" <broly@mac.com>
>> yes, i have a squashfs inside a ubi volume, and i create ubi block device from
>> it.
>>
>> i do use config_mtd_ubi_block because the filesystem is squashfs.
>>
>> so i think it’s affirmative to both questions. gluebi for the block device from
>> the ubi.fs file, then config_mtd_ubi_block to mount this read-only filesystem
>> as a block device.
>>
>> the end result of both options is a read-only block device that can handle bad
>> blocks on nand devices.
>>
>> if i was using an M25P80, i wouldn’t even be using ubi.
>>
>> so CONFIG_MTD_UBI_{GLUEBI,BLOCK} are handy for cases where you need an mtd block
>> device with a read-only file system where the UBI takes care of the
>> idiosyncrasies that make NAND (imo, ofc) inferior to SPI
>
> Isn't MTD -> UBI -> GLUBI -> MTD -> MTDBLOCK performance wise a nightmare?
> We have UBIBlock for this use case.
>
> Thanks,
> //richard
next prev parent reply other threads:[~2024-06-17 16:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 14:25 Gagan Sidhu
2024-06-17 14:31 ` Richard Weinberger
2024-06-17 15:42 ` Richard Weinberger
[not found] ` <14779870-BA54-4ABF-8ABF-FF1D23D172A7@mac.com>
2024-06-17 16:00 ` Richard Weinberger
2024-06-17 16:05 ` Gagan Sidhu [this message]
2024-06-17 16:52 ` Richard Weinberger
[not found] ` <E3E2C13C-1E52-46F2-BE2D-D2592C3369DB@mac.com>
2024-06-17 17:33 ` Gagan Sidhu
2024-06-17 17:48 ` Gagan Sidhu
2024-06-17 18:09 ` Richard Weinberger
2024-06-17 18:18 ` Gagan Sidhu
2024-06-17 18:32 ` Richard Weinberger
2024-06-17 18:46 ` Gagan Sidhu
2024-06-17 18:52 ` Richard Weinberger
2024-06-17 20:29 ` Daniel Golle
2024-06-17 21:22 ` Gagan Sidhu
2024-06-17 22:13 ` Gagan Sidhu
2024-06-18 4:03 ` Zhihao Cheng
2024-06-20 22:06 ` Gagan Sidhu
2024-06-21 1:59 ` Zhihao Cheng
2024-06-21 2:09 ` Gagan Sidhu
2024-06-21 3:03 ` Zhihao Cheng
2024-06-21 4:27 ` Gagan Sidhu
2024-06-21 4:55 ` Zhihao Cheng
2024-06-21 11:36 ` Gagan Sidhu
2024-06-22 2:37 ` Zhihao Cheng
2024-06-22 2:43 ` Gagan Sidhu
2024-06-22 21:07 ` Daniel Golle
2024-06-24 19:00 ` Gagan Sidhu
-- strict thread matches above, loose matches on Subject: below --
2024-06-17 14:21 Gagan Sidhu
2023-10-18 12:16 ZhaoLong Wang
2023-10-19 1:57 ` Zhihao Cheng
2023-10-19 20:27 ` Richard Weinberger
2023-10-20 2:27 ` Zhihao Cheng
2023-10-21 16:09 ` Richard Weinberger
2023-10-23 6:41 ` ZhaoLong Wang
2023-10-23 6:46 ` Richard Weinberger
2023-10-23 7:12 ` ZhaoLong Wang
2023-10-23 7:16 ` Richard Weinberger
2023-10-23 7:09 ` Zhihao Cheng
2023-10-23 7:15 ` Richard Weinberger
2023-10-23 7:36 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65E62DA3-EF16-44BD-8E51-E751BD2C496F@mac.com \
--to=broly@mac.com \
--cc=chengzhihao1@huawei.com \
--cc=dpervushin@embeddedalley.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=wangzhaolong1@huawei.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®