From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933728AbdKGJuI (ORCPT ); Tue, 7 Nov 2017 04:50:08 -0500 Received: from mail-eopbgr30044.outbound.protection.outlook.com ([40.107.3.44]:46776 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752039AbdKGJuE (ORCPT ); Tue, 7 Nov 2017 04:50:04 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Chris.Redpath@arm.com; Subject: Re: [PATCH v3] cpufreq: schedutil: Examine the correct CPU when we update util To: Viresh Kumar , "Rafael J . Wysocki" Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Morten Rasmussen , Dietmar Eggemann , Ingo Molnar , Peter Zijlstra References: <20171103034022.GD4240@vireshk-i7> <20171103133642.8636-1-chris.redpath@arm.com> <20171103154559.GJ4240@vireshk-i7> From: Chris Redpath Message-ID: <65a16c84-d25f-26ce-b4cf-5edc3f9b6d32@arm.com> Date: Tue, 7 Nov 2017 09:49:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171103154559.GJ4240@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: DB6PR0501CA0011.eurprd05.prod.outlook.com (2603:10a6:4:8f::21) To VI1PR0801MB2752.eurprd08.prod.outlook.com (2a01:111:e400:7b7f::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28759403-02ef-4ac9-9395-08d525c4e9ef X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:VI1PR0801MB2752; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2752;3:XH5u3uD3jrggwdCT/6AMwcBQV8S8s8aPysD4d8Pb7MAUPxIUisPqt9dzqtIL83YNT+ofAiw3CgKO76kPHd3TQDWbB+uDWcEIo/Z+dxRRLlSVDPFzMVb+17bYJ0lFR++xuCqcthC34yEnth+G1qQ6W9A9tQkm973HwmBzY45JIN0euiMKQvXxMnz/ymcr9MtjAo5loWjdN1zgdE4rMbTLXeTR+2wUDujIIrt5PlUD7mkueJfbAodjs0iCKCfVHPGQ;25:aWvps1SgdmSN7/IwPdrKH8sgnanAV+1BnwUlnl9O8+H1iOSeSSnIqNgfDaHrlBf5db5d3ZsoCPSbgdVDNN/zD3HMK91CojZ/CHCJ1fkRXI63TfCCo4FYyeudp2xLpUsUqbbTRJysP9hCe0ESRNoNs1piIAAcDWXtX18q3wLr75yr9rxDrNn/VnXz3QKzmx9ONCZjw3CmbVM6I9zRWyxHcjMjKz/yPKcXQ+D1kkPV4Y5oxoMSTZvlzD81QL3tubV9Cx64IzNxAgC62xjoHNk6qN00R3BTjTEQBOUGso0QPlnvRa89QSuveIWuAfUoEUrwyETwcWlC4WxUp1iEtxhiuw==;31:p7S1m9ClonjoIaqf9x4tgWmb/JItUScLytXHHBBVdGmMBr1XUTH7GQx/zmirHl/5wz0N7i02l1n2AtEoKU6E7hg3aYHcsGfdXf7WOtH8OG/1peBL1psbVnClmHvejH+HZD71vsFj1ABce0nbFUOQ0dB7+cshNXjp1HrJyY7CGkkX97kU9qwCjKN7Oe4+QcEdJDWwo67pwlFXu3kXzuJgiC+uGtlBDZLqlF8IZXV48t8= X-MS-TrafficTypeDiagnostic: VI1PR0801MB2752: X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2752;20:qcdZaNVeBAgB6lvoWwpYqXDMisxEvezOjAnvKVRgX6xpdH9CgjlUx2K8SYWPXCigegZFgT5Rvx5nQkP4apDMY5zOFcd48+0dkI7f9qJHzYE5Hn6tOzVTxxkw/nmvLPoT+VJXM3YzjOTXZ6JxWLOC4Qe3tvMCSsx2hFhCsDPUSW3UI3H3mdTLD4+Y08aWc/OETv5Xt3hx706t2rz0npPcDFB65jr2VkoorM+Yzh/i4ReCUFcDBcFK6BcVhbYEbIwcpU/cmAOYp/yXCb9LOVcr8+lomHHKPQmKzTNmtnWT+wJ7DLMd5x8DcwRY1xeVZmMEVcpkBt0AceqvMlcqwWLzT9tLLKB68qcQS/uqek4gEB+RIlEBAxyHm7YDDujFq1XrSVRRi41u4BCcWunYuWm/wP2Lu37oxb/wfEr0oOGjOMqXv8myDORU/rkEcPszGWA4g3T7YW7hTQgD2SC/UazSX7l2aC+r5Xu1lyN+bvXoRrumVCohlvKRi1tR9K4/X1vj;4:Iworeu/kQKmuazMR2opswtsF86ekQtqJo5W1n0c06/UtEXSERTj7TMS9niMUcNIPI/a4gJ0+1s3bppTF+dCFp5imWQBvYJwefCLs06EtLl6tzu4vXAYqq0+5iiZMxsRWtamONrr2bisxJBO6ohoT0y8i7eTAMgE481R9rV7iaorgVRJQzgmPssjgTELT2eHtYuSViEtmQy1/s9f7EGvAxvJacWzw9vFhrJSxF+0tArlpjTF1nUf2BALsJD6GPGh+GFoIUF/skJUAktKHh8A0nRrJ+B+gRAevY1lqaXIvkT/aJDL/WMLdcnTBRw9ta/ha X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231021)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0801MB2752;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0801MB2752; X-Forefront-PRVS: 0484063412 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(189002)(199003)(40434004)(377424004)(24454002)(106356001)(86362001)(316002)(3846002)(72206003)(83506002)(25786009)(65826007)(23676003)(67846002)(478600001)(8746002)(2906002)(110136005)(54906003)(58126008)(6116002)(2950100002)(81156014)(65806001)(65956001)(66066001)(53546010)(81166006)(16576012)(5890100001)(47776003)(229853002)(36756003)(6486002)(8936002)(77096006)(31696002)(33646002)(101416001)(31686004)(50466002)(5660300001)(305945005)(105586002)(15650500001)(64126003)(16526018)(189998001)(53936002)(54356999)(50986999)(76176999)(8676002)(97736004)(6246003)(68736007)(4326008)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0801MB2752;H:[10.1.210.47];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4MDFNQjI3NTI7MjM6bG83TGZnMzhmM2pudHdyaG1xZzg3VWtr?= =?utf-8?B?M0E0dVN5WjZRMHRabWoyZWQ2bGh3M3dBRWZqVWRmUTdsbktyWktBdzltdU5I?= =?utf-8?B?ZERsaFYwMHZGS1hiSWVTaEJnT3Vjdmw5bVJTN2wrc2Y3SXNWdk5sT3J1VjYy?= =?utf-8?B?QzNBOE1xTGk3clVvQ1NzTXM5UGpGWFZLZTN1cmFPSTVsNjhuZG1HZnh3c3U2?= =?utf-8?B?RWlwSiszazNKK3JzamtlQzlQa282cHNyTUtuNkFUOGUzbmxld2I1aTVWa0RR?= =?utf-8?B?OW9CQ3VZdmsvVlRUVzNDR1dxWUVTeDhsZkNuSU40SFpwN1Z4UmlJYzR0Znlv?= =?utf-8?B?QSsvOWJzdGQvWU4vSVRKemN6RENHTUhreUN0UVJUdkxRa0JFc2xlTWZINWhK?= =?utf-8?B?dnNYNTQ3aDdEeDQxdk5iZVBzZ1Q3U01BUk1nVXNvcCtWV2kxMlBuZFNDZnZi?= =?utf-8?B?RVZIRnRhSXhYTWFJREJwWkpVSHdaZnF4RjlCdXQ3WHAvQ2RBQ01Gd1BRa2hB?= =?utf-8?B?T1hCUW4za1BCZnJUM1lhdklmbUVBYXA0TEt3NzFFN0ZZZ2hEVllTSkVjWmpJ?= =?utf-8?B?SUxHcFhqK3RPZ3FydUpPeHdzOFhNSGJpeDBhQVJKQ3NSa1JPckJYeE01N1Jx?= =?utf-8?B?QzR0SmljRjFnNTNZMUw2UmQ0VFJLQ2owR3ErL3JSajVsU0ZleWc5V2J1a0VB?= =?utf-8?B?QzVneWxXZG1PWFB1VGF5ODh4MGtSQVdVK3BRREJ2SktzRmI5ZzhES1JnN1Nh?= =?utf-8?B?QjBVa1g3Z3I0WklJdGh5WXppVnUzdnowYnJjNXMwOWs2OXNrNFlYSWh0WUN2?= =?utf-8?B?OTlEK1ZMUnMwb1FHRVdWWWNEaisyYTJhN29oTDJHWVk0M2xpMDFocVhhWTVy?= =?utf-8?B?bWtXc3BPQ00wUUd1NllVZlA3enJjeEpib211ZWFwTC9ubDg1VUZYbjR6NnpD?= =?utf-8?B?VGhwTkJ5cFZiaFZ4T2ZjcktRdUZTcmd2VzZCUjcybWZncHdsSXlLTmRQVzNU?= =?utf-8?B?Vm4wM0VZSHZSVDVwRU9KSitLUDYzZmM3alFNRm54VlFOMlRpN2hqRy9WWkdV?= =?utf-8?B?bWs0dC9TUGs1S244bDBsSUQzYVVjZTZCVFNVQmdhK3JZUnM0YUhBOCs3a2kr?= =?utf-8?B?eVZWSjJUOUVqZlRtdU9BeWtRa0k4YnFRQ3J3aU55c0VkdW9JRC91U09ZK1NC?= =?utf-8?B?eHp2RHprVTRDMDFPV2xqdFlHNkpWOFlIWlJvSkk3UXNZSWYwaG0ycEV1RkIy?= =?utf-8?B?RTAxU0JLUDA4ZW5yQzBzVW1FOWN5dW9zYzBWeXVSbUt3WU1VbThobjJ4a3Av?= =?utf-8?B?eFlXU2FMY3lYOTFQKzQzS20yQWhmaUh6My9PMVIyWHI4STdGRUVMeE5BYWtl?= =?utf-8?B?U29TMS9zNS9EVWMzcStFM2ZjeEdGWGF2cHF3MGdHeVhOLzRrMXNYamJCN1h0?= =?utf-8?B?dll5TU9GL1dCajdqd1lqdjlMNXdTeEl2aWtydGVBWk1HTEFrQllJZ0FhTnB2?= =?utf-8?B?SXlTVlM4d29hajlsVEIyb0RtOUN4d1hxOWx5cTcycVhlRjMzMVNqV29MVksr?= =?utf-8?B?WGRTZW03NG5tMGNyWDd4YnM5MTI0YVJ3TTM5VFByRlJLSVRvMmVKUUN1OFM5?= =?utf-8?B?SzlrYzlPeG1wNGg1OHQybXhGTWpxWU9rUWt0eHkxVnhoMERKTVpCMDAvWCsv?= =?utf-8?B?aU1XL1gwMzdSZlpKNnJ3MjQvOWVQNUppUWxBR0NoVE9saVVYTnBNY0ZJRnV2?= =?utf-8?B?REpHcFVCMVptYWNPWENmZEtveEJldUhtSFdYbG9ZTWdjOThNbmdzVE9uVnNr?= =?utf-8?B?THhZdUxhNjJ4SjRPV3NhSkJ4cUNnRTI5RDlFblNNY0psTUxBRjR2ekNRZEd1?= =?utf-8?B?Ujd4WDhmRkdRc1Z6WXFwK1VVNksyN3JZOHZBakNwaTE4aklOaTZRVUp0TVdr?= =?utf-8?B?bFBQRjBsSEJCM09XTGJQRlIyVEhOMGxpVTdSc0laREFydHU4N3FWOXF6VTky?= =?utf-8?B?QzZpbVFzb1RSZ1h5bzJSR3oxU0haaW9BM29hSGNRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB2752;6:jJVuiWFiEkQDvOsaVcCwwG0ucC9SLwCQvvQUgbNjbWklk/Ipcaz5qFXCehiqWkCOmD18kSgMXSKKpObn6bgnCbuRhMIOFIMX3w2N9mSkO1Q59XTsw1NJOVBcqaeEq9szPCmyfSdqGqmcpChXCPLRYEKsjskiZLoIazzHl6DToBf+OJCN+Kwg+CpqiSTeCN4qgDo+yWw2fmFg6dq851QnRrily24AMHnXd2Rzt5VKlHMLklDzv7Jmn6bnt1k9v0eDAK5YU+n0HWV6Gn/P3lC6LynGDZK4btiFQmW8S7VBTUOWJbS10ZEcnkZI1siltxOe78VDfIiqY9sHamXY74T4wDyDHXdZJc+AGtYAr3jzYU8=;5:2bP//G0PpKvNPTg+mG1YbvcHLnT65zEAswfFNbeu48haSjFE46ArnC8dvYz/ngLI11TEZ+NXUzIpNiIHnryMU96miwiuwhHv7rRv63nTcBCU0Hpz1wQCcr9J2FhKiS++UexYMeILaP75N+7mtGNV5P8km3B8kUX1Xx/aglNKejs=;24:Mwb6GUW6lUt5a+ZOYmKfF0Cdtx0HGfvPztL+XDiUHuE9tQS7on46Hrb19ZOZvrEyhnIE/EzJM1G/Uy+Mlz5vSAJfRhP35AiEJzjm1p4Jp7E=;7:hkXzt0USnJZxdUUi288OeTYsoC5cZoundOFrIOyNrkFZIjto/9//swHilxGl+IkkBQgKAcHsYu/WL6jkLGEh0Fl2OWmYxNEDNcl+tuH2Jmnrk48819NWFdH5FrsYqVs6yGQ6fFf6AX5hwA7iM6PWWJSMtgqpggSqorBdUdNzQVSPxUUidI/0nI0M6ShnErletgHVr5G87ylkldunpkC4HCLLa9vzGvDL67UMBO43gbVqRZXqReTCQ70i2UIHD1mU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2017 09:50:00.5465 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 28759403-02ef-4ac9-9395-08d525c4e9ef X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2752 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA79oECF022264 Hi Viresh, Rafael, Without this patch, schedutil is totally broken for us - is there any chance at all this could go in 4.14 or is it just too late? Best Regards, Chris On 03/11/17 15:45, Viresh Kumar wrote: > On 03-11-17, 13:36, Chris Redpath wrote: >> After >> 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks") >> >> We stopped always reading utilization for the cpu we are running >> the governor on, and instead read it for the cpu which we've been >> told has updated utilization. This is stored in sugov_cpu->cpu. >> >> The value is set in sugov_register but we clear it in sugov_start >> which leads to always looking at the utilization of CPU0 instead >> of the correct one. >> >> Let's fix this by consolidating the initialization code into >> sugov_start(). >> >> Fixes: 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks") >> Signed-off-by: Chris Redpath >> Reviewed-by: Patrick Bellasi >> Reviewed-by: Brendan Jackman >> Cc: Rafael J. Wysocki >> Cc: Viresh Kumar >> Cc: Ingo Molnar >> Cc: Peter Zijlstra >> --- >> kernel/sched/cpufreq_schedutil.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) > > Acked-by: Viresh Kumar > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.