From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF723C433EF for ; Mon, 14 Feb 2022 17:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357038AbiBNRYQ (ORCPT ); Mon, 14 Feb 2022 12:24:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232948AbiBNRYO (ORCPT ); Mon, 14 Feb 2022 12:24:14 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43048652F1 for ; Mon, 14 Feb 2022 09:24:06 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJf51-0008Qe-HH; Mon, 14 Feb 2022 18:24:03 +0100 Message-ID: <65a7fdadc60d0c76138a8979a0c6fe1d6cdeb85d.camel@pengutronix.de> Subject: Re: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output From: Lucas Stach To: "Jonas Mark (BT-FIR/ENG1-Grb)" , Philipp Zabel , David Airlie , Daniel Vetter Cc: "RUAN Tingquan (BT-FIR/ENG1-Zhu)" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Date: Mon, 14 Feb 2022 18:24:01 +0100 In-Reply-To: References: <20220207151411.5009-1-mark.jonas@de.bosch.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, dem 14.02.2022 um 16:44 +0000 schrieb Jonas Mark (BT-FIR/ENG1-Grb): > Hi, > > > From: Leo Ruan > > > > This commit corrects the printing of the IPU clock error percentage if it is > > between -0.1% to -0.9%. For example, if the pixel clock requested is 27.2 > > MHz but only 27.0 MHz can be achieved the deviation is -0.8%. > > But the fixed point math had a flaw and calculated error of 0.2%. > > > > Before: > > Clocks: IPU 270000000Hz DI 24716667Hz Needed 27200000Hz > > IPU clock can give 27000000 with divider 10, error 0.2% > > Want 27200000Hz IPU 270000000Hz DI 24716667Hz using IPU, > > 27000000Hz > > > > After: > > Clocks: IPU 270000000Hz DI 24716667Hz Needed 27200000Hz > > IPU clock can give 27000000 with divider 10, error -0.8% > > Want 27200000Hz IPU 270000000Hz DI 24716667Hz using IPU, > > 27000000Hz > > > > Signed-off-by: Leo Ruan > > Signed-off-by: Mark Jonas > > --- > > drivers/gpu/ipu-v3/ipu-di.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c index > > b4a31d506fcc..74eca68891ad 100644 > > --- a/drivers/gpu/ipu-v3/ipu-di.c > > +++ b/drivers/gpu/ipu-v3/ipu-di.c > > @@ -451,8 +451,9 @@ static void ipu_di_config_clock(struct ipu_di *di, > > > > error = rate / (sig->mode.pixelclock / 1000); > > > > - dev_dbg(di->ipu->dev, " IPU clock can give %lu with divider > > %u, error %d.%u%%\n", > > - rate, div, (signed)(error - 1000) / 10, error % 10); > > + dev_dbg(di->ipu->dev, " IPU clock can give %lu with divider > > %u, error %c%d.%d%%\n", > > + rate, div, error < 1000 ? '-' : '+', > > + abs(error - 1000) / 10, abs(error - 1000) % 10); > > > > /* Allow a 1% error */ > > if (error < 1010 && error >= 990) { > > Is there anything I can do to help getting this patch mainline? Philipp is still on vacation, but will be back in a few days. I guess he will take a look at those patches then. Regards, Lucas