mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: MD Danish Anwar <danishanwar@ti.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Mengyuan Lou <mengyuanlou@net-swift.com>,
	Lei Wei <quic_leiwei@quicinc.com>, Xin Guo <guoxin09@huawei.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Fan Gong <gongfan1@huawei.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>,
	Lukas Bulwahn <lukas.bulwahn@redhat.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: <netdev@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next v4 0/7] Add RPMSG Ethernet Driver
Date: Wed, 17 Sep 2025 11:37:36 -0500	[thread overview]
Message-ID: <65a98655-68a1-4bf9-b139-c4172f48dad4@ti.com> (raw)
In-Reply-To: <7cd06f8f-bd74-429d-bf2c-71858178950a@ti.com>

On 9/17/25 6:44 AM, MD Danish Anwar wrote:
> Hi Andrew,
> 
> On 11/09/25 9:34 pm, Andrew Davis wrote:
>> On 9/11/25 6:36 AM, MD Danish Anwar wrote:
>>> This patch series introduces the RPMSG Ethernet driver, which provides a
>>> virtual Ethernet interface for communication between a host processor and
>>> a remote processor using the RPMSG framework. The driver enables
>>> Ethernet-like packet transmission and reception over shared memory,
>>> facilitating inter-core communication in systems with heterogeneous
>>> processors.
>>>
>>
>> This is neat and all but I have to ask: why? What does this provide
>> that couldn't be done with normal RPMSG messages? Or from a userspace
>> TAP/TUN driver on top of RPMSG?
>>
> 
> This is different from RPMSG because here I am not using RPMSG to do the
> actual TX / RX. RPMSG is only used to share information (tx / rx
> offsets, buffer size, etc) between driver and firmware. The TX / RX
> happens in the shared memory. This implementation uses a shared memory

This is how RPMSG is supposed to be used, it is meant for small messages
and signaling, bulk data should be send out-of-band. We have examples
specifically showing how this should be done when using RPMSG[0], and our
RPMSG backed frameworks do the same (like DSP audio[1] and OpenVX[2]).

> circular buffer with head/tail pointers for efficient data passing
> without copies between cores.
> 
>> This also feels like some odd layering, as RPMSG sits on virtio, and
>> we have virtio-net, couldn't we have a firmware just expose that (or
>> would the firmware be vhost-net..)?
>>
> 
> PMSG sits on virtio, and we do have virtio-net but I am not trying to do
> ethernet communication over RPMSG. RPMSG is only used to exchange
> information between cores regarding the shared memory where the actual
> ethernet communication happens.
> 

Again nothing new here, virtio-net does control plane work though a
message channel but the data plane is done using fast shared memory
vqueues with vhost-net[3]. Using RPMSG would just be an extra unneeded
middle layer and cause you to re-implement what is already done with
virtio-net/vhost-net.

Andrew

[0] https://git.ti.com/cgit/rpmsg/rpmsg_char_zerocopy
[1] https://github.com/TexasInstruments/rpmsg-dma
[2] https://github.com/TexasInstruments/tiovx
[3] https://www.redhat.com/en/blog/deep-dive-virtio-networking-and-vhost-net

>> Andrew
>>
> 
> 


  reply	other threads:[~2025-09-17 16:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 11:36 MD Danish Anwar
2025-09-11 11:36 ` [PATCH net-next v4 1/7] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver MD Danish Anwar
2025-09-11 11:36 ` [PATCH net-next v4 2/7] net: rpmsg-eth: Add basic rpmsg skeleton MD Danish Anwar
2025-09-11 11:36 ` [PATCH net-next v4 3/7] net: rpmsg-eth: Register device as netdev MD Danish Anwar
2025-09-11 11:36 ` [PATCH net-next v4 4/7] net: rpmsg-eth: Add netdev ops MD Danish Anwar
2025-09-11 11:36 ` [PATCH net-next v4 5/7] net: rpmsg-eth: Add support for multicast filtering MD Danish Anwar
2025-09-11 11:36 ` [PATCH net-next v4 6/7] MAINTAINERS: Add entry for RPMSG Ethernet driver MD Danish Anwar
2025-09-11 11:36 ` [PATCH net-next v4 7/7] arch: arm64: dts: k3-am64*: Add shared memory region MD Danish Anwar
2025-09-11 16:04 ` [PATCH net-next v4 0/7] Add RPMSG Ethernet Driver Andrew Davis
2025-09-17 11:44   ` MD Danish Anwar
2025-09-17 16:37     ` Andrew Davis [this message]
2025-09-22 10:59       ` MD Danish Anwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65a98655-68a1-4bf9-b139-c4172f48dad4@ti.com \
    --to=afd@ti.com \
    --cc=Parthiban.Veerasooran@microchip.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=danishanwar@ti.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=geert+renesas@glider.be \
    --cc=gongfan1@huawei.com \
    --cc=guoxin09@huawei.com \
    --cc=horms@kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=lukas.bulwahn@redhat.com \
    --cc=mengyuanlou@net-swift.com \
    --cc=mpe@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pabeni@redhat.com \
    --cc=quic_leiwei@quicinc.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®