From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbdK0JfQ (ORCPT ); Mon, 27 Nov 2017 04:35:16 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:42399 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbdK0JfO (ORCPT ); Mon, 27 Nov 2017 04:35:14 -0500 X-Google-Smtp-Source: AGs4zMY+0iNrEuQfr/8bY4qnTzAOONdfBt0FpA37cqDQZG7dE/LDCeKjh94DDrpBJ9aYit0kG+4Wug== Subject: Re: [PATCH] mmc: usdhi6rol0: Handle return value of platform_get_irq_byname for card detect To: Ulf Hansson References: <8fcf045dd4601511186b828d1911ba4659d8f923.1510936216.git.arvind.yadav.cs@gmail.com> Cc: Wolfram Sang , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" From: Arvind Yadav Message-ID: <65b32c21-bdba-3038-b37f-747663017c5c@gmail.com> Date: Mon, 27 Nov 2017 15:04:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday 27 November 2017 03:01 PM, Ulf Hansson wrote: > On 17 November 2017 at 17:35, Arvind Yadav wrote: >> platform_get_irq_byname() can fail here and we must check its return value. > NAK. > > You need to check the code more carefully. irq_cd is dealt with later > below in the same function with proper error handling. Yes, your are right. Sorry for noise. >> Signed-off-by: Arvind Yadav >> --- >> drivers/mmc/host/usdhi6rol0.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c >> index cdfeb15..5a896de 100644 >> --- a/drivers/mmc/host/usdhi6rol0.c >> +++ b/drivers/mmc/host/usdhi6rol0.c >> @@ -1749,7 +1749,7 @@ static int usdhi6_probe(struct platform_device *pdev) >> irq_cd = platform_get_irq_byname(pdev, "card detect"); >> irq_sd = platform_get_irq_byname(pdev, "data"); >> irq_sdio = platform_get_irq_byname(pdev, "SDIO"); >> - if (irq_sd < 0 || irq_sdio < 0) >> + if (irq_cd < 0 || irq_sd < 0 || irq_sdio < 0) >> return -ENODEV; >> >> mmc = mmc_alloc_host(sizeof(struct usdhi6_host), dev); >> -- >> 2.7.4 >> ~arvind