From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49209.qiye.163.com (mail-m49209.qiye.163.com [45.254.49.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93BB8178372 for ; Mon, 14 Apr 2025 01:52:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.209 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744595530; cv=none; b=QBaZa3ygXjGUuCG8Bbe6wsjeX8E1gFKgr2CJZwsIAl+RvlnIFJ3xA5x+82Sb74DQjYOeHSgWngNIIenxw0HrcbHX2pD8bQNWxCoBi77Qm8lOKMhXg8uuweZ7Sd9YPz4cSfDXkoP1qgvttUcVuQqPxde89jO0eeLSBR17dVil6FM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744595530; c=relaxed/simple; bh=fBLTP093vuIiAC7yiioro40haF2CXcMH9lftbu3sCWg=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=AKCOb1u/1YGDFo/mmxurTQWxd4FeNEA7e1g4C8BK3o3/h8Vs27X3e3bYLriNGRRiJw+p3upt2Dpisc0wEzbhksU6JsZTRnOYf5rSQ6nxSIDqDmTokZM4mgZuYyfk8WIi5vdWjO9nG8MhTupQ2H6T6tLE8Z8V6kGY58z97BRhClI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=aWGYzSyl; arc=none smtp.client-ip=45.254.49.209 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="aWGYzSyl" Received: from [172.16.12.26] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 11bad66ba; Mon, 14 Apr 2025 09:46:49 +0800 (GMT+08:00) Message-ID: <65b5da62-3994-42e0-916c-4a8505fa3844@rock-chips.com> Date: Mon, 14 Apr 2025 09:46:49 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] drm/bridge: analogic_dp: drop panel_is_modeset To: Dmitry Baryshkov References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> <20250401-panel-return-void-v1-3-93e1be33dc8d@oss.qualcomm.com> Content-Language: en-US Cc: Laurent.pinchart@ideasonboard.com, airlied@gmail.com, andrzej.hajda@intel.com, dri-devel@lists.freedesktop.org, jernej.skrabec@gmail.com, jonas@kwiboo.se, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, rfoss@kernel.org, simona@ffwll.ch, tzimmermann@suse.de From: Damon Ding In-Reply-To: <20250401-panel-return-void-v1-3-93e1be33dc8d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQk8aQ1ZLGh0YT0oaTRlOSU9WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ X-HM-Tid: 0a9631fa4e5d03a3kunm11bad66ba X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6ODo6HSo*PDIDPC4eHx5PKjoz SBBPCRRVSlVKTE9PTkJOSUpKT0lOVTMWGhIXVR8aFhQVVR8SFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFITUNLNwY+ DKIM-Signature:a=rsa-sha256; b=aWGYzSylNmiXIDwCVvLnCAHkwVkH+FU/Po9CcypUW8aTsrHMC3rkXTEcXBG3rsC6VTLUs0kcRSGiRad3itQq2Z1wKUbpFJztxXAvFkstah8OhiI0iQyJMU8SmRH+VtmJGM72/tY4NRXsUX4hzikzu2EeAGWe5myDv2V8gItVo8k=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=Ig4iftYOsYlJff/8wBUz9XCqK3qD58dlsifH7hNudHw=; h=date:mime-version:subject:message-id:from; Hi Dmitry, On 2025/4/1 13:11, Dmitry Baryshkov wrote: > The dp->panel_is_modeset is now a write-only field. Drop it completely. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +---------- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 1 - > 2 files changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 82dc4b01806f9728dc882b0128171838e81f21b0..704c6169116eb2601d2ad02dc7294455ceff5460 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -964,9 +964,7 @@ static int analogix_dp_disable_psr(struct analogix_dp_device *dp) > * is false, the panel will be unprepared. > * > * The function will disregard the current state > - * of the panel and either prepare/unprepare the panel based on @prepare. Once > - * it finishes, it will update dp->panel_is_modeset to reflect the current state > - * of the panel. > + * of the panel and either prepare/unprepare the panel based on @prepare. > */ > static int analogix_dp_prepare_panel(struct analogix_dp_device *dp, > bool prepare) > @@ -983,12 +981,6 @@ static int analogix_dp_prepare_panel(struct analogix_dp_device *dp, > else > ret = drm_panel_unprepare(dp->plat_data->panel); > > - if (ret) > - goto out; > - > - dp->panel_is_modeset = prepare; > - > -out: > mutex_unlock(&dp->panel_lock); > return ret; > } > @@ -1532,7 +1524,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) > dp->dpms_mode = DRM_MODE_DPMS_OFF; > > mutex_init(&dp->panel_lock); > - dp->panel_is_modeset = false; > > /* > * platform dp driver need containor_of the plat_data to get > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > index 774d11574b095b093ddf2818ad5b84be6605c9bf..b679d5b71d276f458d905c936160f107225bc6c5 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > @@ -170,7 +170,6 @@ struct analogix_dp_device { > bool psr_supported; > > struct mutex panel_lock; > - bool panel_is_modeset; > > struct analogix_dp_plat_data *plat_data; > }; > The patch has been verified with the eDP panel "lg,lp079qx1-sp0v" in RK3588S EVB1 board. Tested-by: Damon Ding Best regards, Damon