From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F77CDB482 for ; Thu, 12 Oct 2023 15:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379211AbjJLPDC (ORCPT ); Thu, 12 Oct 2023 11:03:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378304AbjJLPC7 (ORCPT ); Thu, 12 Oct 2023 11:02:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14DCCC4 for ; Thu, 12 Oct 2023 08:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697122926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NqKWWi4N1dQcUV0pCxNw2tgDBfyOJnn+/IdI3vL5BCQ=; b=bwXGB9X6Mdxjg1G/razCMVObyfS53Is97BntuZFxn1/staY5xd+Ryo/QPgQBlurJkXYGso iQYf741ycaJxJHxGbTOKe1sS1c2p7BKyJyESveMIVZhjIpEoJDtcD95C+BlXtqoAbS6hai j5OfCdvbUWsporrKk3iVclCEwq+wfzs= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-3SPO1wYlMI-bY1Cpdf3irQ-1; Thu, 12 Oct 2023 11:02:04 -0400 X-MC-Unique: 3SPO1wYlMI-bY1Cpdf3irQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-668f04867deso11813686d6.2 for ; Thu, 12 Oct 2023 08:02:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697122923; x=1697727723; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NqKWWi4N1dQcUV0pCxNw2tgDBfyOJnn+/IdI3vL5BCQ=; b=YlD0ZaEs4hHqFOKIU/MvFfOe+hRc112l3w+qiEUFKypEY1LfUa2wcujmWV0hhfpMsw tAlB+vpVhe0Ix362m58GKCTG73E7fOc6jV2AS5FJgQYC7KQGC4tyOfz1cysksq0P8Oez IMhND3Uzj+wk27sVK7Q1LxxiUMJFA1q2tjmRLB4ZxdxU+tA6rWqKLeD238chwShnoSLS IiDifimlPvPh5s+Sqy8VlkP4u9Efv/icXeNL9piQl7qcnJ85CrfTeCB0uXcqSMWv1zYw aRVfLHACMY60etv16pQ30qzZ2OTXd5rN+itZADCc2lLeFinNV94N3AsmavjG4J4c1ddQ HRRg== X-Gm-Message-State: AOJu0Yz4lRnoWdDHabuXYdsJf3heTDrF4AVPlUDCduEcfSIz3SFllwx+ 7sXzYP+0Lro65EQZwYdKmTUaPCscgUdK7O4qc8CVb1QMfhqwj+CjT2xFF8GF406J2yllQBdrXbT rzBUUN0AxOMELNNW94qPI7S/v X-Received: by 2002:a05:6214:5b03:b0:65d:1265:48c5 with SMTP id ma3-20020a0562145b0300b0065d126548c5mr25316472qvb.33.1697122923730; Thu, 12 Oct 2023 08:02:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjRHnSSwx/haWRgrBki1YsFkWJjXmdjCoMi0wMoPVGd/LNcVTz7v5WLv1JGQct9yRT+ZM1Mw== X-Received: by 2002:a05:6214:5b03:b0:65d:1265:48c5 with SMTP id ma3-20020a0562145b0300b0065d126548c5mr25316134qvb.33.1697122919236; Thu, 12 Oct 2023 08:01:59 -0700 (PDT) Received: from rh (p200300c93f266600211746b64b43cdf8.dip0.t-ipconnect.de. [2003:c9:3f26:6600:2117:46b6:4b43:cdf8]) by smtp.gmail.com with ESMTPSA id o15-20020a0cfa8f000000b0066cfbe4e0f4sm2140112qvn.26.2023.10.12.08.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 08:01:58 -0700 (PDT) Date: Thu, 12 Oct 2023 17:01:54 +0200 (CEST) From: Sebastian Ott To: Raghavendra Rao Ananta cc: Oliver Upton , Marc Zyngier , Alexandru Elisei , James Morse , Suzuki K Poulose , Paolo Bonzini , Zenghui Yu , Shaoqin Huang , Jing Zhang , Reiji Watanabe , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v7 10/12] KVM: selftests: aarch64: Introduce vpmu_counter_access test In-Reply-To: <44608d30-c97a-c725-e8b2-0c5a81440869@redhat.com> Message-ID: <65b8bbdb-2187-3c85-0e5d-24befcf01333@redhat.com> References: <20231009230858.3444834-1-rananta@google.com> <20231009230858.3444834-11-rananta@google.com> <44608d30-c97a-c725-e8b2-0c5a81440869@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463795790-346822177-1697122918=:6347" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463795790-346822177-1697122918=:6347 Content-Type: text/plain; charset=ISO-8859-7; format=flowed Content-Transfer-Encoding: 8BIT On Thu, 12 Oct 2023, Sebastian Ott wrote: > On Mon, 9 Oct 2023, Raghavendra Rao Ananta wrote: >> +/* Create a VM that has one vCPU with PMUv3 configured. */ >> +static void create_vpmu_vm(void *guest_code) >> +{ >> + struct kvm_vcpu_init init; >> + uint8_t pmuver, ec; >> + uint64_t dfr0, irq = 23; >> + struct kvm_device_attr irq_attr = { >> + .group = KVM_ARM_VCPU_PMU_V3_CTRL, >> + .attr = KVM_ARM_VCPU_PMU_V3_IRQ, >> + .addr = (uint64_t)&irq, >> + }; >> + struct kvm_device_attr init_attr = { >> + .group = KVM_ARM_VCPU_PMU_V3_CTRL, >> + .attr = KVM_ARM_VCPU_PMU_V3_INIT, >> + }; >> + >> + /* The test creates the vpmu_vm multiple times. Ensure a clean state >> */ >> + memset(&vpmu_vm, 0, sizeof(vpmu_vm)); >> + >> + vpmu_vm.vm = vm_create(1); >> + vm_init_descriptor_tables(vpmu_vm.vm); >> + for (ec = 0; ec < ESR_EC_NUM; ec++) { >> + vm_install_sync_handler(vpmu_vm.vm, VECTOR_SYNC_CURRENT, ec, >> + guest_sync_handler); >> + } >> + >> + /* Create vCPU with PMUv3 */ >> + vm_ioctl(vpmu_vm.vm, KVM_ARM_PREFERRED_TARGET, &init); >> + init.features[0] |= (1 << KVM_ARM_VCPU_PMU_V3); >> + vpmu_vm.vcpu = aarch64_vcpu_add(vpmu_vm.vm, 0, &init, guest_code); >> + vcpu_init_descriptor_tables(vpmu_vm.vcpu); >> + vpmu_vm.gic_fd = vgic_v3_setup(vpmu_vm.vm, 1, 64, >> + GICD_BASE_GPA, GICR_BASE_GPA); >> + >> + /* Make sure that PMUv3 support is indicated in the ID register */ >> + vcpu_get_reg(vpmu_vm.vcpu, >> + KVM_ARM64_SYS_REG(SYS_ID_AA64DFR0_EL1), &dfr0); >> + pmuver = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64DFR0_PMUVER), dfr0); >> + TEST_ASSERT(pmuver != ID_AA64DFR0_PMUVER_IMP_DEF && >> + pmuver >= ID_AA64DFR0_PMUVER_8_0, >> + "Unexpected PMUVER (0x%x) on the vCPU with PMUv3", >> pmuver); >> + >> + /* Initialize vPMU */ >> + vcpu_ioctl(vpmu_vm.vcpu, KVM_SET_DEVICE_ATTR, &irq_attr); >> + vcpu_ioctl(vpmu_vm.vcpu, KVM_SET_DEVICE_ATTR, &init_attr); >> +} > > This one fails to build for me: > aarch64/vpmu_counter_access.c: In function ¡create_vpmu_vm¢: > aarch64/vpmu_counter_access.c:456:47: error: ¡ID_AA64DFR0_PMUVER_MASK¢ > undeclared (first use in this function); did you mean > ¡ID_AA64DFR0_EL1_PMUVer_MASK¢? > 456 | pmuver = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64DFR0_PMUVER), > dfr0); Looks like there's a clash with "KVM: arm64: selftests: Import automatic generation of sysreg defs" from: https://lore.kernel.org/r/20231003230408.3405722-12-oliver.upton@linux.dev ---1463795790-346822177-1697122918=:6347--