mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>,
	linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	Jiri Kosina <jikos@kernel.org>
Subject: Re: [v2] HID: corsair-void: Add Corsair Void headset family driver
Date: Tue, 20 Aug 2024 07:56:04 +0200	[thread overview]
Message-ID: <65b8f7e4-358f-4943-8ce0-c28e4c947016@web.de> (raw)
In-Reply-To: <CALTg27mgOx3W3WENxFh0sEEeNYKEjrZCEQGoBi9=vjgiaZnZtQ@mail.gmail.com>

>> * Would you like to reduce scopes for such local variables?
>
> I thought the kernel programming style put the local variables at the
> start of the function?

This was the case for a while.

Increasing applications of scope-based resource management provide
further opportunities for smaller scopes according to some local variables,
don't they?


>> Can such a size determination be explained better?
>
> Well it allocates 3 bytes and immediately fills them, so I'm not sure
> what I'd write except stating the obvious.
> Unless you mean why it has to be allocated rather than just using the stack?

How do you think about to collaborate with other data structures
than character arrays?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11-rc4#n953


Regards,
Markus

  reply	other threads:[~2024-08-20  5:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-18 23:19 [PATCH v2] " Stuart Hayhurst
2024-08-19  7:48 ` Markus Elfring
2024-08-20  0:21   ` Stuart
2024-08-20  5:56     ` Markus Elfring [this message]
2024-08-21  0:52       ` [v2] " Stuart
2024-08-21  7:26         ` Markus Elfring
2024-08-21  9:52           ` Christophe JAILLET
2024-08-22  1:11             ` Stuart
2024-08-22  6:15               ` Christophe JAILLET
2024-08-22 11:57               ` Jiri Kosina
2024-08-22 15:36                 ` Stuart
2024-08-23  8:45         ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65b8f7e4-358f-4943-8ce0-c28e4c947016@web.de \
    --to=markus.elfring@web.de \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stuart.a.hayhurst@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®