From: Peter Oberparleiter <oberpar@linux.ibm.com>
To: Tri Vo <trong@android.com>
Cc: ghackmann@android.com, ndesaulniers@google.com,
linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v2 0/4] gcov: add Clang support
Date: Wed, 16 Jan 2019 16:17:35 +0100 [thread overview]
Message-ID: <65bb2ab8-4929-db7c-9d54-491d87ec23ae@linux.ibm.com> (raw)
In-Reply-To: <20190115183643.120619-1-trong@google.com>
On 15.01.2019 19:36, Tri Vo wrote:
> From: Tri Vo <trong@android.com>
>
> This patch series adds Clang supoprt for gcov.
>
> Patch 1 refactors existing code in preparation for Clang support. Patches
> 2-3 implement necessary LLVM runtime hooks and gcov kernel interfaces.
> Patch 4 simplifies config selection.
>
> Greg Hackmann (2):
> gcov: clang: move common gcc code into gcc_base.c
> gcov: clang support
>
> Nick Desaulniers (1):
> gcov: clang: link/unlink profiling data set.
>
> Tri Vo (1):
> gcov: clang: pick GCC vs Clang format depending on compiler
Overall this patch set looks good to me. It introduces a clean way for
GCC and Clang specific implementation details to coexist.
A quick test compile using GCC on s390 with the patch set applied was
successful, so it seems like the existing support is unaffected.
There are some detail suggestions on patch improvements that I'll post
in separate e-mails.
--
Peter Oberparleiter
Linux on Z Development - IBM Germany
next prev parent reply other threads:[~2019-01-16 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 18:36 Tri Vo
2019-01-15 18:36 ` [PATCH v2 1/4] gcov: clang: move common gcc code into gcc_base.c Tri Vo
2019-01-15 18:36 ` [PATCH v2 2/4] gcov: clang support Tri Vo
2019-01-15 18:36 ` [PATCH v2 3/4] gcov: clang: link/unlink profiling data set Tri Vo
2019-01-15 18:36 ` [PATCH v2 4/4] gcov: clang: pick GCC vs Clang format depending on compiler Tri Vo
2019-01-15 19:25 ` Nick Desaulniers
2019-01-16 10:18 ` Masahiro Yamada
2019-01-17 21:48 ` Nick Desaulniers
2019-01-16 15:17 ` Peter Oberparleiter [this message]
2019-01-17 21:30 ` [PATCH v2 0/4] gcov: add Clang support Nick Desaulniers
2019-01-17 22:01 ` Tri Vo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65bb2ab8-4929-db7c-9d54-491d87ec23ae@linux.ibm.com \
--to=oberpar@linux.ibm.com \
--cc=ghackmann@android.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=trong@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome