From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD341209686 for ; Mon, 3 Feb 2025 15:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.17.235.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738597806; cv=none; b=QNx0xzkA2znhtCvyO/fyORp8SEizNSDjOoY8Xgwn93fcOdAICm/PotcE+buZV2gygylcYspNlKeCy03DlEof5Du2Jk2JV0gB/pXUtNKnmJpOWBH0IsLSdSwu7eDNIhoUUg2EztE7xLk9QV/hJzbATDdTtg+A/HSi9X3rmW6SEoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738597806; c=relaxed/simple; bh=HYnhoMCdU+H5ksYaoTm0uU6K8WbCMMiHu9aeLOihI5c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RSZxyJlZNHmJJuWPflnlXwJbalJ/8k5TXEsF8Z3m/mJRCbMddUgK9kezsj9+zrugDZwsQYONETTgx3dIX2I1ZLeim+STlH/s3Bbne3mljseUviVt5/yP96L0RQQKvCBCQfhZhHJtllveIj0Y/Ed7NkNVLZSr3TX8R7wt8n4eHq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu; spf=pass smtp.mailfrom=csgroup.eu; arc=none smtp.client-ip=93.17.235.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4YmqtK1JZpz9sbH; Mon, 3 Feb 2025 16:19:53 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QTVaJFM0J-7X; Mon, 3 Feb 2025 16:19:53 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4YmqsS6kTlz9sYM; Mon, 3 Feb 2025 16:19:08 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D6C4F8B764; Mon, 3 Feb 2025 16:19:08 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id XPURUaR18hxz; Mon, 3 Feb 2025 16:19:08 +0100 (CET) Received: from [192.168.202.221] (unknown [192.168.202.221]) by messagerie.si.c-s.fr (Postfix) with ESMTP id CFD938B763; Mon, 3 Feb 2025 16:19:06 +0100 (CET) Message-ID: <65c6f60d-bb52-48bd-a02c-87ffd2a915d4@csgroup.eu> Date: Mon, 3 Feb 2025 16:19:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] powerpc: Use preempt_model_str(). To: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Cc: Ben Segall , Catalin Marinas , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Mel Gorman , Peter Zijlstra , Shrikanth Hegde , Steven Rostedt , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , linuxppc-dev@lists.ozlabs.org References: <20250203141632.440554-1-bigeasy@linutronix.de> <20250203141632.440554-6-bigeasy@linutronix.de> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20250203141632.440554-6-bigeasy@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 03/02/2025 à 15:16, Sebastian Andrzej Siewior a écrit : > Use preempt_model_str() instead of manually conducting the preemption > model. Use pr_emerg() instead of printk() to pass a loglevel. Why use pr_emerg() for that line and not all other ones ? The purpose of using printk() is to get it at the level defined by CONFIG_MESSAGE_LOGLEVEL_DEFAULT and I think it is important to have the full Oops block at the same level. > > Cc: Madhavan Srinivasan > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: Naveen N Rao > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/powerpc/kernel/traps.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c > index edf5cabe5dfdb..9eb383189cfb2 100644 > --- a/arch/powerpc/kernel/traps.c > +++ b/arch/powerpc/kernel/traps.c > @@ -263,10 +263,10 @@ static int __die(const char *str, struct pt_regs *regs, long err) > { > printk("Oops: %s, sig: %ld [#%d]\n", str, err, ++die_counter); > > - printk("%s PAGE_SIZE=%luK%s%s%s%s%s%s %s\n", > + pr_emerg("%s PAGE_SIZE=%luK%s %s %s%s%s%s %s\n", > IS_ENABLED(CONFIG_CPU_LITTLE_ENDIAN) ? "LE" : "BE", > PAGE_SIZE / 1024, get_mmu_str(), > - IS_ENABLED(CONFIG_PREEMPT) ? " PREEMPT" : "", > + preempt_model_str(), > IS_ENABLED(CONFIG_SMP) ? " SMP" : "", > IS_ENABLED(CONFIG_SMP) ? (" NR_CPUS=" __stringify(NR_CPUS)) : "", > debug_pagealloc_enabled() ? " DEBUG_PAGEALLOC" : "",