From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8839A27587C for ; Mon, 6 Oct 2025 10:50:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759747802; cv=none; b=lVPlnv0nUvtjbE6L0r8tnC055UFPMYbImgON/sYwIhRZjnxfURqTmFAsGy3gm6Y/xwmXFYG0NMoF3+QD7Macj88LkPFKZMT9BIz6v0ixPqb/ClrJ3tva9rj448mzp7JvWwRxFJQWgR/c8TzegqNm/3ug/uImEHkSqC8MdhFoa5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759747802; c=relaxed/simple; bh=nmQN2Ai0HjcSSzO0mxJrOtxVVNPLmWCIRBsAC/F8dB4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ClQrpv2lmc25uBpFXiYBSJjUgVH0Ih3Yw8GNNKx4m8yYj5ZwGQ7FwmqfKGrufZcoJaAieKYDlNXJE/MfBX5xcOnTyQpAFL4PJ/tSYLOQ1YVg6UnndNisoAAB08ZuCQDpARy7W1Aav8oYdwRfXsPyuakyb58nec35M5fKNGuNq0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WUcwFQ9S; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WUcwFQ9S" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 595MkKFw018960 for ; Mon, 6 Oct 2025 10:49:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IN3CVmizwhnegBcGc3ulurAszyJXyt4uRPeWQ6uV/vI=; b=WUcwFQ9SMmiTZbx2 NCNeZ1nWtZj9SZeY0FBSxzXMH2IzPbeI3uKZPRyDG5mIBhrMbs10/bHJuffXN1S6 48ULwM2+mereT1CMxjpteWfk2W6DE7SpPaMQsKBSaw72XyizRA1Vb59NKoU3BYF2 kN/HEYqbQueAvdOe+N8mgH21IY8fPnz6c8f/WGVRE8w18TQTDEZPzYlp5pOUh0lf zq+LbL8Whz/R/nlEOxyrky6T8KZI+AHAWTJxHzZr4qHilz/JFh5CmyACSz8HviOr Spq4Ys3qsT8/OfP0FULlcV0FUoOP+wws6TueECzH/vCxhsEMrC864LP8WoN/bm5A MH9+MA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49jvv7keu1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 06 Oct 2025 10:49:59 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-819d2492a75so226017085a.1 for ; Mon, 06 Oct 2025 03:49:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759747798; x=1760352598; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IN3CVmizwhnegBcGc3ulurAszyJXyt4uRPeWQ6uV/vI=; b=cPM12ZLdUJC2yOkwVLykPRF43QunwoA5rXqYc2UbPpyPptzhjqdmxuX43/3LgQoCOD H14lsA1vHyLnOtceYkErip5A59223EIBWi+J0zGMLBIEZzx6Wp+kVIj9AtPUoqJVGRcz zNU5otgWRcg8jFbJxc3R+M9BUsppQHYDTl21NFNWT9jzsbQEyKybB9oJnlSrkFGB8OA7 N37yb+qKeXxbioBhKBpw0VGOvEGU7ccXGmivcapEKEBSnS3TL5XG18kItenOUv9tjw5E Ng5MR5zIZ5Efob8aP0avopKgx8HOggzBjO6erFIxcOeZCcnxzE8WuEE8M3CmmTat5q1b +5CQ== X-Forwarded-Encrypted: i=1; AJvYcCWCyWtQHmHq4cSF9TiSS7OJBtp1rdTY7irTwNe/bV2h/yp5usMD1i0adgTVFEPxI05UCdsUhzNSP3tzGDo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1PBHZPeGVetTD1cm41G5DAO/BaYORLk7kRe+PNdZzUFqLS4T3 nBuPdP1ZmBj7MCKMMoB5kQj+FNKGyzRBFRi474eZutRWtHzSnWggOLx79Vrwr6pGBJ6fTSvEbKU iLNq6/s/KmiDEq7HRQVWtX8Q2JBT8bHh91ECKaPCaI0Kjn/rspx7sbt/edFLmXxnZWn8= X-Gm-Gg: ASbGncvUSPoptlq2LXP3tAAYY9cjoRRwGU6ZpqmmMUJ4uZAyv6CdgziWvU7djdEHKnt YiNTSkCVrXf9YkPYvVXKIpmGtxnELHOmPN3YMQSmWEyDycbTfSK6bmX2kNKhHS8kpso0xjNIoH/ cVGwcOhRd6XhJQq8Gv8JSi9D1516U5ZpJnfu5GgvJtChefMF38Fe6MSFfCQPS/rFCUzKaFaCuID XC0N/gt5DxvHkdx2VOxAqjASV53Xj1tfBjkB7cV7Ck5jea23FNypOeg+OOnBDWnlyS5FgmTMv96 yVVjX4AqGGDYi3/wcfNvFhC4nd9r2/UaH33ZMfwi/9nZoi++2YCex8Om/COHH58fyqsIKjux8ci fBoHCECEq8ZvucLfdXqPNPGkt6tI= X-Received: by 2002:a05:622a:60f:b0:4dc:fc58:c50c with SMTP id d75a77b69052e-4e576a45606mr94443211cf.5.1759747798203; Mon, 06 Oct 2025 03:49:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSEU8VjnAr3dc4CRE1tKa0vgiLD4zAxaPVFZcAL5lIiyFY/V+S9ZVpzOWmv+pNPBnQHAcwzQ== X-Received: by 2002:a05:622a:60f:b0:4dc:fc58:c50c with SMTP id d75a77b69052e-4e576a45606mr94443021cf.5.1759747797738; Mon, 06 Oct 2025 03:49:57 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b4865f741f1sm1118572366b.39.2025.10.06.03.49.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 03:49:57 -0700 (PDT) Message-ID: <65d0012c-4c06-4b39-9375-89d635f8abeb@oss.qualcomm.com> Date: Mon, 6 Oct 2025 12:49:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] drm/panel: Add Novatek NT36532 panel driver To: Dmitry Baryshkov Cc: Junjie Cao , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Antonino Maniscalco , Jonathan Marek , Eugene Lepshy , Jun Nie , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20251001135914.13754-1-caojunjie650@gmail.com> <20251001135914.13754-4-caojunjie650@gmail.com> <53aafa84-6d6a-4963-827e-c1600270662f@oss.qualcomm.com> <2do3dk7gqvbloocsv46t3zrc4ghvhrpiqre6djk6heese3wz75@dlqwkdsnrkbr> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2do3dk7gqvbloocsv46t3zrc4ghvhrpiqre6djk6heese3wz75@dlqwkdsnrkbr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA0MDAzNyBTYWx0ZWRfX5hSUYl5Yjy3Z rfLrAYxtXzZQHnf/9MY1NiF9SKbdCoMmjfFdCakPQkYyJkQvHoVTNvkBcIif89aUHxhl5zgnQMo 4iyVHx56sDK+0sh/AkF+EdcqQdPo6v2K9w0S/N6b/LFvkNhpEzS7d3qvD3p+5OixupnyiyjqRqk f5frvu4lmZn13Z+2rSFGJvgABQPkpBXZrpUYny0H6/0LsdQRA6Yd6uGcYlhES8uT8ED5GiI/VeU HqYcpbzxr8dImXKKE7r5V764QVj75+o/4S0eRMMH1+0JGYINWIY6j0lebgn1UDe1kocVZHrvynF 7goySIeTKTzPcoQb+E4OKe/IJ3Gmd7bapH+94M9Y85Dzk0rT9Ebe+0USddctpUnDvqy47g6S6YD pZb4C8i+ZHtdcnlqhJqN+Y7vSjt65g== X-Proofpoint-ORIG-GUID: pUnuuO5lJpwybvW78cXMMy9y2p4kedXy X-Authority-Analysis: v=2.4 cv=WIdyn3sR c=1 sm=1 tr=0 ts=68e39ed7 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=pGLkceISAAAA:8 a=zTkMZ0gcjxiqpFU4bxAA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: pUnuuO5lJpwybvW78cXMMy9y2p4kedXy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-06_03,2025-10-02_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510040037 On 10/6/25 12:39 PM, Dmitry Baryshkov wrote: > On Mon, Oct 06, 2025 at 12:10:05PM +0200, Konrad Dybcio wrote: >> On 10/6/25 12:02 PM, Dmitry Baryshkov wrote: >>> On Mon, Oct 06, 2025 at 11:24:35AM +0200, Konrad Dybcio wrote: >>>> On 10/2/25 4:04 AM, Dmitry Baryshkov wrote: >>>>> On Wed, Oct 01, 2025 at 09:59:14PM +0800, Junjie Cao wrote: >>>>>> Add a driver for panels using the Novatek NT36532 Display Driver IC, >>>>>> including support for the CSOT PPC100HB1-1, found in the OnePlus Pad 2 >>>>>> tablets. >>>>>> >>>>>> Signed-off-by: Junjie Cao >>>>>> --- >>>>>> MAINTAINERS | 7 + >>>>>> drivers/gpu/drm/panel/Kconfig | 10 + >>>>>> drivers/gpu/drm/panel/Makefile | 1 + >>>>>> drivers/gpu/drm/panel/panel-novatek-nt36532.c | 437 ++++++++++++++++++ >>>>>> 4 files changed, 455 insertions(+) >>>>>> create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36532.c >>>>>> >>>>>> + >>>>>> +static const struct panel_info csot_panel_info = { >>>>>> + .width_mm = 250, >>>>>> + .height_mm = 177, >>>>>> + .lanes = 4, >>>>>> + .format = MIPI_DSI_FMT_RGB888, >>>>>> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_CLOCK_NON_CONTINUOUS | >>>>>> + MIPI_DSI_MODE_LPM, >>>>>> + .display_mode = csot_display_mode, >>>>>> + .dsc_slice_per_pkt = 2, >>>>> >>>>> As this is not a part of the standard, what if the DSI host doesn't >>>>> support this feature? >>>> >>>> Shouldn't the core gracefully throw something like an -EINVAL? >>> >>> There is no 'core' here. Each DSI DRM host manages DSC on their own. >> >> drm_dsc_helper? > > No, that's just for calculating PPS and some other values. It's one of > the problems of the DSI model, which I tried to solve a year ago, but > failed up to now to do it completely and clearly. The DSI device can't > check host's capabilities. It declares what it needs inside struct > mipi_dsi_device and hopes for the best. Alright, thanks for the explanation Konrad