From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79575182DF for ; Thu, 22 Aug 2024 16:09:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724342979; cv=none; b=SMvSuewXKJ+ZZfaT8EBRuV1ZxzRDRTuq0G93bDmsTOB47vod0o6QQZGdBt0ZZFQ86GKliPAPbZsRp76yMQ+fGsBw5caKcLiTQkkLaiS6XPNUnLLxq3Y6cj8j+NkpE5K6T1nZoADzH+ckdPbruMI2kDEZKgge+ordZ1b+tf+TFDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724342979; c=relaxed/simple; bh=N1zMZ+hXVfz11gY2kkBw6IRe1yiWuDqeJ3l7e5bM8Vs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nDJiprewGxxQDYIYqlvPPwdO+IcKmVe+CH9aEf+jOv3vHZW+YXURfTyhaAGNVhNGVgym6UE7p0LusyFe2DZ7n/WGefIQkNTu+wG+hpqrccwVfbhYMT99X2mx9kPoHyPHXSfu4auc/49EtOkEXxiAui1tmGT8FQi+fpwq+j5UFaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ub03fLtv; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ub03fLtv" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-37182eee02dso562109f8f.1 for ; Thu, 22 Aug 2024 09:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724342976; x=1724947776; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YVHwgiGRwBVRiA1k1Gg1ltpgqyX9aL/hfU0tA2E2xBs=; b=Ub03fLtvJPJBUCdiCNr+J76L0yFG82k/Tz0UTY1aE5DvJMhWxd9vhyON/CoYLGAezG vOOAldCbqa4Z8sTVmHlJNYDB5NJbcCpVBfZvmgmO7xUGiLwAhY5iv63v1iiLsq1GtySM +93OyZ25s1mngsE7TpUbm2AWIi41UO9lZIRzQnbXdR3lzneIeLN4qd1ArGoClh21x9gz dsNp8BLO4NMW5EXoVHlu7sB9SFTttjcD3ED6Veikr6ChVwIMi8GQQd6fS7VTI1PoiFa5 ER1pSCBCam2OFI5viLJhGIS++wETBVficE5kw8wspH71ifPjdOakUCMSwprgD9P37Kg5 5Qqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724342976; x=1724947776; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YVHwgiGRwBVRiA1k1Gg1ltpgqyX9aL/hfU0tA2E2xBs=; b=M9XF2E6GMkJDLGgFyqjfSiopyFXHzAf7DW6WfOY5JhNXodtkbe8SJ+DgfGLRBPEedI TsIEOfMA9aSfaz3zbBi3dFy5wezwVA80BKOny2s3VlcAzW7eAh9k+feeUVvyji+CaAuL Ks+h8FErKsFPUj5Yk1GAii2vK30luBprJcb18cd8yk5NhwYUw3caZOGxC/ynH86addLk EfIlXUSiSpKW5oYzR/2UIc8CSFqHohxK3qPqtWRR2MZlStPHYpLQnXlKVWG9h5wJdmuy 2f46ytXiHHCknYtdRqIu3Z+Yqfb5Wr/+6q3fGJiSK6Xjsq0yGnw2bgyBSaKzNIY0IvBG uAjQ== X-Forwarded-Encrypted: i=1; AJvYcCU+9tyZyhpp1qltS0J4+M6yXbwVRPXanqSkMNCOUndDTracfxNO7pjmMWTvGubs5W8E5pUTHDNXLj27AGE=@vger.kernel.org X-Gm-Message-State: AOJu0YwWcGfhGAg7orj+RG4vvpdGVcNl6IwpTcYJgHbR4MN7fc3ieKI2 nrZS07LBzmKOcJV9lZoFiyv8sv5IwC7t03H31n72lwYXmwAcCKYUP8iIA8aQdZM= X-Google-Smtp-Source: AGHT+IF1xtLjO7HbauT10nJjxAFzvO6sbfbstsDOKVLiY/kd6TeqGRF7IYYKtPte/9nFo8s5ewLDcA== X-Received: by 2002:a5d:6e8b:0:b0:36b:5d86:d885 with SMTP id ffacd0b85a97d-373052b51a8mr2118977f8f.24.1724342975461; Thu, 22 Aug 2024 09:09:35 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-42abee86df3sm65738805e9.14.2024.08.22.09.09.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 09:09:35 -0700 (PDT) Message-ID: <65d60efb-9512-45a9-9303-4354eec21bd4@linaro.org> Date: Thu, 22 Aug 2024 18:09:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] thermal: of: Fix OF node leak in thermal_of_trips_init() error path To: Krzysztof Kozlowski , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20240814195823.437597-1-krzysztof.kozlowski@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20240814195823.437597-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/08/2024 21:58, Krzysztof Kozlowski wrote: > Terminating for_each_child_of_node() loop requires dropping OF node > reference, so bailing out after thermal_of_populate_trip() error misses > this. Solve the OF node reference leak with scoped > for_each_child_of_node_scoped(). > > Fixes: d0c75fa2c17f ("thermal/of: Initialize trip points separately") > Cc: > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog