mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: david@ixit.cz, Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default
Date: Wed, 17 Dec 2025 12:11:22 +0100	[thread overview]
Message-ID: <65d717fd-d4c4-4ee1-8d9d-bf1f38531403@oss.qualcomm.com> (raw)
In-Reply-To: <20251213-sdm845-mclk-v1-2-197bc947d4c6@ixit.cz>

On 12/13/25 1:00 PM, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> All Snapdragon 845 platform has same controls GPIOs.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 2 +-
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts                       | 8 --------
>  2 files changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> index dbe1911d8e470..f6c2c98970d76 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> @@ -40,7 +40,7 @@ camera@10 {
>  		/* CAM0_RST_N */
>  		reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
>  		pinctrl-names = "default";
> -		pinctrl-0 = <&cam0_default>;
> +		pinctrl-0 = <&cam0_default &cam_mclk0_default>;
>  
>  		clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
>  		clock-names = "xvclk";
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index ce23f87e0316b..981d19c20fa1f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -877,14 +877,6 @@ rst-pins {
>  			drive-strength = <16>;
>  			bias-disable;
>  		};
> -
> -		mclk0-pins {
> -			pins = "gpio13";
> -			function = "cam_mclk";
> -
> -			drive-strength = <16>;
> -			bias-disable;
> -		};

Please also remove the mclk3 below

Konrad

>  	};
>  
>  	cam3_default: cam3-default-state {
> 

      parent reply	other threads:[~2025-12-17 11:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-13 12:00 [PATCH 0/2] Commonize pinctrl for camera master clock on Qualcomm SDM845 David Heidelberg via B4 Relay
2025-12-13 12:00 ` [PATCH 1/2] arm64: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
2025-12-14  0:09   ` Vladimir Zapolskiy
2025-12-16 12:54   ` Bryan O'Donoghue
2025-12-17 11:11   ` Konrad Dybcio
2025-12-13 12:00 ` [PATCH 2/2] arm64: dts: qcom: sdm845-db845c: Use introduced platform wide cam_mclk0_default David Heidelberg via B4 Relay
2025-12-14  0:12   ` Vladimir Zapolskiy
2025-12-17 11:11   ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65d717fd-d4c4-4ee1-8d9d-bf1f38531403@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®