From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 569B9C76195 for ; Wed, 22 Mar 2023 14:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230329AbjCVO7r (ORCPT ); Wed, 22 Mar 2023 10:59:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbjCVO7k (ORCPT ); Wed, 22 Mar 2023 10:59:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED8ED6595 for ; Wed, 22 Mar 2023 07:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679497126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NTDHGidtxxNwvUoWqQhKBSxK12xTyzlrRv/7eEx1M9k=; b=EtgUT/D8iK7smfM1qawOuEEV54nU60+lRcjds2DqWNndVO43fRaEeGAyUwhjqmvzAuymex /WfDWptmtI48W6vq40QmKshDxoTPJzi7mA4DSU5QK6LmNS169duVSpGPd/eCX3P/+D+/Of 1sYspSUVEvsQgz+JiIBX7Hm+sQsWoWs= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-IPsS_YedPMyqheN4gJKGlQ-1; Wed, 22 Mar 2023 10:58:44 -0400 X-MC-Unique: IPsS_YedPMyqheN4gJKGlQ-1 Received: by mail-qt1-f199.google.com with SMTP id t22-20020ac86a16000000b003bd1c0f74cfso11014538qtr.20 for ; Wed, 22 Mar 2023 07:58:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679497124; x=1682089124; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NTDHGidtxxNwvUoWqQhKBSxK12xTyzlrRv/7eEx1M9k=; b=WxVnQw34CLCQazB5VICtcFMs6wPOMJmAVs85rLNdqbY0WBMyZ0BALYwXqCDHgZ6LAp n3tYjo4oDX97vrLVe6v7kb1DttyJ03EuyDswHRvLUL8xP+aY+0mK9byb/7uf7cajLWl+ sVpWnzruzFHBjnrz0WpaRq0/rCIDKQ57+vtF+GjGRvquftAESzJfS8R8WUhxpSUfKEZ7 ibWmLP2bs5WLsXXMn2OgU2aLVpaNvwTc7rh02ZicnrFhxjV400/5RyqKA2OJdRZ0Utpt MQpNqeFg+nA7AETN7m5Ql3hLhyMr1TXp23LS4lJIMkrXW5UzoaYxl5fBbAH1QKtq6Xme fPzw== X-Gm-Message-State: AO0yUKWG5cvcNsVKvOhn2A3EJ94rtzbPh1nN9yaQdJmI62N9xa5x8EQ5 +HAIms4RHKaOgfhvLRSeoWBT38yL9jGsLfo65pW+QD6f68EbkqbqsBQ+t9Uzh4F/lUlat7qm79H iRS6Zk9bhpEFl8qKL7m51BxZt X-Received: by 2002:a05:6214:528d:b0:5ad:cd4b:3765 with SMTP id kj13-20020a056214528d00b005adcd4b3765mr9966453qvb.1.1679497124424; Wed, 22 Mar 2023 07:58:44 -0700 (PDT) X-Google-Smtp-Source: AK7set8v93I76Hrh6VYaSGaLjbIuUhXMY4ShyL1lpTiTt6XnQgpguzMVChPp0c+PhTr3DB86BOb1hw== X-Received: by 2002:a05:6214:528d:b0:5ad:cd4b:3765 with SMTP id kj13-20020a056214528d00b005adcd4b3765mr9966419qvb.1.1679497124160; Wed, 22 Mar 2023 07:58:44 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-244-168.dyn.eolo.it. [146.241.244.168]) by smtp.gmail.com with ESMTPSA id y3-20020a37f603000000b0074382b756c2sm11405364qkj.14.2023.03.22.07.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 07:58:43 -0700 (PDT) Message-ID: <65d770947b98805a52573b3fa2df11f5d1778af7.camel@redhat.com> Subject: Re: [PATCH net-next] smsc911x: remove superfluous variable init From: Paolo Abeni To: Wolfram Sang , Geert Uytterhoeven Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Steve Glendinning , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org Date: Wed, 22 Mar 2023 15:58:40 +0100 In-Reply-To: References: <20230321114721.20531-1-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2023-03-21 at 15:38 +0100, Wolfram Sang wrote: > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct smsc911x_data = *pdata =3D netdev_priv(dev); > > > - struct phy_device *phydev =3D NULL; > > > + struct phy_device *phydev; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int ret; > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0phydev =3D phy_find_f= irst(pdata->mii_bus); > >=20 > > Nit: perhaps combine this assignment with the variable declaration? >=20 > I thought about it but found this version to be easier readable. This patch does not apply cleanly to net-next, please rebase and resping. Thanks! Paolo