From: Peng Zhang <zhangpeng.00@bytedance.com>
To: Hillf Danton <hdanton@sina.com>
Cc: robin.murphy@arm.com, joro@8bytes.org, will@kernel.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Li Bin <huawei.libin@huawei.com>, Xie XiuQi <xiexiuqi@huawei.com>,
Yang Yingliang <yangyingliang@huawei.com>
Subject: Re: [PATCH] iommu: Avoid softlockup and rcu stall in fq_flush_timeout().
Date: Thu, 16 Feb 2023 19:02:59 +0800 [thread overview]
Message-ID: <65da1862-364b-9500-4be7-a463a12e6a7f@bytedance.com> (raw)
In-Reply-To: <20230216084902.1486-1-hdanton@sina.com>
在 2023/2/16 16:49, Hillf Danton 写道:
> On Thu, 16 Feb 2023 15:11:48 +0800 Peng Zhang <zhangpeng.00@bytedance.com>
>> There is softlockup under fio pressure test with smmu enabled:
>> watchdog: BUG: soft lockup - CPU#81 stuck for 22s! [swapper/81:0]
>
> What is your kernel version?
Rcu stall occurs in kernel version 5.4.
The test where the softlockup happened was not done by me, so I don't
know the kernel version.
However, it is the same as the code logic of fq_flush_timeout in the
mainline kernel.
>> This is because the timer callback fq_flush_timeout may run more than
>> 10ms, and timer may be processed continuously in the softirq so trigger
>> softlockup and rcu stall. We can use work to deal with fq_ring_free for
>> each cpu which may take long time, that to avoid triggering softlockup
>> and rcu stall.
>>
>> This patch is modified from the patch[1] of openEuler.
>
> Because of a timer hog observed on your system with 128 CPUs for instance
> does it make any sense to ask Peter to apply the patch for his 2-CPU box?
What is 2-CPU box?
next parent reply other threads:[~2023-02-16 11:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230216084902.1486-1-hdanton@sina.com>
2023-02-16 11:02 ` Peng Zhang [this message]
2023-02-16 7:11 Peng Zhang
2023-04-10 22:22 ` Jerry Snitselaar
2023-04-18 10:41 ` Vasant Hegde
2023-04-28 5:44 ` Vasant Hegde
2023-05-22 14:58 ` Joerg Roedel
2023-05-22 15:18 ` Jerry Snitselaar
2023-05-22 15:35 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65da1862-364b-9500-4be7-a463a12e6a7f@bytedance.com \
--to=zhangpeng.00@bytedance.com \
--cc=hdanton@sina.com \
--cc=huawei.libin@huawei.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xiexiuqi@huawei.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®