From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93C719B3EE for ; Tue, 28 Jan 2025 11:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738062586; cv=none; b=HdI9s7t9RcrNuWceyZ5LteKaklZ9CucoPkiZbyefNcIqXz0NpgIhmK+CkzK2dKjgmhKzQilD10T8IkVDGOvADEKr6IlLjmMmshDUifCWoWjRRsa0pKKzv57M4S9Y5XYCsK8gzlEs09+TBWgXQFbZWKMexmUB1sOX3T8pYFS11os= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738062586; c=relaxed/simple; bh=FCzCdXDixomOPjcHMbLKXnIA0J7l3YwpyrSrtlH3Sns=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VzhJ+H7yMitVb+PGog4FKLshVxXWZ/sStpXUlxcv5/j+AbXw68WNbr8ymruQZSWGn/qfaHEheL+kbuyPHh3vFhRCw6+EPbd61BcGU1BUhi/gyJHFA0DK+85Qk5pGAujuMqXoUOIdq50tEv08+T+WVn0gKdkH08+Ke7iTedpIVBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=GqySkiFd; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="GqySkiFd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1738062581; bh=FCzCdXDixomOPjcHMbLKXnIA0J7l3YwpyrSrtlH3Sns=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GqySkiFd/bE9lc9FiSczCh+QZI1Zw6gjiViMffGWZeL6JbZElP53tP1PMVej9NhFs rHdIvfS5z3uruMTyxiM/2kUoO53C09fJe4wMkaGZuMTrIZ8i4sedOjFRBPGcNpnYQz FDthnsSzoyLYrngVCvn6yTTdHn9Sve35pghxKhCepZyivbG8WR5AsWROS7/8SiGELJ cDudq4JQ46k3MM4cnnm6Nzitc11j2cX2xgy55eoAkDviKKetO+oSCQm2Z4CFqVkSyr SHVM+scxa64yOL0WsaWYZSc3hhuf5U+0mPmKR3gT9x3EUaFNxs63cxBBJK2bURkBPP GmJG8T+e/1pVg== Received: from [192.168.1.90] (unknown [188.27.43.189]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 5886417E0E6E; Tue, 28 Jan 2025 12:09:41 +0100 (CET) Message-ID: <65dc1384-88cc-480c-a028-f927ed2419df@collabora.com> Date: Tue, 28 Jan 2025 13:09:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] Fixup drm_atomic_helper_connector_hdmi_check() To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Dave Stevenson , Dmitry Baryshkov , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno References: <20250114-hdmi-conn-null-mode-v3-0-16bca91e11b0@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Maxime, On 1/28/25 11:58 AM, Maxime Ripard wrote: > Hi, > > On Tue, Jan 14, 2025 at 08:16:55PM +0200, Cristian Ciocaltea wrote: >> Fix a NULL pointer dereference discovered while unloading a DRM module >> and provide a test to make sure the helper works as expected in case the >> connector's CRTC is shut down. >> >> Signed-off-by: Cristian Ciocaltea > > I'm sorry, I didn't realize it at the time but it looks like it was made > redundant by another series that got merged about the same time you were > sending this one: > > https://patchwork.freedesktop.org/series/143378/ > > Sorry again, No worries. I checked the merged series and I think some bits from this series are still applicable: * Simplify the NULL verification by considering only the return of connector_state_get_mode(), which gets rid of the redundant 'new_conn_state->crtc' check, but also covers the additional checks already performed in that function. * Update the newly introduced test case to also verify {mode|connectors|active}_changed. I could send those as v4, but probably it makes sense to drop this series and start a new one - please let me know if you have a preference here. Thanks, Cristian