From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE59CE79AB for ; Wed, 20 Sep 2023 07:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233765AbjITH3w (ORCPT ); Wed, 20 Sep 2023 03:29:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233714AbjITH3h (ORCPT ); Wed, 20 Sep 2023 03:29:37 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2970894 for ; Wed, 20 Sep 2023 00:29:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AE9EC433C8; Wed, 20 Sep 2023 07:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695194971; bh=R/LetqBjqdPDGe4IllLhQOI0/OP/i4mhWyG/NZ4Z9g8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iGnvJcAQnGhOcewj3jr5C0mSBG+QwMhY1aK9vGtHCjuNXJOBTTnVzs8RiOApQYI/k jjPSR98kIPhA7GHRGroW1KDL18ea8aagmHincHE4EdiA5wLDFgaXjz1WTvFlKTHbmX 9GOXVmKKBvkNoKYNdR8+0t1itFV5SOTxjcrYoo5gP9zr3q+DdHMrdd6AmArWL5pO8d vnWJVUvdujgNebAUwwpK7VsqLP77ZQM0mpSMf3SzWk4G9ad2G25QUGYyI55AuNvPQt RUkQpnZz7pPXBgVpGBVTxWYL+4D5ugxt9mRtxNv6dA7QR++EpaV7aLnQpa9anv2Rd3 awaCjJoINy2cg== Message-ID: <65ddacbc-7094-5038-bc13-16bf209fc954@kernel.org> Date: Wed, 20 Sep 2023 10:29:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] usb: cdns3: Modify the return value of cdns_set_active () to void when CONFIG_PM_SLEEP is disabled Content-Language: en-US To: Xiaolei Wang , peter.chen@kernel.org, pawell@cadence.com, gregkh@linuxfoundation.org, pavel@denx.de Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230912064946.1405848-1-xiaolei.wang@windriver.com> From: Roger Quadros In-Reply-To: <20230912064946.1405848-1-xiaolei.wang@windriver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiaolei, On 12/09/2023 09:49, Xiaolei Wang wrote: > The return type of cdns_set_active () is inconsistent > depending on whether CONFIG_PM_SLEEP is enabled, so the > return value is modified to void type. > > Reported-by: Pavel Machek > Closes: https://lore.kernel.org/all/ZP7lIKUzD68XA91j@duo.ucw.cz/ > Fixes: 2319b9c87fe2 ("usb: cdns3: Put the cdns set active part outside the spin lock") > Signed-off-by: Xiaolei Wang Should this be CC to stable as the original patch which this patch is fixing has made it into the stable trees. > --- > drivers/usb/cdns3/core.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h > index 4a4dbc2c1561..81a9c9d6be08 100644 > --- a/drivers/usb/cdns3/core.h > +++ b/drivers/usb/cdns3/core.h > @@ -131,8 +131,7 @@ void cdns_set_active(struct cdns *cdns, u8 set_active); > #else /* CONFIG_PM_SLEEP */ > static inline int cdns_resume(struct cdns *cdns) > { return 0; } > -static inline int cdns_set_active(struct cdns *cdns, u8 set_active) > -{ return 0; } > +static inline void cdns_set_active(struct cdns *cdns, u8 set_active) { } > static inline int cdns_suspend(struct cdns *cdns) > { return 0; } > #endif /* CONFIG_PM_SLEEP */ -- cheers, -roger