From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751246AbeAWJXz (ORCPT ); Tue, 23 Jan 2018 04:23:55 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:46130 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbeAWJXy (ORCPT ); Tue, 23 Jan 2018 04:23:54 -0500 Subject: Re: [PATCH] PCI: qcom: add missing supplies required for msm8996 To: srinivas.kandagatla@linaro.org, stanimir.varbanov@linaro.org, linux-pci@vger.kernel.org, bhelgaas@google.com Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org References: <20171208092053.4417-1-srinivas.kandagatla@linaro.org> From: Stanimir Varbanov Message-ID: <65e01829-198e-f549-174d-c8368c5ee193@mm-sol.com> Date: Tue, 23 Jan 2018 11:23:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171208092053.4417-1-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Srini, As there are no comments I'd propose to change the endpoint supplies to more generic names. On 12/08/2017 11:20 AM, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla > > This patch adds supplies that are required for msm8996. Two of them vdda > and vdda-1p8 are analog supplies that go in to controller, and the rest > of the two vddpe's are supplies to PCIe endpoints. > > Without these supplies PCIe endpoints which require power supplies are > not enumerated at all, as there is no one to power it up. > > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/pci/qcom,pcie.txt | 16 +++++++++++++ > drivers/pci/dwc/pcie-qcom.c | 28 ++++++++++++++++++++-- > 2 files changed, 42 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > index 3c9d321b3d3b..045102cb3e12 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > @@ -179,6 +179,11 @@ > Value type: > Definition: A phandle to the core analog power supply > > +- vdda-1p8-supply: > + Usage: required for msm8996 > + Value type: > + Definition: A phandle to the 1.8v analog power supply > + This should be dropped, because it is part of the phy. > - vdda_phy-supply: > Usage: required for ipq/apq8064 > Value type: > @@ -189,6 +194,15 @@ > Value type: > Definition: A phandle to the analog power supply for IC which generates > reference clock > +- vddpe-supply: > + Usage: optional > + Value type: > + Definition: A phandle to the PCIe endpoint power supply vddpe_3v3-supply > + > +- vddpe1-supply: > + Usage: optional > + Value type: > + Definition: A phandle to the PCIe endpoint power supply 1 vddpe_1v5-supply > > - phys: > Usage: required for apq8084 > @@ -205,6 +219,8 @@ > Value type: > Definition: List of phandle and GPIO specifier pairs. Should contain > - "perst-gpios" PCIe endpoint reset signal line > + - "pe_en-gpios" PCIe endpoint enable signal line > + - "pe_en1-gpios" PCIe endpoint enable1 signal line We don't need those gpios, the regulator driver will manipulate these gpios when we call regulator_enable/disable. -- regards, Stan