From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: yzddmr6@gmail.com, Srinivas Kandagatla <srini@kernel.org>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: q6dsp-lpass-clocks: Set driver data before registering clocks
Date: Tue, 17 Nov 2026 15:36:29 +0000 [thread overview]
Message-ID: <65e501e0-b6d5-4204-ba6a-2d35091e2ae6@oss.qualcomm.com> (raw)
In-Reply-To: <20261115-upstream-q6dsp-clk-drvdata-v1-1-4d7dbea52e52@gmail.com>
On 11/15/26 1:12 PM, yzddMr6 via B4 Relay wrote:
> From: yzddMr6 <yzddmr6@gmail.com>
>
> The clk ops of the q6dsp clock controller look up struct q6dsp_cc with
> dev_get_drvdata(), but q6dsp_clock_dev_probe() sets the driver data only
> after it has registered the clocks and added the OF clock provider. A
> consumer that gets and prepares one of the clocks in between
> dereferences a NULL pointer.
>
> fw_devlink does not keep consumers out of that window. The q6prm and
> q6afe clock controllers are described below the ADSP remoteproc node,
> and their devices are only created once the ADSP has booted and its
> GPR/APR services have come up, long after the remoteproc device has
> bound. fw_devlink therefore makes the remoteproc device the supplier of
> their consumers. A consumer such as the LPASS LPI pinctrl then just
> defers until of_clk_get() succeeds, and its retry from the deferred
> probe worker can run while the clock controller is still in its probe.
>
> That happened once on a Xiaomi Pad 8 Pro (SM8750). While the LPI pinctrl
> probe registered its GPIO chip, gpiolib read a GPIO direction, which
> runtime resumed the device and prepared its q6prm vote clocks through
> pm_clk. The prepare op then faulted with a NULL pointer dereference at
> virtual address 0x350 (trimmed):
>
> pc : clk_vote_q6dsp_block+0x24/0x58 [snd_q6dsp_common]
> lr : clk_core_prepare+0x7c/0x298
> Call trace:
> clk_vote_q6dsp_block+0x24/0x58 [snd_q6dsp_common] (P)
> clk_core_prepare+0x7c/0x298
> clk_prepare+0x28/0x44
> pm_clk_resume+0x10c/0x188
> pm_generic_runtime_resume+0x2c/0x44
> ...
> __pm_runtime_resume+0x50/0x94
> ...
> lpi_gpio_get_direction+0x4c/0x8c [pinctrl_lpass_lpi]
> gpiochip_add_data_with_key+0x7b0/0x10dc
> devm_gpiochip_add_data_with_key+0x38/0x8c
> lpi_pinctrl_probe+0x2b8/0x320 [pinctrl_lpass_lpi]
> ...
> deferred_probe_work_func+0x88/0xc0
>
> 0x350 is the offset of desc in struct q6dsp_cc; the driver data pointer
> it was loaded from was NULL. The oops left the clk prepare_lock held,
> which blocks every later clk_prepare(), and the system did not finish
> booting.
>
> On mainline the window is short, but it includes a wait for prepare_lock
> in clk_core_reparent_orphans(), which of_clk_add_hw_provider() calls
> right after listing the provider. The kernel that hit this had
> out-of-tree changes to drivers/clk/clk.c that do more work at that
> point, which makes the window wider.
>
> Both q6afe-clocks and q6prm-clocks use q6dsp_clock_dev_probe(). Set the
> driver data before the first clock is registered.
>
> The oops was analysed and the fix written with the help of an AI coding
> assistant.
>
> Fixes: 9ab71ac37240 ("ASoC: qdsp6: q6afe-clocks: move audio-clocks to common file")
> Cc: stable@vger.kernel.org
> Signed-off-by: yzddMr6 <yzddmr6@gmail.com>
Reviewed-by: Srinivas Kandagatla<srinivas.kandagatla@oss.qualcomm.com>
--Srini
> ---
> The kernel that hit this was v7.4-rc2 with out-of-tree board support and
> other changes, including the clk.c changes mentioned above. The oops
> showed up once in the 23 boots of that kernel I have logs for, and I
> have not been able to reproduce it on demand. The patch is build-tested
> (arm64 defconfig, W=1) on the base commit below.
>
> I used an AI coding assistant for this work. It analysed the oops,
> traced the probe ordering and drafted this patch and changelog. I have
> reviewed the change.
> ---
> sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c b/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c
> index 94d96130245e..c3628f90fdb2 100644
> --- a/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c
> +++ b/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c
> @@ -146,6 +146,12 @@ int q6dsp_clock_dev_probe(struct platform_device *pdev)
> cc->dev = dev;
> q6dsp_clks = desc->clks;
>
> + /*
> + * The clk ops look up cc through the driver data, so set it before
> + * any of the clocks can be prepared.
> + */
> + dev_set_drvdata(dev, cc);
> +
> for (i = 0; i < desc->num_clks; i++) {
> unsigned int id = q6dsp_clks[i].clk_id;
> struct clk_init_data init = {
> @@ -174,12 +180,6 @@ int q6dsp_clock_dev_probe(struct platform_device *pdev)
> return ret;
> }
>
> - ret = devm_of_clk_add_hw_provider(dev, q6dsp_of_clk_hw_get, cc);
> - if (ret)
> - return ret;
> -
> - dev_set_drvdata(dev, cc);
> -
> - return 0;
> + return devm_of_clk_add_hw_provider(dev, q6dsp_of_clk_hw_get, cc);
> }
> EXPORT_SYMBOL_GPL(q6dsp_clock_dev_probe);
>
> ---
> base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
> change-id: 20261114-upstream-q6dsp-clk-drvdata-e09d27f289b3
>
> Best regards,
> --
> yzddMr6 <yzddmr6@gmail.com>
>
>
prev parent reply other threads:[~2026-11-17 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 13:12 yzddMr6 via B4 Relay
2026-11-17 15:36 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65e501e0-b6d5-4204-ba6a-2d35091e2ae6@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=yzddmr6@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®