From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B72E73C7DE1 for ; Thu, 2 Jul 2026 10:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782987764; cv=none; b=oA3BsM1g0YlgAAfcTqBA/NKOl3GDpfTKQkZqO5w9pueE6Zf8VgAW8F8cMLTZHjAa7K4WVA6evH8W/4MAeYxQjvNHHVuTA9h5WsSfwbGFd06jvU+Q8ssjWQ6mFNKCQDC5F+eaYtJwCSm4Wnm3g2NqtMOfeMs3yICkO8YrYXqJFwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782987764; c=relaxed/simple; bh=o9tFLmNsR/+FbAtqghIZ3r5O3LeY6k36CTWd36OTwh8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KPzcPM2ShRgCUcMTzdnsJWjnUysbNZmr3uCODcqtnJx8lISECBzvr2LeBOnmD/2aCqqcosJYtr8YAM1ue8zl5ecMo82q4jNqhqmIN1oJW/gYd6nTuTvjknBELr28MvUrCa6EFCDKLJwwYMW2sUwOQAvfefIA5KNz6vp60nt+oSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AWTF2z/I; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YuXX1ZBE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AWTF2z/I"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YuXX1ZBE" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6624magM3489492 for ; Thu, 2 Jul 2026 10:22:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0ukcBbTjMthKe2GNqJ+5N6ofiA9OEHfabMRs+DdH7aw=; b=AWTF2z/IkMlVsj0I kaKuoJVOXInwToOv58Uv+dB9TxSgyw3vL94GBLBC2Mfp8LdEz+ZfA6X6dXVYYUUA NWCFR5c8S3t59chmihgNX3kdg1GI5qDH/+yE4mKuYfYrqS9zJuR65wH5zWxGVSfR j0s6ooJzh2mZZKdNufhWi3wlL0t/M8eqDzk8YpXFqj9CDM/Nd8PthpdX4bZThkUN LM8JIJCAxI0zimjPaER2vOc+bsg+NUs5tMyq8bQAl/KfHK2Ts4gH1tPJhua5sLkT 64i1KEFm+BntBGuSsaxs1Jap0R7rplT/sTKF5JmYjDU+T2jDj18cl3bJopKhW1FW D8j//g== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5h98h6gy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 10:22:41 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-37fc66ee6a4so2762360a91.3 for ; Thu, 02 Jul 2026 03:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782987761; x=1783592561; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0ukcBbTjMthKe2GNqJ+5N6ofiA9OEHfabMRs+DdH7aw=; b=YuXX1ZBEUsWVuZPbXegg5h8dgkp9aIbgZuiuETaeZWDUIHzO0DDP90FzhK4QlTy8K0 0Kuzq9QUHoBph1HzS8X9SoOER2GsWwO8WDxaNa3Wg65frTl/6SV6HLg9HirJW7V0P9rL mEAQMpCFwXQtNr74dTvLxda1KZyjXc4ADHp6x9u1peWUXfnsLbwgT8L/5HMPOMaJAIeg whvwlGXT1OOAf5EpUSdfwe9et8W0eY9AJY1vpPvcknJkp8467QU52k5sdrNDVzchmQQ5 xkcey7lWa8OqMchli5BFOenVwPValoP3jaqvWxdZB45MdfTE/Xs2mwm0/dllMWRfU+yZ 0BXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782987761; x=1783592561; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0ukcBbTjMthKe2GNqJ+5N6ofiA9OEHfabMRs+DdH7aw=; b=eaUnLDxLfT/0q3SLoeZoDz7lKf15hN8Gfnk2DxzVb5dPbbzdw17WOh/PhpXoQM2ptT eTM+z7TK/6qxaCqf+0Dd3ogM74qWYCGZdHLYoESPIocqm9az39fBnCWbmj8aFdRjSuaY 9zPtlNwl6X769tVt8B5Bz3nJ9rcQ1k0sH45AnbFrRvxQUwI9mbo5hI0f1HfA6MtXBn2F HvY3OLcO38S9q2t3ZNg9kpgD/QoACtlxGjBPIiijffrn+lIYArfEELNHkKudXxhVkJvo L1BamdgLX+Hdv0LrH9F2yvJ4kwwTjYlUwhBUCQXwXby2IlffHNufYNG65R/eCGQDQ1wQ 57sA== X-Forwarded-Encrypted: i=1; AHgh+RpLH4cnhuuwRLeBlcrmzRb39r0F7CGt3x/Jki+99VGGDuiHqVJenJnCOaTbsful/NpAikm79TZUyeKJmds=@vger.kernel.org X-Gm-Message-State: AOJu0YzEj1xwIUkCy5XI6bngopeem4SFu48n0xIy7Xn/ypbCnh410KWz w8cf4M356ajSgmXKf/tMkbjY/jkxNZr/MK1BQDgb4JH99owlfxiuHW2sXjy2homtaVvQeJ56owz XeD8b2ne783x0hNlZ+T6Y6RhRxiooZzVOTnVstywrUGPud3S8NfQEMSEsdVtE+0LqcEA= X-Gm-Gg: AfdE7clX9ris0mn72NN0XGnX68m569Q18NWrh7QQ7DJ1YjIlSfu5Wvzou788PM2jVdV b+ocwhzFNw3WNrXRC4/FPSdu4+d6fee18bjmbMbrH3PKKkJgGVb72GXgnroJaSM86N9KD98dmuh at2YMXjy5RNcZk1CoJanf5aK/Kv4PJuckTEXnrUCQMDs4PjMQcIVYlt0zrZTGwXm0CRtm2/fdFv VvKo5kznG4VR1ODliNGE9Bky22DOlu0a1AvDqqWkLG7BRmP7R0Ctxsyeb1nz/OMRzJ/IsOAylaX gsQ+orolxR7KMer9E+jtB9N3+Dmx27iU/XDYWLhHTAcUcYXrXzRl2ndUR62XGja2SLHszkpZpsJ T+/RceM1XusVV2AR5D2yUxH7YG6r0tgAgmReGKwoWlaId X-Received: by 2002:a17:90a:ec85:b0:366:132:fda7 with SMTP id 98e67ed59e1d1-380ba868183mr4639870a91.10.1782987760678; Thu, 02 Jul 2026 03:22:40 -0700 (PDT) X-Received: by 2002:a17:90a:ec85:b0:366:132:fda7 with SMTP id 98e67ed59e1d1-380ba868183mr4639854a91.10.1782987760158; Thu, 02 Jul 2026 03:22:40 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-380e160b4c7sm862810a91.11.2026.07.02.03.22.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:22:39 -0700 (PDT) Message-ID: <65e9d52b-d747-40b2-a6d0-424ed03c9469@oss.qualcomm.com> Date: Thu, 2 Jul 2026 15:52:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] dt-bindings: i2c: Add Qualcomm I2C slave controller To: Wolfram Sang , Viken Dadhaniya Cc: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260628-i2c-qcom-slave-v1-0-8b0a5c01f9f6@oss.qualcomm.com> <20260628-i2c-qcom-slave-v1-1-8b0a5c01f9f6@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: qodXtB4SXRgt1mZ0DgX8x33KeXZWI5IY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDEwNiBTYWx0ZWRfX7C6FyuIMdqJU mPmEYqrb5RMgXoceyDTNpVV44BVGHYX6fAGcpu0vcUysHkoEAmCDYLiPMLjkpkwZFq/+RPsnrv7 VXVTOKzTiwAEeLmmLM4Rr+KP1ltOYGiVIUWxDeca88DLgLvzL9vRHxMrPSe4aqsOFnPsbfhJxlr GKYEE06L3aizfcTyzT2Rx0PFNt/w5sgxTGohX5qMD6thepLS5O/97jtiv/2xvWGcDUsn3HURVC7 qkedTAq9ldMidmFDJITOf272iFBQ9LKzBTNxOexbA1gDcWailtDgWjZbVEm3DfDn67qA9ifXbUR WPGiGTixy8gfBZ7LQ7qJRR8UZqUydPNhoRocUKaYwI84nOfmBrmBIg1hwZoicCJ8eBdMhPljr/O iO1oWU9szXNXgEMrP59Z/UE/ZEBYV5/9rMhMG/xIr5E8G0eJ4ZQYDJmPmUO5OVG+i8oUFvSFIHg 5h3CfRlWr7OasHD5rTQ== X-Proofpoint-GUID: qodXtB4SXRgt1mZ0DgX8x33KeXZWI5IY X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDEwNiBTYWx0ZWRfX+28j4cFK07eP EeiFkpjQCHQY3dkSurCYGcpxBGe+8C59lIbVWidHpmNubWjLWvT6tI6HuovQZ1DJH+G/6qdoRRm mGWWy17Dij1p04FOfURsU/g0xV43yEw= X-Authority-Analysis: v=2.4 cv=bdFbluPB c=1 sm=1 tr=0 ts=6a463bf1 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=NyuSsmef85SJCTiwSksA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020106 On 6/29/2026 11:56 AM, Wolfram Sang wrote: > Hi, > > On Sun, Jun 28, 2026 at 08:09:04PM +0530, Viken Dadhaniya wrote: >> Add a binding for the Qualcomm I2C slave controller found on QDU1000. The >> block operates only as an I2C slave and supports FIFO/PIO transfers, so it >> needs a binding separate from Qualcomm I2C master controllers. > > The official naming in I2C is now 'target' instead of 'slave'. Do you > think you can rename that? I know the Linux I2C core has still the old > wording in a lot of places and needs to be converted. However, if > possible, it would be nice if not more of the old terms would be added > which need to be converted at some point anyhow. > Agree, let's change to target naming. >> Document the MMIO region, interrupt, XO and AHB clocks, interconnect path, >> and the 7-bit slave address needed to describe the controller in device >> tree. >> >> Use the 'qcom,slave-addr' property for the slave address because 'reg' >> describes the controller MMIO range, and this slave-only controller has no >> child node where an I2C address can be encoded. > > This should not be needed because the backend defines which address is > going to be used? Can you share how you tested this? > > Happy hacking, > > Wolfram >