From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Rob Herring <robh@kernel.org>
Cc: grant.likely@linaro.org, devicetree@vger.kernel.org,
frowand.list@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: irq: don't return 0 from of_irq_get()
Date: Fri, 10 Jun 2016 15:14:40 +0300 [thread overview]
Message-ID: <65e9eb00-ba9a-87c5-1410-8a5da6b42c8f@cogentembedded.com> (raw)
In-Reply-To: <20160603121432.GB8472@rob-hp-laptop>
On 6/3/2016 3:14 PM, Rob Herring wrote:
>> of_irq_get() returns 0 iff irq_create_of_mapping() call fails. Returning
>> both error code and 0 on failure is a sign of a misdesigned API. Return
>> -ENXIO instead like one of the callers, platform_get_irq(), does; fix up
>> the kernel-doc as well...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> So I think this is done this way because of the variation in NO_IRQ
> definition across architectures.
I remember that NO_IRQ is "considered harmful" by Linus. Actually, I'm nit
sure what you mean, could you elaborate on that?
> But then again, of_irq_get is
> relatively new.
> Rob
MBR, Sergei
next prev parent reply other threads:[~2016-06-10 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 21:53 Sergei Shtylyov
2016-06-03 12:14 ` Rob Herring
2016-06-10 12:14 ` Sergei Shtylyov [this message]
2016-06-10 12:55 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65e9eb00-ba9a-87c5-1410-8a5da6b42c8f@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®