From: Oliver Neukum <oneukum@suse.com>
To: Corentin LABBE <clabbe@baylibre.com>, Oliver Neukum <oneukum@suse.com>
Cc: gregkh@linuxfoundation.org, johan@kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
neil.armstrong@linaro.org
Subject: Re: [PATCH v2 1/2] usb: serial: add support for CH348
Date: Wed, 26 Oct 2022 10:02:32 +0200 [thread overview]
Message-ID: <65ed2576-55a4-fbf1-010b-a51e92389062@suse.com> (raw)
In-Reply-To: <Y1jlTP7HuH1FQbpk@Red>
On 26.10.22 09:44, Corentin LABBE wrote:
Hi,
>
> Thanks for your review, I will fix them all.
I am happy to point out issues.
>> [..]
>>
>>> +
>>> +static int ch348_fixup_port_bulk_in(struct ch348 *ch348, struct usb_serial_port *port)
>>> +{
>>> + int i;
>>> +
>>> + /* Already Initialized */
>>> + if (port->bulk_in_size) {
>>
>> BTW, shouldn't these be unsigned int?
>
> I dont understand what you mean here.
bulk_in_size as a member of the structure is defined as int.
As a size cannot meaningfully be negative and this takes no
error reports, I was wondering whether it should be declared
an unsigned integer for the sake of cleanliness.
Regards
Oliver
next prev parent reply other threads:[~2022-10-26 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 13:37 [PATCH v2 0/2] " Corentin Labbe
2022-10-21 13:37 ` [PATCH v2 1/2] " Corentin Labbe
2022-10-24 9:40 ` Oliver Neukum
2022-10-26 7:44 ` Corentin LABBE
2022-10-26 8:02 ` Oliver Neukum [this message]
2022-10-21 13:37 ` [PATCH v2 2/2] usb: serial: add myself as maintainer of CH348 Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65ed2576-55a4-fbf1-010b-a51e92389062@suse.com \
--to=oneukum@suse.com \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®