From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553AbcGVJ7J (ORCPT ); Fri, 22 Jul 2016 05:59:09 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:36214 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753190AbcGVJ7G (ORCPT ); Fri, 22 Jul 2016 05:59:06 -0400 Subject: Re: [PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy To: tom.ty89@gmail.com, tj@kernel.org, hare@suse.de, arnd@arndb.de References: <20160721214202.GG23759@htj.duckdns.org> <9bbf2b818f9ca1bb48f1eae31a0f3924a4fe0d9a.1469143747.git.tom.ty89@gmail.com> <8d3cb878e86e0e4be2212f05ce47ff60cbfd3e10.1469143747.git.tom.ty89@gmail.com> Cc: sfr@canb.auug.org.au, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org From: Sergei Shtylyov Message-ID: <65ee2deb-200c-a467-1eb8-ed2eb5f14a70@cogentembedded.com> Date: Fri, 22 Jul 2016 12:59:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <8d3cb878e86e0e4be2212f05ce47ff60cbfd3e10.1469143747.git.tom.ty89@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 7/22/2016 2:29 AM, tom.ty89@gmail.com wrote: > From: Tom Yan > > ata_mselect_*() would initialize a char array for storing a copy of > the current mode page. However, char could be signed char. In that > case, bytes larger than 127 would be converted to negative number. > > For example, 0xff from def_control_mpage[] would become -1. This > prevented ata_mselect_control() from working at all, since when it > did the read-only bits check, there would always be a mismatch. > > Signed-off-by: Tom Yan > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index 4a4e6f1..a28e2ea94 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c > @@ -3610,7 +3610,7 @@ static int ata_mselect_caching(struct ata_queued_cmd *qc, > { > struct ata_taskfile *tf = &qc->tf; > struct ata_device *dev = qc->dev; > - char mpage[CACHE_MPAGE_LEN]; > + u8 mpage[CACHE_MPAGE_LEN]; > u8 wce, mask; > int i; > > @@ -3668,7 +3668,7 @@ static int ata_mselect_control(struct ata_queued_cmd *qc, > const u8 *buf, int len, u16 *fp) > { > struct ata_device *dev = qc->dev; > - char mpage[CONTROL_MPAGE_LEN]; > + u8 mpage[CONTROL_MPAGE_LEN]; Indent with tabs please, as above. [...] MBR, Sergei