From: Joe Perches <joe@perches.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: [PATCH 04/10] amd/7990: Remove extern from function prototypes
Date: Mon, 23 Sep 2013 15:11:31 -0700 [thread overview]
Message-ID: <65ef2eba58fddc268ba0afb4de7757f073d3bb49.1379974101.git.joe@perches.com> (raw)
In-Reply-To: <5570169a078375fa8662adeb2a7f24c1ae718bfb.1379974101.git.joe@perches.com>
There are a mix of function prototypes with and without extern
in the kernel sources. Standardize on not using extern for
function prototypes.
Function prototypes don't need to be written with extern.
extern is assumed by the compiler. Its use is as unnecessary as
using auto to declare automatic/local variables in a block.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/ethernet/amd/7990.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/amd/7990.h b/drivers/net/ethernet/amd/7990.h
index 0a5837b..ae33a99 100644
--- a/drivers/net/ethernet/amd/7990.h
+++ b/drivers/net/ethernet/amd/7990.h
@@ -242,14 +242,13 @@ struct lance_private
#define LANCE_ADDR(x) ((int)(x) & ~0xff000000)
/* Now the prototypes we export */
-extern int lance_open(struct net_device *dev);
-extern int lance_close (struct net_device *dev);
-extern int lance_start_xmit (struct sk_buff *skb, struct net_device *dev);
-extern void lance_set_multicast (struct net_device *dev);
-extern void lance_tx_timeout(struct net_device *dev);
+int lance_open(struct net_device *dev);
+int lance_close(struct net_device *dev);
+int lance_start_xmit(struct sk_buff *skb, struct net_device *dev);
+void lance_set_multicast(struct net_device *dev);
+void lance_tx_timeout(struct net_device *dev);
#ifdef CONFIG_NET_POLL_CONTROLLER
-extern void lance_poll(struct net_device *dev);
+void lance_poll(struct net_device *dev);
#endif
#endif /* ndef _7990_H */
--
1.8.1.2.459.gbcd45b4.dirty
next prev parent reply other threads:[~2013-09-23 22:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 22:11 [PATCH 01/10] can: " Joe Perches
2013-09-23 22:11 ` [PATCH 02/10] 8390: " Joe Perches
2013-09-23 22:11 ` [PATCH 03/10] adi: " Joe Perches
2013-09-23 22:11 ` Joe Perches [this message]
2013-09-24 16:55 ` [PATCH 04/10] amd/7990: " Joe Perches
2013-09-24 18:06 ` David Miller
2013-09-23 22:11 ` [PATCH 05/10] atheros: " Joe Perches
2013-09-23 22:11 ` [PATCH 06/10] broadcom: " Joe Perches
2013-09-23 22:11 ` [PATCH 07/10] brocade: " Joe Perches
2013-09-23 22:11 ` [PATCH 08/10] chelsio: " Joe Perches
2013-09-23 22:11 ` [PATCH 09/10] emulex: " Joe Perches
2013-09-23 22:11 ` [PATCH 10/10] gianfar: " Joe Perches
2013-09-24 7:37 ` [PATCH 01/10] can: " Marc Kleine-Budde
2013-09-24 14:02 ` David Miller
2013-09-24 14:22 ` Marc Kleine-Budde
2013-09-24 14:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65ef2eba58fddc268ba0afb4de7757f073d3bb49.1379974101.git.joe@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®