From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C8A737BE8D for ; Mon, 31 Aug 2026 16:45:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788194739; cv=none; b=IS9f3hFcdr3wjPzwLpU9/fCwuwkMwIVJjZOnEWl0crFcb5lsKarKJqbddka0FCJKsKBlzChRgSMHU9MfZuTeipQumnzD2l2b22WIUvqjX/modRP8HAG+Q8jzajGLOk5Jo5m5p1UTWWiuuWcdmE40E0avLmTC5ZOzy6n5R1UtsFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788194739; c=relaxed/simple; bh=7qHM1Pph7CioC4XwayKEdcvtL/w4TcSEf05VVh0kTb8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IfDM7cnsl/rtmJaOr2ehHWhGcQyXwsgK/K7UUChBpLQXmwpkyYXITt/CJE5kuScqYD4Cu0i3NfwrlT8cAE/8gEdRxf9Nc06LHb2etESSpmLjrRb2qrX7sIrfdPV9Q1ClYgVxA4linZYPjADas/dhKHeCC2Xblh/aw/TD4RzVhi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OKxOfY7/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jnfIPRew; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OKxOfY7/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jnfIPRew" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67VFpvTw4152607 for ; Mon, 31 Aug 2026 16:45:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I1StJ6DrwSXUaQmbo7/HQBFEJbOwbWv30eZXjba0z6M=; b=OKxOfY7/41ow87Vu DRd7kp/AILhvqgYcARM6FOsCrqy9WaGCtFgIRZb3VvwYxaWwaEiAvQXxXOtFLlgx Fi31ZGwNrQrPABjRDa0S3bZWzgqXibTyvRa/2FkEUKmfHo7uU+lhQSOqURwraAcw 0Rb7tMA8Y+/mPWDh4ybH3I5nuBauYlGboy839ZKtEpibjTGZapEB7+NaQLNGpAOh 8rXRpsL/MLdOnervZ/B8bsyyv5XfTLxWK/6hCQSPM/zEDJKRG/sqz7u+efG8fhYY bAVSimuOrX7qZ5nRhiQz0Bm+RCgrQPY1wEQs/nKfYXzYUCdxty/Af/6VDDvnaKZd /HKoCg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gd6h921ta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 31 Aug 2026 16:45:36 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9349ba88188so98341385a.2 for ; Mon, 31 Aug 2026 09:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788194736; x=1788799536; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=I1StJ6DrwSXUaQmbo7/HQBFEJbOwbWv30eZXjba0z6M=; b=jnfIPRewFCx8L02xOVfMgSU+y2PTZtAs+Y7FOPWJsTE7mCZ4N5BUASC3VAI+NzJlKR NAsdOzyND1DFeQtXc23gAqYXpO+XkOzmW2jik820PmHQQVkN967F3EjS94KeEZU5Y86D q5qomVtqH5gPdFS8UXO7aZJ8XU+t7M8s802YFF/udOFIUby1YTxWWREjEf8usmYA7Ysl dYfGKen0AQVXfmgRLCMEwJtjgMZm/ty0ny0vG5HUgnkT8S8dZi7uhIl0JVMkM2tDpl5s V6r92viEBo8KkqUDAGvYvVLAdeZj3YyoS35gSCKJ0X876gY/W0b1VoJt6ioS6heXOzFS 7Qpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788194736; x=1788799536; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I1StJ6DrwSXUaQmbo7/HQBFEJbOwbWv30eZXjba0z6M=; b=Jl4x0vEWSbOLFMqRr0exo9esz0/1vLhSYGbLwt99RHFLd/PyVFFS3jMIhEbyT4S9EW Bw8OQZSCEebUDRLHULI5dpxBnpg0YiBJ854y52eoWgDgf8TrpWBlAwmUbt2FC2TCgRHh HdvUDctpumy+6sOGZNfdwuOT4VD1oQ/hvgOKGXvGBBQpM4I5hFb663imDxXHOz43YJOV N6FaX89qIa2om6ZAptG+HrkyMTJFR6hRMhn/hd291HTA7DM1YowF5VBhTsYUY3rjd3rY ARmJ1o4944f98FCdzdvnKtyZ1zn0/DBDg//niu6G5SqB8Y4jzBPA8zbFGFwp62spXJgJ OQTw== X-Forwarded-Encrypted: i=1; AHgh+RpL/ojeFJjsR8k69205TstZh7HYPtnv/IajfhKFuST1xyCr4biZX3jq+2Bt0qoupJ6EmUMxkuZ3gSCK78A=@vger.kernel.org X-Gm-Message-State: AFuF++mcRamqryqL7Dqk/fLXQ/BcGUmLo6TBHfiQGrwUibou/8E/0pCY XTtovENhlw/z2VHeDfPUf7ZbUyVseEczXokzRSuA42LRPrp8d3kmSS5i7t+OVeemyvLI0eE0l2d Q5XGhCxa0fn8phuKebO4epgEnO5v+cQrTchLV2LPP+5tPhhHMcqJ7xRT6sCIM03IgXzU= X-Gm-Gg: AR+sD11u7iBL8oxQIraj51KAoL37zwhwZQ4NghfOq6Yv2xsiEU2oBCl3k9QZjsbijtr nS5QU4wVRCrowaaOXXiybLhfEoi8h+qNJ0MDvtEEqxduXxAzoSNq1PUjs6HNW+EuCCDu9IWzKJO pmnwQtPobYFQ9B8EVt2vdsjseepGOgBZqYRh2EeFDA+qU5pMiSfVU+R7AjYaBNu3XHQ1DIOp2dH x3AbPXar9LxWDnINYpmkzN554rFn76PVucSOudEEf59zTXWInhJNgej31pWBmV2xRY1CI8BPPRM JgBTMxDzZAK1fl7ze5rb9+N7w7D8wGwjtC/C/zpZDN8QG/W7dJECalpbYguF1qWeliOZKKereEX z3vl/y5hbOWVif2t9qkE2Nw== X-Received: by 2002:a05:620a:224a:10b0:939:3fce:1a60 with SMTP id af79cd13be357-9393fce1addmr285340385a.0.1788194736064; Mon, 31 Aug 2026 09:45:36 -0700 (PDT) X-Received: by 2002:a05:620a:224a:10b0:939:3fce:1a60 with SMTP id af79cd13be357-9393fce1addmr285333785a.0.1788194735549; Mon, 31 Aug 2026 09:45:35 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2564e31462sm432886366b.60.2026.08.31.09.45.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2026 09:45:34 -0700 (PDT) Message-ID: <65f0a137-851f-46a1-a915-bbb2ecfd7f93@oss.qualcomm.com> Date: Mon, 31 Aug 2026 18:45:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC/DO NOT MERGE 09/12] drm/msm/hdmi: Add HDMI for Eliza SoC To: Krzysztof Kozlowski , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-phy@lists.infradead.org References: <20260828-drm-msm-hdmi-eliza-v1-0-67843277de17@oss.qualcomm.com> <20260828-drm-msm-hdmi-eliza-v1-9-67843277de17@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260828-drm-msm-hdmi-eliza-v1-9-67843277de17@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=W6UIkxWk c=1 sm=1 tr=0 ts=6a95afb1 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=Rd23p8nNYRV-PgpY908A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: B8ak_N7LzRkxlNOSlArUF-hwNdv-lMF2 X-Proofpoint-GUID: B8ak_N7LzRkxlNOSlArUF-hwNdv-lMF2 X-Proofpoint-Spam-Info: AW1haW4tMjYwODMxMDE0NCBTYWx0ZWRfX3eyZlEoldbDI dLiaZ0vknOWDO8fLvpLGtfp2aVESoboo0Nyrbk9+OMIQUSXArcTCidwpPCzJLGbqwtly0mExObU F3MTxvklrTdrgf2seGAHUXLHT+giGsk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODMxMDE0NCBTYWx0ZWRfX44qXrbc1Tzxg uxInr3AtoqgJ8CQPT3pE+JGs+ddKhw9LV5Qib3oPhrulNFqwrIqY6UYxW5afN3cLIGrh5f1ERvZ MgkaqfVvWPGhmN5RrL12WjmWkiAihb4ihLFv6z4BAH1NzHrHQSCBMmEj1zMGCLcBX6lJPIR1YnU BxB62wxT/inayXpS6GgiyuCoGsP+O6T/tDU/W8P2lhQdpFC5V/pvbGHkpEmtbh84Q6pfYWP+zhC J0LJf+E98Ik4uhs7aTAfRs6cmsBdMxDqksH/VpHxQY+RuTBvm+hYGcuapvn/Zjn7z3FhCCHC9L9 dHI/RfRzZpk+uSGZBbvsLjOMSafi0x1zrF4Brxr/LpIzeDZgco8GuhGxjFjn+dd6eEcrQG8WqTN T5FGpj39LPX5XNvvNz3Jr8ujmuYEO2suhWiylKdTanLJ2j1rmrG5Dlm69eQW6MkDwrcEVnWOpyl X59WVyQ2eanPAg87i0A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-31_05,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608310144 On 8/28/26 4:05 PM, Krzysztof Kozlowski wrote: > Qualcomm Eliza SoC with DPU v12.4 comes with HDMI on INTF_11 with > additional INTR registers. The device clocks look different comparing > to last variant of HDMI from MSM8998. > > Signed-off-by: Krzysztof Kozlowski > --- [...] > + hdmi->pixel_src_clk = devm_clk_get_optional(dev, "pixel_src"); > + if (IS_ERR(hdmi->pixel_src_clk)) { > + ret = dev_err_probe(dev, PTR_ERR(hdmi->pixel_src_clk), > + "failed to get pixel src clock\n"); > + goto err_put_bridge; > + } Why do we need to toggle the source clock directly? Is the clock driver broken? Konrad