From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A3A6C54EE9 for ; Fri, 16 Sep 2022 13:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231411AbiIPNHE (ORCPT ); Fri, 16 Sep 2022 09:07:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231299AbiIPNHA (ORCPT ); Fri, 16 Sep 2022 09:07:00 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73D099E2F0 for ; Fri, 16 Sep 2022 06:06:58 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id i203-20020a1c3bd4000000b003b3df9a5ecbso15115490wma.1 for ; Fri, 16 Sep 2022 06:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=2e3L0ED1BDpFLdmTFeqIIUKU3RqfHrrBxYTQB/sNCko=; b=WmiEwXzwWnQ7UhY4icQ+KagCVvewZf1BCWbBhzAwP1xnI7f2tTG51N/2zJzL1WOCaR 9aiKuOvqAtqtWM2TmvB6sphGRbKpypjiXP2xf0Oguf5qD1YpKuPiehKdu/cx8lnE3gSu 4Wm8hfai1x6u8g2wF2fwP63cTurPQ4AA1zOnW9KRXPLYl3lFwmci6Ry3V6aM+6HXqs0H NeNmCgewC1WV22suOCH3lAqR6oPUeqk4VFGIP9LHetVlUc3Dmj5McMfTD94JwuJiEtRW GZMbedYUVdldxNrRt7/dYsxbSVbFiV8iDzn7iKSJ5A6sJilWkEcgUZ+JybSqHWI2oiCe oRHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=2e3L0ED1BDpFLdmTFeqIIUKU3RqfHrrBxYTQB/sNCko=; b=0CgRhbOikRjkwVea6Jh7GtVTRXqdWYfZ6kqmLKf9HIMpLcMq8kuVvLSqfXvi2AM+bN D+o/dzolmoWgAgRJHm0q3pydGKoRlc9++wl7E05ePRTbzWT0leLLQNo2JhmazagPYsOR zZCfUzo9r479zCu6bdIV+w8W45xdjdMlCqga8kbnT0wLPP7Atl4EnCx9Mlol/+jCugHA hdP39GGwFc5+lmsiE8K6vYgpBjvjHcVo/ez2EXtrv3zsrA0dSZqGai+dB8R91XMl+I4o mY/gCrsDrK3KgiUyuKRLzbRkoTIMetQKr2jknHWu0AkaZaYMynuks1t/vO00Jo93nIDY vv5A== X-Gm-Message-State: ACgBeo2ODC3kI6KMnGDL0M2YIt/bMWlnYxHXy19LBTexcSj/YLxXdjzu W9ZnkIZ5oVzCC+Wn8sXnNYBOwg== X-Google-Smtp-Source: AA6agR5UFLsDdB3qilLfFu+EUOFH0MP3U4bh23DIqC90LAY0sDX0eH8fz77Jqg/mU9Yy/mi+bZrsGQ== X-Received: by 2002:a05:600c:2142:b0:3b4:92b6:73ba with SMTP id v2-20020a05600c214200b003b492b673bamr10433278wml.139.1663333616920; Fri, 16 Sep 2022 06:06:56 -0700 (PDT) Received: from [192.168.86.238] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id y9-20020a05600c20c900b003a541d893desm2063106wmm.38.2022.09.16.06.06.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 06:06:56 -0700 (PDT) Message-ID: <65f11ed1-f09f-e0a2-91f5-891394160c96@linaro.org> Date: Fri, 16 Sep 2022 14:06:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] slimbus: qcom-ngd-ctrl: Make QMI message rules const Content-Language: en-US To: Jeff Johnson , Alex Elder , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mathieu Poirier , Kalle Valo , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20220912232526.27427-1-quic_jjohnson@quicinc.com> <20220912232526.27427-2-quic_jjohnson@quicinc.com> <20220912232526.27427-3-quic_jjohnson@quicinc.com> <20220912232526.27427-4-quic_jjohnson@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <20220912232526.27427-4-quic_jjohnson@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/09/2022 00:25, Jeff Johnson wrote: > Commit ff6d365898d ("soc: qcom: qmi: use con SHA ID should be at least 12 chars long. Same comment for all the patches in the series. st for struct > qmi_elem_info") allows QMI message encoding/decoding rules to be > const, so do that for qcom-ngd-ctrl. > > Signed-off-by: Jeff Johnson Other than that it LGTM, Once fixed: Acked-by: Srinivas Kandagatla --srini > --- > drivers/slimbus/qcom-ngd-ctrl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c > index 0aa8408464ad..931ab6317467 100644 > --- a/drivers/slimbus/qcom-ngd-ctrl.c > +++ b/drivers/slimbus/qcom-ngd-ctrl.c > @@ -220,7 +220,7 @@ struct slimbus_power_resp_msg_v01 { > struct qmi_response_type_v01 resp; > }; > > -static struct qmi_elem_info slimbus_select_inst_req_msg_v01_ei[] = { > +static const struct qmi_elem_info slimbus_select_inst_req_msg_v01_ei[] = { > { > .data_type = QMI_UNSIGNED_4_BYTE, > .elem_len = 1, > @@ -262,7 +262,7 @@ static struct qmi_elem_info slimbus_select_inst_req_msg_v01_ei[] = { > }, > }; > > -static struct qmi_elem_info slimbus_select_inst_resp_msg_v01_ei[] = { > +static const struct qmi_elem_info slimbus_select_inst_resp_msg_v01_ei[] = { > { > .data_type = QMI_STRUCT, > .elem_len = 1, > @@ -284,7 +284,7 @@ static struct qmi_elem_info slimbus_select_inst_resp_msg_v01_ei[] = { > }, > }; > > -static struct qmi_elem_info slimbus_power_req_msg_v01_ei[] = { > +static const struct qmi_elem_info slimbus_power_req_msg_v01_ei[] = { > { > .data_type = QMI_UNSIGNED_4_BYTE, > .elem_len = 1, > @@ -324,7 +324,7 @@ static struct qmi_elem_info slimbus_power_req_msg_v01_ei[] = { > }, > }; > > -static struct qmi_elem_info slimbus_power_resp_msg_v01_ei[] = { > +static const struct qmi_elem_info slimbus_power_resp_msg_v01_ei[] = { > { > .data_type = QMI_STRUCT, > .elem_len = 1,