From: Rajendra Nayak <rnayak@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>,
ulf.hansson@linaro.org, Rafael Wysocki <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Len Brown <len.brown@intel.com>, Nishanth Menon <nm@ti.com>,
Pavel Machek <pavel@ucw.cz>, Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <vireshk@kernel.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
niklas.cassel@linaro.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH V2 0/5] PM / Domains: Allow performance state propagation
Date: Tue, 27 Nov 2018 10:20:43 +0530 [thread overview]
Message-ID: <65f1e1c8-8227-33f2-6938-8da5c7f0e250@codeaurora.org> (raw)
In-Reply-To: <cover.1543219386.git.viresh.kumar@linaro.org>
On 11/26/2018 1:39 PM, Viresh Kumar wrote:
> Hi,
>
> This series adds performance state propagation support in genpd core.
> The propagation happens from the sub-domains to their masters. More
> details can be found in the individual commit logs.
>
> This is tested on hikey960 by faking power domains in such a way that
> the CPU devices have two power domains and both of them have the same
> master domain. The CPU device, as well as its power domains have
> "required-opps" property set and the performance requirement from the
> CPU eventually configures all the domains (2 sub-domains and 1 master).
I validated this using the rpmh powerdomain driver [1] where I had to model
a relationship across cx and mx powerdomains, so that mx is always >= cx.
Seems to work as expected, I will respin the rpmh powerdomain patches soon
(Though its awaiting Rob's review/ack for the corner bindings)
Tested-by: Rajendra Nayak <rnayak@codeaurora.org>
[1] https://patchwork.ozlabs.org/cover/935289/
>
> Based on opp/linux-next branch (which is 4.20-rc1 +
> multiple-power-domain-support-in-opp-core + some OPP fixes).
>
> v1->V2:
> - First patch (1/5) is new and an improvement to earlier stuff.
> - Move genpd_status_on() check to _genpd_reeval_performance_state() from
> _genpd_set_performance_state().
> - Improve dev_pm_opp_xlate_performance_state() to handle 1:1 pstate
> mapping between genpd and its master and also to fix a problem while
> finding the dst_table.
> - Handle pstate=0 case properly.
>
> --
> viresh
>
> Viresh Kumar (5):
> OPP: Improve _find_table_of_opp_np()
> OPP: Add dev_pm_opp_xlate_performance_state() helper
> PM / Domains: Save OPP table pointer in genpd
> PM / Domains: Factorize dev_pm_genpd_set_performance_state()
> PM / Domains: Propagate performance state updates
>
> drivers/base/power/domain.c | 211 +++++++++++++++++++++++++++---------
> drivers/opp/core.c | 59 ++++++++++
> drivers/opp/of.c | 14 ++-
> include/linux/pm_domain.h | 6 +
> include/linux/pm_opp.h | 7 ++
> 5 files changed, 244 insertions(+), 53 deletions(-)
>
prev parent reply other threads:[~2018-11-27 4:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 8:09 Viresh Kumar
2018-11-26 8:10 ` [PATCH V2 1/5] OPP: Improve _find_table_of_opp_np() Viresh Kumar
2018-11-26 8:10 ` [PATCH V2 2/5] OPP: Add dev_pm_opp_xlate_performance_state() helper Viresh Kumar
2018-11-30 8:45 ` Ulf Hansson
2018-12-03 6:42 ` Viresh Kumar
2018-11-26 8:10 ` [PATCH V2 3/5] PM / Domains: Save OPP table pointer in genpd Viresh Kumar
2018-11-30 8:53 ` Ulf Hansson
2018-11-30 9:05 ` Viresh Kumar
2018-12-03 6:57 ` Viresh Kumar
2018-11-26 8:10 ` [PATCH V2 4/5] PM / Domains: Factorize dev_pm_genpd_set_performance_state() Viresh Kumar
2018-11-30 8:54 ` Ulf Hansson
2018-11-26 8:10 ` [PATCH V2 5/5] PM / Domains: Propagate performance state updates Viresh Kumar
2018-11-30 9:44 ` Ulf Hansson
2018-11-30 9:59 ` Viresh Kumar
2018-11-30 10:18 ` Ulf Hansson
2018-11-30 11:06 ` Viresh Kumar
2018-12-03 13:38 ` Ulf Hansson
2018-12-05 6:42 ` Stephen Boyd
2018-12-05 17:29 ` Ulf Hansson
2018-12-03 8:50 ` Viresh Kumar
2018-11-27 4:50 ` Rajendra Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65f1e1c8-8227-33f2-6938-8da5c7f0e250@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome