From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S936133AbcHJUBJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Aug 2016 16:01:09 -0400
Received: from mga04.intel.com ([192.55.52.120]:3324 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933589AbcHJUBG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Aug 2016 16:01:06 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,501,1464678000"; 
   d="scan'208";a="1038861135"
Subject: Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting
 self
To: John Stultz <john.stultz@linaro.org>, Kees Cook <keescook@chromium.org>
References: <1470786857-27366-1-git-send-email-john.stultz@linaro.org>
 <CAGXu5jJvRuPj8uP9eriuv5t=9wkLjUOB9m-t+1FUhmPiFOFNWw@mail.gmail.com>
 <CALAqxLV6P8U0nVZrsyWSEX+duL7fHt298gm1wHo-Qi5CFAH1_A@mail.gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>, "Serge E. Hallyn" <serge@hallyn.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Oren Laadan <orenl@cellrox.com>,
        Ruchi Kandoi <kandoiruchi@google.com>,
        Rom Lemarchand <romlem@android.com>, Todd Kjos <tkjos@google.com>,
        Colin Cross <ccross@android.com>, Nick Kralevich <nnk@google.com>,
        Dmitry Shmidt <dimitrysh@google.com>, Elliott Hughes <enh@google.com>,
        Android Kernel Team <kernel-team@android.com>
From: Arjan van de Ven <arjan@linux.intel.com>
Message-ID: <65f33d6c-4e51-d659-b6c6-f2eac65c65af@linux.intel.com>
Date: Wed, 10 Aug 2016 13:01:04 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CALAqxLV6P8U0nVZrsyWSEX+duL7fHt298gm1wHo-Qi5CFAH1_A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/10/2016 12:03 PM, John Stultz wrote:

> I wasn't entierly sure. I didn't think PR_SET_TIMERSLACK has a
> security hook, but looking again I now see the top-level
> security_task_prctl() check, so maybe not skipping it in this case
> would be good?

the easy fix would be to add back the ptrace check.. just either ptrace-able OR CAP_SYS_NICE ;)
then you can prove you only added new stuff as well, and have all the LSM from before