From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2D8C3CCFA6 for ; Thu, 18 Jun 2026 09:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781774348; cv=none; b=pag1F/13ixuWgaVM7bLGgi05cqVlSCBnjnWrx8kqP0GOdZicS7v5RetFEIifZ8NFFEBI7kFE99699KiiM6jXChHwsvOJyD5aPvggOz4c+AAQrJLaphmlLAMXzFWujfDwKTIMNG4y3pht+8a9lyY0BysDdv37duoq8f2+4VvfHWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781774348; c=relaxed/simple; bh=NLhURUQSf/5F67nU4OjB7+bpu2qYRSbW4fa+H2kazh8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u4m5CtFnA9GjYsSzeeyKOdNAUyQmgzogw1H35BpzT8WzYIqKkBbJrTbEtOd49I4Cc8xhtPKAwI3BbGtWnXEBCHZv5ptKzOiYHs1EFCBQNUT5NMqPs8K9xtWz2QUGkeTkKARgtyx94mCCJwQmJRIPd0LF+8ruuRCCkvoVRwIe7Qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Mnq+0JDj; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Mnq+0JDj" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-45efb47aa6fso31815f8f.1 for ; Thu, 18 Jun 2026 02:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781774338; x=1782379138; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3/sZ73Azok0J4GtDexU4YrmhCQdZ0STaJkzfrXiPb/A=; b=Mnq+0JDjEYK2wXHA/+5UzqYcy9Gd/k4d4P9NdFfzVZcikhgvdCVMp92ppFuo4KBG9V lj/hufTaccPhE8BiYJzP1MRc5mHU8+fr2agRiqvGalFQiKlrYq6VaMOyxt5zcbxORQYQ 45BQuA/2picxCBiBHhhoffyhmBlMc4N/yHaZCiFQT4J2GlJYklgnFtKWK6HRhmQ1+Wt0 +dVKva5dWTTCWOfsSZLu5M4KpeIgKwx5AleqcQ9xg+5UOhRqP6v7a5WOQQr7ln50ojmr xXJ3WmfcJyfhxwK5sZCpza1iXtbh6gNl7BnrcgUZNUO5r3k1w4RIlVPC70476Fz/zems c04g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781774338; x=1782379138; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3/sZ73Azok0J4GtDexU4YrmhCQdZ0STaJkzfrXiPb/A=; b=Jt84BLGdgHjtCeM6JLC5cAgevhFwm+kH7lYG7Uk/jHmxIxaFq03kscdyvK0pBvStaA uVv1Z0UQwlnMCL+qDn9IwbvDzPlIFFI3HzifiBxxqKULJaN0NL4PSy8wYLAKb6Wsh7D6 yxXnuZEf1N9N8L/wsS5kJWObGRO4kU3PvydZZ3mMDs26w8GGiMVr0/QVYTeXKnsDkEMi 8+t0fkqPSv+ke97RMoRZV3tQ5CRBFgsXFHoQ8GZMhZf4z/m8rexweG2Ga12UOxHxtcRH G3qyMMNjPkUqc4/huLOwLOjGjqINL57gA1+d6qLtrIRRu3UkhifcYtRwz0QzeJEjSMbg sJlQ== X-Forwarded-Encrypted: i=1; AFNElJ8pg1PZhX/wMWC2G8pK+POkJ1EKeNca+RYOnRofCw75dpRG2J3dOPoD9Paru7XfO4itd743nAzARYd6mcU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmf9A5d402P4hZ+Fw9nQigUHmKsWOmqfNFjiNcwgxbnallzhBd xgjod6AZbRyrkeTOSsqtfu+wJP6E6ql24YEvTj9A4hbWzek5FCX1bJ+dl+bvooYNQGE= X-Gm-Gg: Acq92OFv0/b5iHBGd8m5HyvuNfLVwjho8AE8atLmFC7X1EmHNPWkH4v5DnfkgG9tBRL hI8Ux0r1yvITcEkH/ErlhJLoH/KuX+tNuiNesbJLIu475vfWE2hsdb6TUO+r0t2a96ibtUaUEaJ KVQQFtNjOtNXp0fyj4tP9mMOBbPDfrBJdFVFHUoGES7yAiRF0fjmM3kxdYxb8wW9DWW+1yl37cs 2649w2xFSabVlFAV/7WyRXi3FHCrBRiv6rmYxhfLEAiCNFcAP53XquYWbiMLEVoqvuHtxcvlTPf hVbnT3o3mIZbrwbi/V0+dWUVV+G+fuiDC7WPR/PbfrvfThEYkcamrU+7BWgM2vNfigACJ8dcLya +blU8BiS7b7JmbdV72FfYWJXz/37L7aXKb12FC2uKVJEiZ6OAqIKVTCNsJOyYhPW9MlX7a+oJfT 282gMTWW+VsUilqVf/Mg== X-Received: by 2002:a05:600c:3b18:b0:492:37b7:6071 with SMTP id 5b1f17b1804b1-49238230e23mr22505245e9.2.1781774337736; Thu, 18 Jun 2026 02:18:57 -0700 (PDT) Received: from ?IPV6:2001:1a48:8:903::e14? ([2001:1a48:8:903::e14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922fa97a07sm393533975e9.14.2026.06.18.02.18.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 02:18:57 -0700 (PDT) Message-ID: <65f68f41-226f-43ae-8bfc-b9a321bfe5fe@suse.com> Date: Thu, 18 Jun 2026 11:18:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tools/mm/slabinfo: fix total_objects attribute name Content-Language: en-US To: Yichong Chen , akpm@linux-foundation.org, Harry Yoo Cc: penberg@cs.helsinki.fi, clameter@sgi.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park , Hao Li References: <96556748872BB47E+20260612071359.649946-1-chenyichong@uniontech.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.com; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSFWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmNvbT7CwZcEEwEKAEECGwMFCwkIBwMFFQoJCAsFFgIDAQAC HgECF4ACGQEWIQSpQNQ0mSwujpkQPVAiT6fnzIKmZAUCZ8ga5gUJGtCBUAAKCRAiT6fnzIKm ZLljEACddSH94E+dD+XU0h0o3OgLczf/MeMYW00ZaK5FsnIPbxf/VdQHXd7KcvIFTdpc7X6O 53MlUbUoymNLhhJdEa8EEaH9F9FEGD6fL7DRoE35gxwxSnCGlvffktvD2oeKH0NKPMam1vNu 3Imq5RA5n4Nfw3hMQzmi7JXI8eFyy9h7GVcyjhDnb2WsLGAQIAKSGqlfdmrkEelhaIoTEMQ9 cDIZPGhmDGcdHXuEwRWk5qZGOGoH8AsJz5SXEWe00PB4qyKnhzhkD6c20eFL9qBC/54IVFvS qk1rZGON2NnNQtGwR9i5ghThKo9ALgbS1ha7IsnsyElpnM4Xa5VcFxNTQZlNqWch57lkFihA LATi0USes50huWtgjTMGbaVgud5w5ScGEexVQKc7uGUK6TiCKxmp209VcWqH6NoM3gbekYad XQzw3ykgIgJzTQNPffw56kIwJLOzooglFujThxw3w8+SN8k1znU5X4vpJCkoIB24rGevPTMd f8uf/6lA7o2O1HbDnOAwDIkUdZqurRU1YBHRFf2Me7z/DyMPbkUNcaGFQ/hZopC4ch7j12GM smzuUQ/3WkwHGeuzGHJZqZyVAX+86gXXx16OURuwrfsbWMkDAo9nTVQzl5UsWrCYE/N9dhkl uAge7mIix4uRKlIYHfSA6o7N+cXY16V+zFHlmd6LOM7ATQRbGTU1AQgAn0H6UrFiWcovkh6E XVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQLa1PQDUi6j00ChlcR66g9/V0sPIcSutacPKf dKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMhFmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCT sTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sfbAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZO rIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq+aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahK tQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4njQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJks Lo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8ACgkQIk+n58yCpmS2PA//bqN1LfcotmArgEls a+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKYHR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4 Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVdSXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94 wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi4U9F/trLten/x7bpphDSnDMKJtITbtzATT1D q7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O40PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwg BF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9Yplav CMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/PwIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1 pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dqNcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudL vPA/SK8sKoM01IRxSihev/S/5WLazXB1PGemOCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR 22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLVjXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4 pYekxJujNeEDkUlky0Y= In-Reply-To: <96556748872BB47E+20260612071359.649946-1-chenyichong@uniontech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/12/26 09:13, Yichong Chen wrote: > SLUB exports the total_objects sysfs attribute, but slabinfo tries to read > objects_total. As a result, the lookup fails and the field remains zero. > > Use the correct attribute name and rename the corresponding structure > member to match. > > Fixes: 205ab99dd103 ("slub: Update statistics handling for variable order slabs") Huh, it has never worked correctly, since 2008. Applied to slab/for-next, thanks! > Signed-off-by: Yichong Chen > --- > tools/mm/slabinfo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/mm/slabinfo.c b/tools/mm/slabinfo.c > index 54c7265ab52d..f4077746d6df 100644 > --- a/tools/mm/slabinfo.c > +++ b/tools/mm/slabinfo.c > @@ -33,7 +33,7 @@ struct slabinfo { > unsigned int hwcache_align, object_size, objs_per_slab; > unsigned int sanity_checks, slab_size, store_user, trace; > int order, poison, reclaim_account, red_zone; > - unsigned long partial, objects, slabs, objects_partial, objects_total; > + unsigned long partial, objects, slabs, objects_partial, total_objects; > unsigned long alloc_fastpath, alloc_slowpath; > unsigned long free_fastpath, free_slowpath; > unsigned long free_frozen, free_add_partial, free_remove_partial; > @@ -1263,7 +1263,7 @@ static void read_slab_dir(void) > slab->object_size = get_obj("object_size"); > slab->objects = get_obj("objects"); > slab->objects_partial = get_obj("objects_partial"); > - slab->objects_total = get_obj("objects_total"); > + slab->total_objects = get_obj("total_objects"); > slab->objs_per_slab = get_obj("objs_per_slab"); > slab->order = get_obj("order"); > slab->partial = get_obj("partial");