From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1410C433EF for ; Sat, 15 Jan 2022 13:18:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232040AbiAONSK (ORCPT ); Sat, 15 Jan 2022 08:18:10 -0500 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:57040 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231788AbiAONSI (ORCPT ); Sat, 15 Jan 2022 08:18:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1642252688; x=1673788688; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=sbqBWwdgMQIbKtuRmLB8OT6URSY/8emRbQ+6ytu9d0Q=; b=gDtI2tJTdfNHyaUKGj0/3eCxzyllcubBtvTABqJ8j6BRfJgvjEj8sT9i l89AoVqQXOxdE+UQSC4sonbiT6DkVSA0WMuDWUV7QWzMVMNTDhJftOkxO UdRUqjG8BnUc1oxPSNVl9izMaXFJh2m1tYC0H5ui6SOd9EVvBine3XiDN Y=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 15 Jan 2022 05:18:08 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2022 05:18:08 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Sat, 15 Jan 2022 05:18:07 -0800 Received: from [10.50.45.28] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Sat, 15 Jan 2022 05:18:03 -0800 Message-ID: <65fa7fdb-1af9-152b-32a2-8388921be565@quicinc.com> Date: Sat, 15 Jan 2022 18:48:00 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCHv6 4/5] tracing: Add register read/write tracing support Content-Language: en-US From: Sai Prakash Ranjan To: Steven Rostedt CC: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , gregkh , , , , , Prasad Sodagudi References: <76983c26d889df7252a17017a48754163fb6b0d5.1638858747.git.quic_saipraka@quicinc.com> <20220106131824.073fbe5c@gandalf.local.home> <20220107095638.7d81c1b9@gandalf.local.home> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/8/2022 11:04 AM, Sai Prakash Ranjan wrote: > Hi, > > On 1/7/2022 8:26 PM, Steven Rostedt wrote: >> On Fri, 7 Jan 2022 10:40:05 +0530 >> Sai Prakash Ranjan wrote: >> >>> Hi Steve, >>> >>> On 1/6/2022 11:48 PM, Steven Rostedt wrote: >>>> This should not be in the kernel/trace directory. It should be in the >>> Hmm these are called from low level generic io header file >>> (include/asm-generic/) where >>> we wouldn't have any Kconfig to control this feature flexibly and as we >>> can have this as >>> a generic feature selectable by other architectures, wouldn't this be >>> suited in kernel/trace? >> Isn't there a place for generic rwmmio code? > > I am thinking of moving it to lib/ similar to an interface of > logic_iomem.c which > Arnd had initially suggested to look at. > >>> I thought you were ok with the folder structure in the initial versions >>> of the series? >> Sorry, I missed the C file in kernel/trace. The files in kernel/trace >> tend >> to be specific for the internals of tracing. This C file is more to hold >> helper functions for mmio, which to me should be someplace for mmio >> code. >> Perhaps in mm/ ? >> > > Oh ok, mm would not be the right fit as it is memory management and > this is about > memory mapped IO, let me try and move it to lib/ as done for > logic_iomem.c > > Thanks, > Sai Posted v7 - https://lore.kernel.org/lkml/cover.1642233364.git.quic_saipraka@quicinc.com/ Thanks, Sai