From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41878175A5
	for <linux-kernel@vger.kernel.org>; Fri, 27 Mar 2026 00:06:37 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.12
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774569998; cv=none; b=GLGRIKNbkm8qMI7r2CjO+KgJ1yH7vgwTuSwk/Jyo96ssKFiPlLjUivdestIROGPhcpOcOdZzNZHZ+gryMPc5dCKFFjRhwHe2LE49n6hLRvqXZrxEcIOGac6JQc9ulEnbxOz46MTobzBqTsG19uR0wTz8XBmpLnSdNITvtbimNRE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774569998; c=relaxed/simple;
	bh=XAOKkLVkccG5A/mO8SaYYvv2yNgfWiqomMckrdFR6Vw=;
	h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:
	 Content-Type:MIME-Version; b=nk6EfdBl2lg4k4wnXqTMM4HoRMTi5TqcglKMadiPrIKblTsicwdTUj+cgmMyFf8co9bGv+AJFm10pzFEkUwQD0KIfyC5SA9G7SmbVUbeyQLhhku6GTpYeWele2t0pUHlILU1Y1Ii2M4F/0V3mL/0MxNQrQ7tOgWLYbUCACn9bRM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com; spf=pass smtp.mailfrom=perches.com; arc=none smtp.client-ip=216.40.44.12
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perches.com
Received: from omf07.hostedemail.com (a10.router.float.18 [10.200.18.1])
	by unirelay01.hostedemail.com (Postfix) with ESMTP id AE256E1595;
	Fri, 27 Mar 2026 00:06:35 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA id 10B382002D;
	Fri, 27 Mar 2026 00:06:32 +0000 (UTC)
Message-ID: <65fe50aded2d9184bdb3198d0649e3eeb9bb3d18.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: Allow to pass config directory
From: Joe Perches <joe@perches.com>
To: Petr Vorel <pvorel@suse.cz>, Simon Glass <sjg@chromium.org>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>, 
 Dwaipayan Ray <dwaipayanray1@gmail.com>, Lukas Bulwahn
 <lukas.bulwahn@gmail.com>, Kory Maincent	 <kory.maincent@bootlin.com>, Tom
 Rini <trini@konsulko.com>, Simon Glass	 <simon.glass@canonical.com>,
 Kuan-Wei Chiu <visitorckw@gmail.com>
Date: Thu, 26 Mar 2026 17:06:32 -0700
In-Reply-To: <20260326205020.GA23245@pevik>
References: <20260224181623.89904-1-pvorel@suse.cz>
	 <CAFLszThqc0EOEboCtjackC=pQpnUuT-dw4o-aCSQBbxpxQD=cA@mail.gmail.com>
	 <20260326205020.GA23245@pevik>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) 
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Rspamd-Queue-Id: 10B382002D
X-Rspamd-Server: rspamout06
X-Stat-Signature: q5655sxodj5kxjqi3fn5z5jpci3hfbka
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX1/FbrcKgjeLzQVmLVp87Yp1DJy3rNWyTi8=
X-HE-Tag: 1774569992-45557
X-HE-Meta: U2FsdGVkX19UjYrQ635O7M2AoYXKQ5ziZacvLOiSWm3gb4SCQqNnzAfshDFEwGiHVvcr/uZ49W8YjnbjLWnL8MrPyfNB1AsiaiKKsntwySK7bX3qExNXJ05KIliNKRkaWwab1936YfMEXUArCZMGkfzKm/hvCwPCCv79fT4dTVKczuFpW31jF5J/ZujWYXDDOEMZJphY3Y9tCkN3YlEkkJnlyFeo0peFCiqy7fCBtVCbvLRfj33K8xYQ8XzUbQkGyvOHEtsAtdAKaVvdNQE11MndPK4Or8qCQ5aax3fe/l01LFFc3csHqMTJrjos8x7q

On Thu, 2026-03-26 at 21:50 +0100, Petr Vorel wrote:

> > my $paths =3D $def_configuration_dirs;
> > $paths =3D "$ENV{$env_config_dir}:$paths" if exists($ENV{$env_config_di=
r});
>=20
> +1, sure, thanks!

Why have two uses of $ENV{$env_config_dir}?
Seems typo error prone and somewhat difficult to read.