From: Joe Perches <joe@perches.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 20/28] file: checkpatch wanking
Date: Tue, 29 Nov 2011 18:14:18 -0800 [thread overview]
Message-ID: <6602085da94606147a643dc8516f1cf484a5e06e.1322609673.git.joe@perches.com> (raw)
In-Reply-To: <cover.1322609672.git.joe@perches.com>
Reflowed comments. Now checkpatch clean.
$ ./scripts/checkpatch.pl -f --terse --nosummary fs/file.c | \
cut -f3- -d":" | sort | uniq -c
1 ERROR: "foo * bar" should be "foo *bar"
1 ERROR: space required before the open parenthesis '('
4 WARNING: line over 80 characters
Signed-off-by: Joe Perches <joe@perches.com>
---
fs/file.c | 21 ++++++++++++---------
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/fs/file.c b/fs/file.c
index a88b110..7128878 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -45,8 +45,9 @@ static DEFINE_PER_CPU(struct fdtable_defer, fdtable_defer_list);
static void *alloc_fdmem(unsigned int size)
{
/*
- * Very large allocations can stress page reclaim, so fall back to
- * vmalloc() if the allocation size will be considered "large" by the VM.
+ * Very large allocations can stress page reclaim so
+ * fall back to vmalloc() if the allocation size will
+ * be considered "large" by the VM.
*/
if (size <= (PAGE_SIZE << PAGE_ALLOC_COSTLY_ORDER)) {
void *data = kmalloc(size, GFP_KERNEL|__GFP_NOWARN);
@@ -78,7 +79,7 @@ static void free_fdtable_work(struct work_struct *work)
fdt = f->next;
f->next = NULL;
spin_unlock_bh(&f->lock);
- while(fdt) {
+ while (fdt) {
struct fdtable *next = fdt->next;
__free_fdtable(fdt);
@@ -141,7 +142,7 @@ static void copy_fdtable(struct fdtable *nfdt, struct fdtable *ofdt)
memset((char *)(nfdt->close_on_exec) + cpy, 0, set);
}
-static struct fdtable * alloc_fdtable(unsigned int nr)
+static struct fdtable *alloc_fdtable(unsigned int nr)
{
struct fdtable *fdt;
char *data;
@@ -157,9 +158,10 @@ static struct fdtable * alloc_fdtable(unsigned int nr)
nr = roundup_pow_of_two(nr + 1);
nr *= (1024 / sizeof(struct file *));
/*
- * Note that this can drive nr *below* what we had passed if sysctl_nr_open
- * had been set lower between the check in expand_files() and here. Deal
- * with that in caller, it's cheaper that way.
+ * Note that this can drive nr *below* what we had passed
+ * if sysctl_nr_open had been set lower between the check
+ * in expand_files() and here.
+ * Deal with that in caller, it's cheaper that way.
*
* We make sure that nr remains a multiple of BITS_PER_LONG - otherwise
* bitmaps handling below becomes unpleasant, to put it mildly...
@@ -213,8 +215,9 @@ static int expand_fdtable(struct files_struct *files, int nr)
if (!new_fdt)
return -ENOMEM;
/*
- * extremely unlikely race - sysctl_nr_open decreased between the check in
- * caller and alloc_fdtable(). Cheaper to catch it here...
+ * extremely unlikely race - sysctl_nr_open decreased
+ * between the check in caller and alloc_fdtable().
+ * Cheaper to catch it here...
*/
if (unlikely(new_fdt->max_fds <= nr)) {
__free_fdtable(new_fdt);
--
1.7.6.405.gc1be0
next prev parent reply other threads:[~2011-11-30 2:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 2:13 [PATCH 00/28] fs: Logging style neatening and " Joe Perches
2011-11-30 2:13 ` [PATCH 01/28] buffer: Use pr_<level> Joe Perches
2011-11-30 2:14 ` [PATCH 02/28] mbcache: Use current logging styles Joe Perches
2011-11-30 2:14 ` [PATCH 03/28] bio: " Joe Perches
2011-11-30 2:14 ` [PATCH 04/28] libfs: " Joe Perches
2011-11-30 2:14 ` [PATCH 05/28] super: " Joe Perches
2011-11-30 2:14 ` [PATCH 06/28] exec: Use current logging style Joe Perches
2011-11-30 2:14 ` [PATCH 07/28] namespace: Use current logging styles Joe Perches
2011-11-30 2:14 ` [PATCH 08/28] block_dev: Use current logging style Joe Perches
2011-11-30 2:14 ` [PATCH 09/28] dcache: " Joe Perches
2011-11-30 2:14 ` [PATCH 10/28] fcntl: " Joe Perches
2011-11-30 2:14 ` [PATCH 11/28] file: " Joe Perches
2011-11-30 2:14 ` [PATCH 12/28] locks: " Joe Perches
2011-11-30 2:14 ` [PATCH 13/28] open: " Joe Perches
2011-11-30 2:14 ` [PATCH 14/28] stat: " Joe Perches
2011-11-30 2:14 ` [PATCH 15/28] exec: checkpatch wanking Joe Perches
2011-11-30 2:14 ` [PATCH 16/28] namespace: " Joe Perches
2011-11-30 2:22 ` Al Viro
2011-11-30 3:39 ` Joe Perches
2011-11-30 6:50 ` Al Viro
2011-11-30 8:34 ` Joe Perches
2011-11-30 2:14 ` [PATCH 17/28] block_dev: " Joe Perches
2011-11-30 2:14 ` [PATCH 18/28] dcache: " Joe Perches
2011-11-30 2:14 ` [PATCH 19/28] fcntl: " Joe Perches
2011-11-30 2:14 ` Joe Perches [this message]
2011-11-30 2:14 ` [PATCH 21/28] locks: " Joe Perches
2011-11-30 2:14 ` [PATCH 22/28] open: " Joe Perches
2011-11-30 2:14 ` [PATCH 23/28] stat: " Joe Perches
2011-11-30 2:14 ` [PATCH 24/28] super: " Joe Perches
2011-11-30 2:14 ` [PATCH 25/28] libfs: " Joe Perches
2011-11-30 2:14 ` [PATCH 26/28] bio: " Joe Perches
2011-11-30 2:14 ` [PATCH 27/28] mbcache: " Joe Perches
2011-11-30 2:14 ` [PATCH 28/28] buffer: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6602085da94606147a643dc8516f1cf484a5e06e.1322609673.git.joe@perches.com \
--to=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®