From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbcB2NKs (ORCPT ); Mon, 29 Feb 2016 08:10:48 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:56774 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752889AbcB2NKp (ORCPT ); Mon, 29 Feb 2016 08:10:45 -0500 From: Arnd Bergmann To: Mathieu Desnoyers Cc: Peter Zijlstra , Linus Torvalds , Ben Maurer , Thomas Gleixner , Ingo Molnar , Russell King , linux-api , Andrew Morton , Michael Kerrisk , Dave Watson , rostedt , Andy Lutomirski , Will Deacon , "Paul E. McKenney" , Chris Lameter , Andi Kleen , Josh Triplett , Paul Turner , Linux Kernel Mailing List , Catalin Marinas , Andrew Hunter , "H. Peter Anvin" Subject: Re: [PATCH v4 1/5] getcpu_cache system call: cache CPU number of running thread Date: Mon, 29 Feb 2016 14:08:34 +0100 Message-ID: <6606463.JuxkKBhKjS@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1811549980.11849.1456749709589.JavaMail.zimbra@efficios.com> References: <1456270120-7560-1-git-send-email-mathieu.desnoyers@efficios.com> <3364335.Bqf8sAzlTS@wuerfel> <1811549980.11849.1456749709589.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xyZF8QDF3TBRLboqNzVUtm8AeVh4qoam35IdlfrOX8VE+d8Noyx h3YUrx0r0wxk+mS4sviaqB2KXfOrGXFcVyByICWPh3VP/Yup3l7c0YZjKkK+L2kJ/B8sLhh Zrt+I+/WkFxrXLRn8aSJx46AJjYwibsZt30FD3qUuP0kxGcvvHS/7pRXkoJ9JMlOvs4Hqw6 aahUoFzP0T0Ft+8ykLmuw== X-UI-Out-Filterresults: notjunk:1;V01:K0:PdNcPqYoMQk=:H55NSG4WdR3J76jHLashK1 qDkZQ7L08PavuUY5IvcKCd2B0bng3d5BZwWV2qOl7C0IxpxKDw4Tp8EB7umoClEw/hcBzXazy 5ZfrVX4V+B6xrUhEG8sLhMiXxi9wjNK+YLq1XNFRD83O61dRHbpqKadPrUO86nQMLzAen2IYh 9BibeD1okk7Th3WIDJsYWaVAq22utPK2FQmLQfQ0HKrxZZXqrtAAwzssE2xLJsgN1HmopbfaQ XvCRHDiZx430D405WrUP9sf8touMMRsSpuN569YRaaKgJTDlVKxVTf9G1TRcl+hp6EBbl6WDU sg1+563st5nmBWSrvBg8L92r4g1Vbe8wt6iPZQo3jkQ61tmpQkreNJCRcalOHlGh90TcUb2l2 F136ihjxK6ApFuF0xQ4pOzDVz8VxsGKeeqTKNZ0lHvQJqJ1afmGYf9VFXCCiC5XKUWeFSa0dA 3nNdv0Ra46HYt5rum4HKzce8UzihjzuP71MVPR0eKF8egL4uuMqccCaw/l4kiU0si9YdHYW71 EfF8//lkt0xj5R3V2bRbyDK72Qbpc8yi8hVvxHq2VYpO7rbLdeD79HcCarcY7K8vM3UjrMmmN pHF9XcorCWGO03OLNtP4BgOcxp1qcY6jp4X4O9bieaeRYq1G4Qw9/Wp3I/bFIhkD9Y0yjUu5h /OmJvzNZeryhtmA/pNHOH4t1BTYMqq/azWfssERwwt3AES0ZcRH8eDUxnOleOgsSE/Ma+crzv I6VrQpIdHuNWUv3B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 29 February 2016 12:41:49 Mathieu Desnoyers wrote: > ----- On Feb 29, 2016, at 5:39 AM, Arnd Bergmann arnd@arndb.de wrote: > > What's making things worse is that on some architectures, adding > > __packed will force access by bytes rather than just reading > > a 32-bit or 64-bit numbers directly, so it's slow and non-atomic. > > Agreed that many architectures issue slower instructions when reading > from packed structures, which is unwanted. > > Could we require that each field be naturally aligned and require that > they are placed so _no_ padding whatsoever should ever be added by the > compiler ? If that's possible, then we could remove the packed. Yes, I think that is a reasonable requirement. Arnd