From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 782EA32B10D for ; Tue, 4 Aug 2026 11:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785841724; cv=none; b=kAKKHbrOrpgUQlzmbBeiD29FIGam6hlDdzlu4dBmUTTmqeNoDi5aLkzjbZ5eP0lfCnWr5ZNQ/EKcoVsovh9AT8CX3Ld9dkdrsiMCqKUAssMNF45//aFckwOVXxAAoAFwvS45/HNAvlCP0qPmgKHotpGa+Jrl2JAq2kMe7V1KlWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785841724; c=relaxed/simple; bh=8maOdKXZZdlgEKtChtKM+Xq4lTV0NTWga9dYHBgtUko=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zvb+J61L9bX9RfN7lN4HFqRnqtkRARLy4pJ77h6MiFCGm7/i41C2GcIYYk+jcSZV27oRGgFb7BsTcGdTgVYiv1WxvS3ETjxJECXQBjM+7eOtOgq3v5Lb/zCN5DM5UObtM4Qg4B9FIfzwwPMpNcLHbIzmXM10o+Fkco+ituzGfac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=s8g+swmT; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="s8g+swmT" Received: from [192.168.88.20] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 14176741; Tue, 4 Aug 2026 13:07:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785841649; bh=8maOdKXZZdlgEKtChtKM+Xq4lTV0NTWga9dYHBgtUko=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=s8g+swmTuXKR7TDiw35+fJW3/UdDNRlAgP5KYwmQuWKS4EzejfT6fWDb2L7HO3LMr HZutwUuvD0eJBRCV5LLlPpD2AqLmxAO++xcwrdunDJe3hIVd0A+vDAwItn2QiR1VhX 3CWZtslG0Vv87Q4DXywqhZq32nSrA6eNiTI4huAk= Message-ID: <660d65ee-92af-4420-a2b7-6feda2dca11f@ideasonboard.com> Date: Tue, 4 Aug 2026 14:08:35 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/omap: dsi: do not copy isr table To: Andreas Kemnade Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter References: <20260702-dsi-uaf-v2-1-dbb4aa0f0b8e@kemnade.info> <20260804104908.46937116@kemnade.info> Content-Language: en-US From: Tomi Valkeinen In-Reply-To: <20260804104908.46937116@kemnade.info> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 04/08/2026 11:49, Andreas Kemnade wrote: > On Wed, 29 Jul 2026 11:23:21 +0300 > Tomi Valkeinen wrote: > >> Hi, >> >> On 02/07/2026 18:27, Andreas Kemnade wrote: >>> To te able to unregister stuff from isrs, the corresponding table was >>> copied. Nobody seems to unregister stuff that way, so it does not help. >>> But there are stack-allocated objects passed to these isrs giving chances >>> of UAF of these objects if irqs are unregistered while they are handled, >>> so better do not copy that table. >>> >>> Fixes: 4ae2ddddf44cd ("OMAP: DSS2: DSI: Add ISR support") >>> Signed-off-by: Andreas Kemnade >>> --- >>> If this gets backported, it should be re-checked that >>> no isr unregisters itself in older kernel versions`. >>> --- >>> Changes in v2: >>> - remove variable definition (Sashiko) >>> - Link to v1: https://patch.msgid.link/20260629-dsi-uaf-v1-1-a5e894f4e4d1@kemnade.info >> >> Looks good to me, applying to drm-misc-next. >> > It seems not to be on linux-next. somehow this did fall through the cracks? It did. I applied it to my local dim branch, then went looking for other omapdrm patches (the dsi one), which took a while and... yes, forgot to push... Pushed now to drm-misc-next. Tomi