From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Johan Hovold <johan@kernel.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Bjorn Andersson <andersson@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<quic_pkondeti@quicinc.com>, <quic_ppratap@quicinc.com>,
<quic_jackp@quicinc.com>, <ahalaney@redhat.com>,
<quic_shazhuss@quicinc.com>
Subject: Re: [PATCH v13 05/10] usb: dwc3: qcom: Refactor IRQ handling in QCOM Glue driver
Date: Fri, 10 Nov 2023 16:39:05 +0530 [thread overview]
Message-ID: <660f50a6-79e7-4b62-aad4-29453fa5b2be@quicinc.com> (raw)
In-Reply-To: <ZU4JeenAf_K8liAI@hovoldconsulting.com>
>>
>> While I do so, since there are no qusb2 targets present on femto phy's, do
>> you suggest we still add them to port structure in dwc3-qcom ? I am inclined
>> to add it because it would make implementation look cleaner w.r.t code and
>> also spurious interrupts are not getting triggered (which was my primary
>> concern as it was never tested).
>
> Yes, that's what I've been suggesting all along. It's a per-port
> interrupt so that's where it belongs.
>
> We should still try to determine when each interrupt should be enabled
> and how best to implement that (hence all my questions).
>
> For example, if there is no use for hs interrupts on SoCs using femto
> PHYs we should fix the bindings. If we can use dp/dm on SoCs using QUSB2
> PHYs, we should probably just ignore the hs interrupt when all three are
> defined (especially since that functionality has never worked anyway).
>
Sure. Will finalise this once I get the complete info (why do we have
dp/dm on qusb targets)
And apologies, I mentioned "qusb2 targets on femto phy's".
It was supposed to be "hs_phy_irq's on femto phy targets", but I think
you got the gist of my question. Thanks for the response.
Regards,
Krishna,
next prev parent reply other threads:[~2023-11-10 18:07 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 15:47 [PATCH v13 00/10] Add multiport support for DWC3 controllers Krishna Kurapati
2023-10-07 15:47 ` [PATCH v13 01/10] usb: dwc3: core: Access XHCI address space temporarily to read port info Krishna Kurapati
2023-10-20 8:32 ` Johan Hovold
2023-10-20 9:42 ` Krishna Kurapati PSSNV
2023-10-23 8:44 ` Johan Hovold
2023-10-07 15:47 ` [PATCH v13 02/10] usb: dwc3: core: Skip setting event buffers for host only controllers Krishna Kurapati
2023-10-20 8:38 ` Johan Hovold
2023-10-07 15:47 ` [PATCH v13 03/10] usb: dwc3: core: Refactor PHY logic to support Multiport Controller Krishna Kurapati
2023-10-12 17:26 ` Thinh Nguyen
2023-10-20 9:57 ` Johan Hovold
2023-10-20 11:41 ` Krishna Kurapati PSSNV
2023-10-23 8:52 ` Johan Hovold
2023-10-22 18:03 ` Krishna Kurapati PSSNV
2023-10-23 9:11 ` Johan Hovold
2023-10-23 12:33 ` Krishna Kurapati PSSNV
2023-10-23 14:10 ` Johan Hovold
2023-10-07 15:48 ` [PATCH v13 04/10] usb: dwc3: qcom: Add helper function to request threaded IRQ Krishna Kurapati
2023-10-20 12:30 ` Johan Hovold
2023-10-07 15:48 ` [PATCH v13 05/10] usb: dwc3: qcom: Refactor IRQ handling in QCOM Glue driver Krishna Kurapati
2023-10-20 13:23 ` Johan Hovold
2023-10-22 18:41 ` Krishna Kurapati PSSNV
2023-10-23 9:21 ` Johan Hovold
2023-10-23 11:24 ` Krishna Kurapati PSSNV
2023-10-23 14:07 ` Johan Hovold
2023-10-23 17:12 ` Krishna Kurapati PSSNV
2023-10-24 6:56 ` Johan Hovold
2023-10-24 8:53 ` Krishna Kurapati PSSNV
2023-10-24 9:18 ` Johan Hovold
2023-10-24 9:23 ` Greg Kroah-Hartman
2023-10-24 9:29 ` Johan Hovold
2023-10-24 9:54 ` Greg Kroah-Hartman
2023-11-03 10:04 ` Krishna Kurapati PSSNV
2023-11-07 8:29 ` Krishna Kurapati PSSNV
2023-11-09 15:18 ` Johan Hovold
2023-11-09 16:38 ` Krishna Kurapati PSSNV
2023-11-09 20:25 ` Wesley Cheng
2023-11-10 9:28 ` Johan Hovold
2023-11-10 9:18 ` Johan Hovold
2023-11-10 10:01 ` Krishna Kurapati PSSNV
2023-11-10 10:44 ` Johan Hovold
2023-11-10 11:09 ` Krishna Kurapati PSSNV [this message]
2023-11-15 17:42 ` Krishna Kurapati PSSNV
2023-11-16 13:03 ` Johan Hovold
2023-11-22 19:32 ` Krishna Kurapati PSSNV
2023-11-23 13:44 ` Johan Hovold
2023-11-24 9:00 ` Krishna Kurapati PSSNV
2023-11-24 9:13 ` Krzysztof Kozlowski
2023-11-24 10:13 ` Johan Hovold
2023-11-24 10:38 ` Krishna Kurapati PSSNV
2023-11-24 11:19 ` Johan Hovold
2023-10-07 15:48 ` [PATCH v13 06/10] usb: dwc3: qcom: Enable wakeup for applicable ports of multiport Krishna Kurapati
2023-10-23 15:47 ` Johan Hovold
2023-10-23 17:27 ` Krishna Kurapati PSSNV
2023-10-24 7:10 ` Johan Hovold
2023-10-24 8:41 ` Krishna Kurapati PSSNV
2023-10-24 9:06 ` Johan Hovold
2023-10-07 15:48 ` [PATCH v13 07/10] usb: dwc3: qcom: Add multiport suspend/resume support for wrapper Krishna Kurapati
2023-10-23 15:58 ` Johan Hovold
2023-10-23 17:22 ` Krishna Kurapati PSSNV
2023-10-24 7:03 ` Johan Hovold
2023-10-07 15:48 ` [PATCH v13 08/10] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280 Krishna Kurapati
2023-10-08 11:11 ` Krzysztof Kozlowski
2023-10-08 11:21 ` Krishna Kurapati PSSNV
2023-10-08 11:23 ` Krzysztof Kozlowski
2023-10-12 16:40 ` Konrad Dybcio
2023-10-12 17:02 ` Krishna Kurapati PSSNV
2023-10-18 11:57 ` Krishna Kurapati PSSNV
2023-10-23 16:09 ` Johan Hovold
2023-10-23 17:16 ` Krzysztof Kozlowski
2023-10-23 17:34 ` Krishna Kurapati PSSNV
2023-10-24 7:13 ` Johan Hovold
2023-10-07 15:48 ` [PATCH v13 09/10] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports Krishna Kurapati
2023-10-12 16:40 ` Konrad Dybcio
2023-10-23 16:23 ` Johan Hovold
2023-10-23 17:42 ` Krishna Kurapati PSSNV
2023-10-24 7:20 ` Johan Hovold
2023-10-24 8:26 ` Krishna Kurapati PSSNV
2023-10-07 15:48 ` [PATCH v13 10/10] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller Krishna Kurapati
2023-10-12 16:41 ` Konrad Dybcio
2023-10-23 16:30 ` Johan Hovold
2023-10-08 10:43 ` [PATCH v13 00/10] Add multiport support for DWC3 controllers Krzysztof Kozlowski
2023-10-08 11:01 ` Krishna Kurapati PSSNV
2023-10-08 11:09 ` Krzysztof Kozlowski
2023-10-10 20:51 ` Konrad Dybcio
2023-10-11 5:11 ` Krishna Kurapati PSSNV
2023-10-11 9:34 ` Konrad Dybcio
2023-10-12 6:17 ` Krishna Kurapati PSSNV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=660f50a6-79e7-4b62-aad4-29453fa5b2be@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_jackp@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®