From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79028C433EF for ; Mon, 14 Feb 2022 16:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbiBNQNJ (ORCPT ); Mon, 14 Feb 2022 11:13:09 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230109AbiBNQNF (ORCPT ); Mon, 14 Feb 2022 11:13:05 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ADF3CFE; Mon, 14 Feb 2022 08:12:57 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: usama.anjum) with ESMTPSA id 6743F1F438A4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644855176; bh=xszuPxTh+RrzQKdIk/UYX7m0IGZxD+CwZJwkc1byRNE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Ox3V1acuR+hSOBVzElsGhFQ8rG9+6L/wP8sjXuVapRZ7yoQjj3DHWjBoqgpyHkoX5 76BHrtYZ7MAjYVi99wdgv1CmPmfjQSJBLwO8Rh7tmStfo5U7bk6PALpi3bgMZZtpSr yYiVU1ML3GhZteHchvEssnFHl3rlCAoAHpOljqwjqDsq5fBGYtDIfvIkvlZi3sphjb HyhsDzmYbJYLk8ngZjCRcEeG2IZXu/srQTj2bVX41YOrSspvnoVWMNTIP781NdPTIG cwN9npokyHQJvN5fnS/oyQ9Jvg2ngGwyX58u2AXNgWC4Et2m0cgX8iwnkrxjShlHrQ HfDyy19xoDoLQ== Message-ID: <66140ffb-306e-2956-2f6b-c017a38e18f8@collabora.com> Date: Mon, 14 Feb 2022 21:12:46 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: usama.anjum@collabora.com, Shuah Khan , "shuah@kernel.org" , Kees Cook , "luto@amacapital.net" , "wad@chromium.org" , "christian@brauner.io" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "kafai@fb.com" , "songliubraving@fb.com" , "yhs@fb.com" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" Subject: Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers Content-Language: en-US To: Sherry Yang References: <20220210203049.67249-1-sherry.yang@oracle.com> <755ec9b2-8781-a75a-4fd0-39fb518fc484@collabora.com> <85DF69B3-3932-4227-978C-C6DAC7CAE64D@oracle.com> From: Muhammad Usama Anjum In-Reply-To: <85DF69B3-3932-4227-978C-C6DAC7CAE64D@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> "../../../../usr/include/" directory doesn't have header files if >> different output directory is used for kselftests build like "make -C >> tools/tests/selftest O=build". Can you try adding recently added >> variable, KHDR_INCLUDES here which makes this kind of headers inclusion >> easy and correct for other build combinations as well? >> >> > > Hi Muhammad, > > I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice > work! I really appreciate you made headers inclusion compatible. However, > my case is a little more complicated. It will throw warnings with -I, using > -isystem can suppress these warnings, more details please refer to > https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/ > > According to this case, do you think will it be better to export header path > (KHDR_INCLUDES) without “-I”? Well said. I've thought about it and it seems like -isystem is better than -I. I've sent a patch: https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/ I'm looking forward to discussion on it. Thanks, Usama