From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Gobert <richardbgobert@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, willemdebruijn.kernel@gmail.com,
dsahern@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: Richard Gobert <richardbgobert@gmail.com>
Subject: Re: [PATCH net-next v5 4/6] net: gro: add {inner_}network_offset to napi_gro_cb
Date: Tue, 09 Apr 2024 11:05:46 -0400 [thread overview]
Message-ID: <6615594ab06f2_23a2b22945@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20240408141720.98832-5-richardbgobert@gmail.com>
Richard Gobert wrote:
> This patch adds network_offset and inner_network_offset to napi_gro_cb, and
> makes sure both are set correctly. In the common path there's only one
> write (skb_gro_reset_offset).
>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
> ---
> include/net/gro.h | 18 ++++++++++++++++--
> net/8021q/vlan_core.c | 2 ++
> net/core/gro.c | 1 +
> net/ethernet/eth.c | 1 +
> net/ipv4/af_inet.c | 5 +----
> net/ipv4/gre_offload.c | 1 +
> net/ipv6/ip6_offload.c | 8 ++++----
Should this cover more protocols, like geneve, ipsec?
next prev parent reply other threads:[~2024-04-09 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 14:17 [PATCH net-next v5 0/6] net: gro: encapsulation bug fix and flush checks improvements Richard Gobert
2024-04-08 14:17 ` [PATCH net-next v5 1/6] net: gro: add flush check in udp_gro_receive_segment Richard Gobert
2024-04-08 14:17 ` [PATCH net-next v5 2/6] net: gro: add p_off param in *_gro_complete Richard Gobert
2024-04-08 14:17 ` [PATCH net-next v5 3/6] selftests/net: add local address bind in vxlan selftest Richard Gobert
2024-04-08 14:17 ` [PATCH net-next v5 4/6] net: gro: add {inner_}network_offset to napi_gro_cb Richard Gobert
2024-04-09 15:05 ` Willem de Bruijn [this message]
2024-04-10 13:00 ` Richard Gobert
2024-04-08 14:17 ` [PATCH net-next v5 5/6] net: gro: move L3 flush checks to tcp_gro_receive Richard Gobert
2024-04-08 14:17 ` [PATCH net-next v5 6/6] selftests/net: add flush id selftests Richard Gobert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6615594ab06f2_23a2b22945@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®