From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94293C49EA5 for ; Wed, 23 Jun 2021 21:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6910A613C2 for ; Wed, 23 Jun 2021 21:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbhFWV4L (ORCPT ); Wed, 23 Jun 2021 17:56:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28790 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbhFWV4K (ORCPT ); Wed, 23 Jun 2021 17:56:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624485231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kBBzsr+ZYLTbIgPBN9G6o8mL6wPVlZyxFWIvteb0X/A=; b=X4HuUUCYvgUv7hjlBeX/ijDMh+OQe15XjF0c6codfaMx01fJVcIAruwU7172nJ4jFK5hzp GgjRiQDlhLou0hmcaJzwFw7O2pgUDNwKCDrE73hY3OVXwSH+tU/S9fD+DSfS0jSm3v/nGr cKGpyRMkwqvJJ94LGQWhPWy8AYsgNkU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-mjHmmHJxMoSqDMV0kyu6YA-1; Wed, 23 Jun 2021 17:53:50 -0400 X-MC-Unique: mjHmmHJxMoSqDMV0kyu6YA-1 Received: by mail-ed1-f69.google.com with SMTP id j15-20020a05640211cfb0290394f9de5750so1507635edw.16 for ; Wed, 23 Jun 2021 14:53:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kBBzsr+ZYLTbIgPBN9G6o8mL6wPVlZyxFWIvteb0X/A=; b=Ek2Gfa3m7B3kC8YhPb4FarHSnBJ+6b/9AZAVv/qQy2ei/1ppFafc1cjMcCrzT1LPgT FuP3QAaADhUrWmLp5DReXtqHC2BTduWHO+u5spGbxTkmMHwjA1JOTBUkXyk1qeCgUxBn PSOJ31M6BpHTCMaQEcmLSrYtfaxFZBLHB7zja3EuVG10W4nLl63mu2+hQh+knqC0WKqK qP1tLCVciH/rjQzbZdeGCIrMgE2f4hEOvvlst1diVSRwACFf27q3BnUtXRj+Lt79NBzy Who/Y6+QT7XyqbM6mWmOdVCVzUEWSfKJKvBRD04EKWEQnzBsPTjDe5vOqEu0TS5T3DjA W4vA== X-Gm-Message-State: AOAM531UDOx0fEMyKylE7/6EoHsVc6LY7XTXcbrFf+RPF/QWVCy7kRdC Nbih27/96v/vh2U3wfFGHQhUdu/wkrn/gf2xMu9b0zoj5ANw2/K3TXsF4w7fuzjOjqPuFA2wa+C SxkATv7W+WseXdFSPqsjGPQ5Z X-Received: by 2002:a17:907:264c:: with SMTP id ar12mr2007530ejc.391.1624485229122; Wed, 23 Jun 2021 14:53:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJxPYaKsnGl8LmvyIJ1VWsmrmW42CoD80D/qn82+ZpwNUFI0DVRsZ3EpyESryxresI8lb57g== X-Received: by 2002:a17:907:264c:: with SMTP id ar12mr2007520ejc.391.1624485228979; Wed, 23 Jun 2021 14:53:48 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id b25sm715289edv.9.2021.06.23.14.53.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 14:53:48 -0700 (PDT) Subject: Re: [PATCH 04/10] KVM: SVM: add warning for mistmatch between AVIC state and AVIC access page state To: Maxim Levitsky , kvm@vger.kernel.org Cc: Thomas Gleixner , Sean Christopherson , Wanpeng Li , Vitaly Kuznetsov , Joerg Roedel , Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jim Mattson References: <20210623113002.111448-1-mlevitsk@redhat.com> <20210623113002.111448-5-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <6617e1f2-23dd-9132-d866-7780663533c3@redhat.com> Date: Wed, 23 Jun 2021 23:53:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210623113002.111448-5-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/21 13:29, Maxim Levitsky wrote: > It is never a good idea to enter a guest when the AVIC state doesn't match > the state of the AVIC MMIO memory slot. > > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/svm/svm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index 12c06ea28f5c..50405c561394 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -3780,6 +3780,9 @@ static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu) > > pre_svm_run(vcpu); > > + WARN_ON_ONCE(vcpu->kvm->arch.apic_access_memslot_enabled != > + kvm_vcpu_apicv_active(vcpu)); > + > sync_lapic_to_cr8(vcpu); > > if (unlikely(svm->asid != svm->vmcb->control.asid)) { > For patches 4-6, can the warnings actually fire without the fix in patch 2? Paolo