From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F94C77B70 for ; Mon, 17 Apr 2023 07:40:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbjDQHky (ORCPT ); Mon, 17 Apr 2023 03:40:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbjDQHku (ORCPT ); Mon, 17 Apr 2023 03:40:50 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E7B75251 for ; Mon, 17 Apr 2023 00:40:27 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id hg25-20020a05600c539900b003f05a99a841so20548460wmb.3 for ; Mon, 17 Apr 2023 00:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681717220; x=1684309220; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3y8aPQgOvoJwSTlB16np8gZ7mEu48SprWU1OLM7t2EY=; b=Q0kUWkbBARCqihzYfC7ynvUsdGTkhMsyh5fm7/hrg/kyLi3UR04bgDIUB4ijsOVsof n4+aUNm6adB+iF9ilW/GhfMexNEp8a6+yj+45qlIP0UQOaC4h14EgODg+Mcs1vIZmiOq 4dvC4rT2aC0Fy8WAlHsfX5bhRvN5iPkAiNgKRZI/h2Q+ttwC7rOfSXXAZOPkx2lnXbHQ uRnyTChkbe2DvC9PM9DWYIsDFd0KvSj1L9DAVyjgbeeyw+wgLM8Te5vqk9cF4qE7kiPs znPe2LOvB1Gr6+UrxctYlyUDU80t4YcwCJSjCwGT13vzrmTKQL4I07XxekurnFx+WMG3 Xt3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681717220; x=1684309220; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3y8aPQgOvoJwSTlB16np8gZ7mEu48SprWU1OLM7t2EY=; b=drit2zHJPJVqFHoFzPjG5hE/AwaCcW9v7TTJEc2+M6cZLrAcF1lbGziy/iMfVyntg7 FLSYYsYUgJCmnT4RWZ45/a1mhEDRmmp5WPa6limQ6Y4kWFhvgnCac/9ZWwv9IINDE1NX Gsvtfa3Ls+bhYUwtWspCpbhk1OTiu0xt+mCOxIEzzUc0E1F+JTlzvYWQpdKw/o8X44HZ 8IhgXt3aDTpyulPqwQS/yu7s5p5XezFi8lMAOUsjPA+viNJrpBzW6pMdHY73mHZWeW8H oBliO4SbmqLTmlPezKwPjTQJXLDfoUp+3HRrMwV8xE+5p27m+PFohuWGcIe3YaZkuwiw WPTQ== X-Gm-Message-State: AAQBX9edBg8LmGyWbPaTtaW2HK12+i7eyibIofaSEMFVddYVmYmiLI8w 7qG7ssg6OskAYR/Xe4BFuaVmLw== X-Google-Smtp-Source: AKy350bC5HsSl1Rn6Xmxt8XlYpLz2a7Ubqu4/u6z89XV16jAKStdTlpNZTICilRh9Bz+VJLGEzgGLw== X-Received: by 2002:a05:600c:22c7:b0:3eb:3945:d405 with SMTP id 7-20020a05600c22c700b003eb3945d405mr10243498wmg.38.1681717220686; Mon, 17 Apr 2023 00:40:20 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:a1e1:81a8:1acc:2b91? ([2a01:e0a:982:cbb0:a1e1:81a8:1acc:2b91]) by smtp.gmail.com with ESMTPSA id g2-20020a05600c000200b003f0aa490336sm10481002wmc.26.2023.04.17.00.40.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 00:40:20 -0700 (PDT) Message-ID: <661a2ac6-adfe-dec9-5b7b-b006f2f31a90@linaro.org> Date: Mon, 17 Apr 2023 09:40:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device Content-Language: en-US To: James Cowgill , Sam Ravnborg , David Airlie , Daniel Vetter , Philippe CORNU , Thierry Reding Cc: "stable@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" References: <20230412173450.199592-1-james.cowgill@blaize.com> Organization: Linaro Developer Services In-Reply-To: <20230412173450.199592-1-james.cowgill@blaize.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/2023 19:35, James Cowgill wrote: > This is the logical place to put the backlight device, and it also > fixes a kernel crash if the MIPI host is removed. Previously the > backlight device would be unregistered twice when this happened - once > as a child of the MIPI host through `mipi_dsi_host_unregister`, and > once when the panel device is destroyed. > > Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API") > Signed-off-by: James Cowgill > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > index b4729a94c34a8..898b892f11439 100644 > --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > @@ -471,7 +471,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi) > DRM_MODE_CONNECTOR_DSI); > > ctx->bl_dev = devm_backlight_device_register(dev, dev_name(dev), > - dsi->host->dev, ctx, > + dev, ctx, > &otm8009a_backlight_ops, > NULL); > if (IS_ERR(ctx->bl_dev)) { Reviewed-by: Neil Armstrong