From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: linux-sound@vger.kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, perex@perex.cz, iwai@suse.com
Subject: Re: [PATCH] ASoC: soc-topology: fix __le32 conversion in printed values
Date: Wed, 11 Mar 2026 17:17:29 +0000 [thread overview]
Message-ID: <661af6a3-f5aa-42cf-bd20-6881ace426d1@codethink.co.uk> (raw)
In-Reply-To: <e535797b-2a15-4996-90e4-33d13bf5d689@sirena.org.uk>
On 11/03/2026 17:11, Mark Brown wrote:
> On Tue, Mar 10, 2026 at 09:49:48AM +0000, Ben Dooks wrote:
>
>> @@ -225,7 +225,10 @@ static inline void soc_control_err(struct soc_tplg *tplg,
>> {
>> dev_err(tplg->dev,
>> "ASoC: no complete control IO handler for %s type (g,p,i) %d:%d:%d at 0x%lx\n",
>> - name, hdr->ops.get, hdr->ops.put, hdr->ops.info,
>> + name,
>> + le32_to_cpu(hdr->ops.get),
>> + le32_to_cpu(hdr->ops.put),
>> + le32_to_cpu(hdr->ops.info),
>
> Shouldn't we also change the prints to %u given that le32_to_cpu() works
> with unsigned data (IIRC)?
Possibly. But given the data was already marked __le32 it was already
unsigned.
Do we want to go through changing these before committing this or
delay it to another patch?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2026-03-11 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 9:49 Ben Dooks
2026-03-11 17:11 ` Mark Brown
2026-03-11 17:17 ` Ben Dooks [this message]
2026-03-11 17:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661af6a3-f5aa-42cf-bd20-6881ace426d1@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=iwai@suse.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®