From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53D223101A0 for ; Wed, 15 Apr 2026 12:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776257792; cv=none; b=jgZywE7W3Z0MpXoXOUrZahCoOEDHVAzCgmTSa8ucqR5/7aq0z6K769G5rj3robR/Q7lRLwfoI61RtZ9qtdOslb8XbIKZSSvWYAL8bIc5qN/ghsORpyCdXI13owNWj0U8sAT+t/s0+/qzjRuRWeZQue2TJrVEENVaQSaRiC70dUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776257792; c=relaxed/simple; bh=3NF/UT+bIdNGyzpzYRH7TdrzumbZFNv2O65NMnOA8tY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=FGv0aKAE8nCgyhd6Ku3EUXP97JxpE6GFKDx47UM2j7Ww+L/N6DzFWGS/aeuQyRxCJAyng3SFVPPFIfaQSll28OVEpjOHGkZBop8XDVePynLcoV69+6yP8DSdY9fvQQzyfiEMylFTVNTvP2iX9iaOpQF8jYWNYe27mGKd5SJCUUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tasrePbG; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tasrePbG" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso63550135e9.3 for ; Wed, 15 Apr 2026 05:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776257788; x=1776862588; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=TlZO0eraAxc9RdlGoUu/4T/udUp+sK68ZU76CN9CV3w=; b=tasrePbGlTg56XJvGmeyalLwXzcmwN72Y38ySygAj1LdS4WluYzhENWxAkZZ+3rcHL iwnLWQIqwls5Rq+l2D59XTk1MIfhunSy2HcvWRVDMppzJl7wvqfmdxmv6ITtuu3/ztme OJNuo85CItPSLPfHKDCixDEUS5jW2ocknBE/PPh2K+uJAu6++MzQE94aVEJTIhE0EhUq Mf49xG6fMrm5CjgnSyGRKluxyNnXIoJH5N5PVWCsiriB50Ygx1xUgFjCgv41NVXb6Lpi xrLq39qsOvFIWlsWzUELPnRQNTe+gnJRY+LsmjMe6Cn79Gl7RpfctdIHP1Ok4ZKz9M6Q XQyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776257788; x=1776862588; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TlZO0eraAxc9RdlGoUu/4T/udUp+sK68ZU76CN9CV3w=; b=PWXX3zII9Oj4llv1uQgPXSGiBMG3oZSv2P5ZUTAVG/Y8b7Kope8r4MCn7D2oIiTNo/ LRVY/vdBGJes/37hiF7brukewK1FG07jB4RqMntFnBpLDeLiUlPO1TKQ8PnJzHy32sfW 6ZLRijhQxQ8A+RDELzvByk622JuNzqKw3H/ti9i789XHtcYJlD3OUO3BcjHHi2zFChgg EgCtDAT6ef6OGQHrNojsLF9VblzUGJZse5hTPqJlHvy7QOkz7NQjYnV4nPu/Mu/DSR8r zZZlY0ZJjXxus2gIlQyFocI/tEKM1DTziDVwKLlIzghqEh2a62H3Z1aq8GddCBpGoe5X ZKGg== X-Forwarded-Encrypted: i=1; AFNElJ+NZx/ZzO4zU/Fq4Ggp+C/NhXlr2XZy9pqX9EyCNIcxGIofczDljqYtyLvFF6kLseC+2HDFoN8wK33ZG5Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxH8Tl4fJ7UJLrRYBczItAGocpW6+rJImCEFj5vefw28kVBeVjc sqx320XRt/IEoC92dnBIxSG+x5P+vjt3AcsIEJcubsTUnOwzK4Pm/KcuPXyv5KOKHVA= X-Gm-Gg: AeBDiet3VvhDuMUDxjyRAYk/En8BMobqCoTufXBwkD8irAFkADUkpuabQ3WeVHdcLWm DFlyMPshLhMcdvR/ipSH58ye0tOGpGfJhj6Hn6IXUv5ZjTTj3CFYqbKmrGtd1g8qLCsJNTHlZ12 sP+JPxqdrx7EjhhVj/umvEhSNMpsHBzf550gOCZy175SmCaS3wzRnefYQ/yB7g2a9/7TuwqG5NH pbnehBmLaqWto85U280Wbnw8WUKXzH54f0+Gu8KKX1WzqsDtQ2d66gNChZPW/06HoBIhqCKquLe X7SOAn5Tq9MXAvfiUcjaYkacbM1TazFWq6AEpubnKQXw8SuaFg93s2lHXWkNJvRVrIsT8sDmGBA IHlyvFlzcx6IL5oWxdi/HPZeNdhkvAZet5fu8sfdZLUhapPRdD8uiqK1Yl0fOB80rWvgFTR2D6D Gof1OwQ2Q2RAog9gUZbLi8DrWHOoXWAaDm9AxQyschqwkxG6Y30A4asO3FgLeYl2wdd73JiabQT IzFbXrf8++xOhYd3g== X-Received: by 2002:a05:600c:3b29:b0:486:fbf6:abd4 with SMTP id 5b1f17b1804b1-488d67d24cbmr280170325e9.9.1776257787605; Wed, 15 Apr 2026 05:56:27 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1c29:ca2f:5699:2fdf? ([2a01:e0a:106d:1080:1c29:ca2f:5699:2fdf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f1d5dd43sm49046795e9.0.2026.04.15.05.56.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 05:56:26 -0700 (PDT) Message-ID: <661c12a0-d736-4a5e-8bd5-43f0b46da4d6@linaro.org> Date: Wed, 15 Apr 2026 14:56:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v3 2/2] drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels To: Dmitry Baryshkov , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Joseph Guo , Marek Vasut , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260412-ws-lcd-v3-0-db22c2631828@oss.qualcomm.com> <20260412-ws-lcd-v3-2-db22c2631828@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260412-ws-lcd-v3-2-db22c2631828@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/12/26 19:32, Dmitry Baryshkov wrote: > Several Waveshare DSI LCD kits use LVDS panels and the ICN6202 DSI2LVDS > bridge. Support that setup by handling waveshare,dsi2lvds compatible. > The only difference with the existing waveshare,dsi2dpi is the bridge's > output type (LVDS vs DPI). > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/bridge/waveshare-dsi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c > index 32d40414adb9..ded57f298d64 100644 > --- a/drivers/gpu/drm/bridge/waveshare-dsi.c > +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c > @@ -177,7 +177,7 @@ static int ws_bridge_probe(struct i2c_client *i2c) > regmap_write(ws->reg_map, 0xc2, 0x01); > regmap_write(ws->reg_map, 0xac, 0x01); > > - ws->bridge.type = DRM_MODE_CONNECTOR_DPI; > + ws->bridge.type = (uintptr_t)i2c_get_match_data(i2c); > ws->bridge.of_node = dev->of_node; > devm_drm_bridge_add(dev, &ws->bridge); > > @@ -185,7 +185,8 @@ static int ws_bridge_probe(struct i2c_client *i2c) > } > > static const struct of_device_id ws_bridge_of_ids[] = { > - {.compatible = "waveshare,dsi2dpi",}, > + {.compatible = "waveshare,dsi2dpi", .data = (void *)DRM_MODE_CONNECTOR_DPI, }, > + {.compatible = "waveshare,dsi2lvds", .data = (void *)DRM_MODE_CONNECTOR_LVDS, }, > { } > }; > > Reviewed-by: Neil Armstrong Thanks, Neil