From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95B73BCD2F for ; Wed, 10 Jun 2026 09:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781082894; cv=none; b=OQ3t6PSLCU2KoUSjCR27JUQzzDeMPDKTOx481jATIWFJqi0pX46iSvkjZibs5sNDe5BiI4aX87m1TEqc58k6tMwGedAeSNexAhnqAFP4pqrMlATP+mTFK2GHvw+1wyBeROzAl1wiAn1SdsLbLhmXcsrJLrS8Bjkp5/yU0VbmON0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781082894; c=relaxed/simple; bh=+3Oey1WWs5aR95mQcQBU7xyu2mXS3uTyCEBbqJb8qu8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XagxsOP7tg7RGd3MBdakOEPi9acSxaq5s6nRlFd5Jrx8TB0hlfqOUwhWpBhQpBbCi1hAtzwGZEKz9zEB4LQPvxa90ykq1N0isuLo7Sr7qTAW5cBsZSmJHvRqxQk/XP9MbgeYiphmEv4p8wzQPM9jbDFGSZ9vScrHs3909IWwb1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nLVn6rlp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d95lrpSv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nLVn6rlp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d95lrpSv" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A8x26m735793 for ; Wed, 10 Jun 2026 09:14:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N6BysjMJ/71Lcvntk0+U+p4cz371ihNxbLf/Gr/x7fI=; b=nLVn6rlpvacqkfb8 xl8mVCl47/jMHJJCxTc9ECH+9JYmS2d8y7mPZkGLIMx4sLwwCL2UBe264kZG1m+E 5SqgVEqnH3b4QQU7Z0ZbHKMyAn8S+VSBYi86tvM8HddOMSleeSDBoqOxaYbDpyIU LL+QgTtGE0B9cFqMgVtFnkLaG3DnLzTlEN2cl7whoyVMnJlpKHy0FAWdRPJBZUCr krFGOK7k/FgEwOKrLBofNd7vuD3QkCAgYS2lyqxFyLKxXMGw3vRq4756iRZnBgds 4PdJStD/fNVwsM3r6J3RAuUdQweeedZK5RFdiVEs20ah4R6rJkT7ZZ2BUNu3DTnP hGqDTw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq4w1r22a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 09:14:50 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36d98b5a68fso11387843a91.2 for ; Wed, 10 Jun 2026 02:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781082890; x=1781687690; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N6BysjMJ/71Lcvntk0+U+p4cz371ihNxbLf/Gr/x7fI=; b=d95lrpSvdeXk9Db56WMk/3nlPAuxWdEjy+03GktsVYkPS85prSaJ7YiEXtbzrv0BZQ g3iHBL2caPp97MkQZYMcwBaCLi+cA2Cn3BBMovyx2dbDVHyI5y2N8/3MXGlGYPRylHxO ymigqxgecpa/Qqh3qKWNcFTHQpOvsMwHyOHLDTmHW/Ug4neDPA6EbDZt7U0P/LQvO4Y7 VoqGvPlSJSGvCv0WEry7G78Q2rfioF6GYpXbkwB8rDt6lVT7qF5j8nfpLUXwo1uWJENf c2BBNwjt6mkEKuwK/9LWYoW7Nf8SEEv8354+MT+K75gILmveIQgAuh6KG3E8vkmrwt9n 9ayA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781082890; x=1781687690; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N6BysjMJ/71Lcvntk0+U+p4cz371ihNxbLf/Gr/x7fI=; b=TGKLRoFFwgbQD0A2uhYtbFLI0pWIOje4Svp20WHKNxo/vUMFDTr7ByMC9C/lHRPc1j VjrJDRQrSI5LTZIz/Lt28Ca+nceLkrgpAH2SFS41L1i5cBoEFmlbptsUf/Inh0+8lVWT mOEUHpvDSUOj9nzMlmvlGTkKVAb5guqpenj3TsE71TPlVyHD5cYgzFtQaPVQETTegg4+ +G/awVSmq2EeJQEn5PoZilBUt45hk4wWQF8xKT8SKmFydJJKycuoWY7RizhCjDGMhgPQ ca6j3PPgbOAodCH+Ce1BM85EYgdxDXqr0bvhN3cfDkxxB2WjZoLHKKqVOXBmh61z8gGG o4jg== X-Forwarded-Encrypted: i=1; AFNElJ8Cex5av31DU/dSCw1kFv6Pr3q8PyWQHoX0o+iTJn+HFiCo8ieIcRs9RWmAJtsDmNoIX/kgdKPEIN+L5d0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywgs0CwW/XyUFPwwRJMadYBHtwIkaQiZgRt1fVVHvvwRcYV3LAB ilDMoCnHtGXtiyoBZ9wIGxqrTNjM2C4gdnn1FEZmMHK/Y+nkXqp9pid6hr9QzL9kGCgNG9QAlC6 eFzEvz8+/9541yEoXUXj9Wl3TN8I1FUGtphDlMc6/wpFPof4K+fafQncjXI3/fHyikSA= X-Gm-Gg: Acq92OEPBWn6XMWaz0Io26WZOJgpv6zs+LmFHCih5s+/cbVswmi6XILAR0B7Hy8rw7y MVlYyaI2OIFJMtggUEFAuP4reHgyRy/cjsxjPp58ccgLFrYx/iCxj6gjCO9wlgBP+AHRbpI3vUE Ym4ImgVKqFk7XGr1bKLayVqUkUPJ4mywHEI1VjyB5BV8Rim/ttPKCXQj0dbbYp07G/ZE3xoU7l/ 2vJ5GbvgkRa9JfBDk/UFo71etmxUSxSsTogypQhLty3B/9/8KTIpkS27VNYq45K7l9PoHX0sr5T 1f5XmkmgTueTVy0TCK2l53xVGjtehPwSXEOkb9xPQ7IL2low5POxEq86h2xl5VUtD5ZENSe5CBf M7Oa/SWkiNoFPjHLsuTPMs4ggpcDFHlGaJyWCXyRR+BV/UeRjYWscHN3Ho8Hr X-Received: by 2002:a17:90b:280c:b0:36a:f612:e6a3 with SMTP id 98e67ed59e1d1-370f0095b7bmr27502268a91.17.1781082890282; Wed, 10 Jun 2026 02:14:50 -0700 (PDT) X-Received: by 2002:a17:90b:280c:b0:36a:f612:e6a3 with SMTP id 98e67ed59e1d1-370f0095b7bmr27502244a91.17.1781082889858; Wed, 10 Jun 2026 02:14:49 -0700 (PDT) Received: from [10.218.18.193] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3762514be1bsm2796226a91.17.2026.06.10.02.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 02:14:49 -0700 (PDT) Message-ID: <661e2c15-0528-4cdc-a7ed-ddced32f7ddd@oss.qualcomm.com> Date: Wed, 10 Jun 2026 14:44:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] pinctrl: qcom: lpass-lpi: drop unused runtime-PM write helper To: Krzysztof Kozlowski , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610080809.2588640-1-ajay.nandam@oss.qualcomm.com> <0fc4d9d4-2943-4ed8-a8ea-014e83c74e5c@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 8H5cosTADTqPVbWqRd2rf5kfj9WS0szw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA4NyBTYWx0ZWRfX/+GWcxmD+9PR tjG1RdbUUh2Ye13dV2jwe/+1o7Rl/c3EAxeiIKj+2im9UmU8IH5bPiHQegnzRPoejDcItMcWIuX YWfMhmEhPSxiZo6CGbsUjbjtcG0Gn60/CdR2B0XR0LSEJj1xY9OCu6Bxt16BCfKeYUyKFRUcNNc fwwbklFzu9sgQiaUeFXlKGQnRHaNs05LUqubRPOzYje8oO5KAAeLXfu7iu2AnmFDX5rW1e2MwLM CFmSJw1YovhTqHM3z0GwMXUlvDxAm+PUSwKxapbTjxXzQ/MB7WRFA9twivb/xP7m70FzWgIyAQH Yg3LjxwRvVopBSWrPiCKjuwlvhvdkgp1Myjql6Nnmj75nP/IUMQUgYAW1nVauCCtAyYrNA+IivZ RL4ubqEZl08ZzVQ33N9A2I5iSfPqSyI3Tt+Z12E65LCGwgUO4gS+VJjCWp5tbm+ip6ve+pB3lBH clFK7YtZJEyhGZvM9/w== X-Proofpoint-GUID: 8H5cosTADTqPVbWqRd2rf5kfj9WS0szw X-Authority-Analysis: v=2.4 cv=ZfEt8MVA c=1 sm=1 tr=0 ts=6a292b0a cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=NdOHzJ4ck5ORsDkasxEA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100087 On 6/10/2026 2:30 PM, Krzysztof Kozlowski wrote: > On 10/06/2026 10:57, Ajay Kumar Nandam wrote: >>> So why do we need __lpi_gpio_write()? >> >> Hi Krzysztof, >> >> Thanks, good point. >> >> I will respin with: >> Reported-by: Nathan Chancellor > > > And checkpatch. > >> >> About __lpi_gpio_write(): it is still needed for the in-callers path >> where runtime PM is already held and we only need the raw MMIO helper. >> The unused wrapper is lpi_gpio_write(), so this fix removes only that >> dead function. > > No. Why did you have to add __ prefix? Why do we need function named > with such style? Hi Krzysztof, The __ prefix was introduced during refactoring to distinguish the raw MMIO helper from lpi_gpio_write(). After the wrapper became unused and was removed, the naming is less clear. Do you recommend renaming these helpers to regular/raw names (without __) while keeping behavior unchanged? Thanks, Ajay > > Best regards, > Krzysztof