From: Zijun Hu <zijun_hu@icloud.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Antonino Daplas <adaplas@gmail.com>, Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH] fbdev/nvidiafb: Correct const string length in nvidiafb_setup()
Date: Fri, 25 Apr 2025 19:21:16 +0800 [thread overview]
Message-ID: <6621335c-b099-43f3-8c4e-eff7dfec57ac@icloud.com> (raw)
In-Reply-To: <87o6wky613.fsf@intel.com>
On 2025/4/25 16:55, Jani Nikula wrote:
>> } else if (!strncmp(this_opt, "noscale", 7)) {
>> noscale = 1;
> A further cleanup could be to replace all of the strncmp's with
> str_has_prefix(this_opt, "...") to avoid this class of errors
> altogether. It also returns the length of the prefix on match, and that
> can be used to drop more magic numbers.
very agree with your point. may use strstarts().
there are many strncmp() usages with long const string and hardcoded
string length. some usages are wrong.
prev parent reply other threads:[~2025-04-25 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 11:55 Zijun Hu
2025-04-24 22:18 ` Helge Deller
2025-04-25 8:55 ` Jani Nikula
2025-04-25 11:21 ` Zijun Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6621335c-b099-43f3-8c4e-eff7dfec57ac@icloud.com \
--to=zijun_hu@icloud.com \
--cc=adaplas@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®